Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: components/omnibox/base_search_provider.cc

Issue 911723002: Provide description_class in search provider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a long line Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omnibox/base_search_provider.cc
diff --git a/components/omnibox/base_search_provider.cc b/components/omnibox/base_search_provider.cc
index a18b66c2e26c79041a53e8865af383cdfdb94f4d..7cb5837eae3edb66963d062529355d3c2ad37048 100644
--- a/components/omnibox/base_search_provider.cc
+++ b/components/omnibox/base_search_provider.cc
@@ -222,8 +222,13 @@ AutocompleteMatch BaseSearchProvider::CreateSearchSuggestion(
suggestion.suggestion().length() - match.contents.length()));
}
- if (!suggestion.annotation().empty())
+ if (!suggestion.annotation().empty()) {
match.description = suggestion.annotation();
+ ACMatchClassifications classifications;
+ classifications.push_back(
+ ACMatchClassification(0, ACMatchClassification::DIM));
Peter Kasting 2015/02/09 23:46:43 Why is this DIM instead of NONE like most descript
Maria 2015/02/10 01:13:28 I was under impression that DIM allowed descriptio
Peter Kasting 2015/02/10 01:28:51 Yeah, descriptions are auto-dimmed. We probably w
+ match.description_class = classifications;
Peter Kasting 2015/02/09 23:46:43 Nit: Simpler: AutocompleteMatch::AddLastClassif
Maria 2015/02/10 01:13:28 Done.
+ }
// suggestion.match_contents() should have already been collapsed.
match.allowed_to_be_default_match =
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698