Provide description_class in search provider.

Provide description_class in search provider.

When we receive entity suggest results, we put the differentiating
descrition in the AutocompleteMatch's description field. We need to
provide the corresponding description_class, otherwise we trigger
validation DCHECKs in AutocompleteMatch.

Committed: https://crrev.com/e68a1cec6e2a0955df4a0c4764d6633468a91888
Cr-Commit-Position: refs/heads/master@{#315485}

[Maria, 2015-02-09 21:50:25]

mariakhomenko@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2015-02-09 23:46:43]

https://codereview.chromium.org/911723002/diff/20001/components/omnibox/base_...
File components/omnibox/base_search_provider.cc (right):

https://codereview.chromium.org/911723002/diff/20001/components/omnibox/base_...
components/omnibox/base_search_provider.cc:229: ACMatchClassification(0,
ACMatchClassification::DIM));
Why is this DIM instead of NONE like most descriptions?

https://codereview.chromium.org/911723002/diff/20001/components/omnibox/base_...
components/omnibox/base_search_provider.cc:230: match.description_class =
classifications;
Nit: Simpler:

  AutocompleteMatch::AddLastClassificationIfNecessary(
      &match.description_class, 0, ACMatchClassification::NONE);

[Maria, 2015-02-10 01:13:28]

https://codereview.chromium.org/911723002/diff/20001/components/omnibox/base_...
File components/omnibox/base_search_provider.cc (right):

https://codereview.chromium.org/911723002/diff/20001/components/omnibox/base_...
components/omnibox/base_search_provider.cc:229: ACMatchClassification(0,
ACMatchClassification::DIM));
On 2015/02/09 23:46:43, Peter Kasting wrote:
> Why is this DIM instead of NONE like most descriptions?

I was under impression that DIM allowed description text to be grey in the UI,
but I tried out NONE and it's still grey, so going with NONE.

https://codereview.chromium.org/911723002/diff/20001/components/omnibox/base_...
components/omnibox/base_search_provider.cc:230: match.description_class =
classifications;
On 2015/02/09 23:46:43, Peter Kasting wrote:
> Nit: Simpler:
> 
>   AutocompleteMatch::AddLastClassificationIfNecessary(
>       &match.description_class, 0, ACMatchClassification::NONE);

Done.

[Peter Kasting, 2015-02-10 01:28:51]

LGTM

https://codereview.chromium.org/911723002/diff/20001/components/omnibox/base_...
File components/omnibox/base_search_provider.cc (right):

https://codereview.chromium.org/911723002/diff/20001/components/omnibox/base_...
components/omnibox/base_search_provider.cc:229: ACMatchClassification(0,
ACMatchClassification::DIM));
On 2015/02/10 01:13:28, Maria wrote:
> On 2015/02/09 23:46:43, Peter Kasting wrote:
> > Why is this DIM instead of NONE like most descriptions?
> 
> I was under impression that DIM allowed description text to be grey in the UI,
> but I tried out NONE and it's still grey, so going with NONE.

Yeah, descriptions are auto-dimmed.  We probably want NONE here so that if in
the future we decide to change how we display descriptions in general, that
change applies to these items as well.

[Maria, 2015-02-10 01:57:43]

The CQ bit was checked by mariakhomenko@chromium.org

[commit-bot: I haz the power, 2015-02-10 01:59:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/911723002/40001

[commit-bot: I haz the power, 2015-02-10 03:06:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-10 03:06:44]

Patchset 3 (id:??) landed as
https://crrev.com/e68a1cec6e2a0955df4a0c4764d6633468a91888
Cr-Commit-Position: refs/heads/master@{#315485}