Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 911723002: Provide description_class in search provider. (Closed)

Created:
5 years, 10 months ago by Maria
Modified:
5 years, 10 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide description_class in search provider. When we receive entity suggest results, we put the differentiating descrition in the AutocompleteMatch's description field. We need to provide the corresponding description_class, otherwise we trigger validation DCHECKs in AutocompleteMatch. Committed: https://crrev.com/e68a1cec6e2a0955df4a0c4764d6633468a91888 Cr-Commit-Position: refs/heads/master@{#315485}

Patch Set 1 #

Patch Set 2 : Fixed a long line #

Total comments: 5

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M components/omnibox/base_search_provider.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Maria
5 years, 10 months ago (2015-02-09 21:50:25 UTC) #2
Peter Kasting
https://codereview.chromium.org/911723002/diff/20001/components/omnibox/base_search_provider.cc File components/omnibox/base_search_provider.cc (right): https://codereview.chromium.org/911723002/diff/20001/components/omnibox/base_search_provider.cc#newcode229 components/omnibox/base_search_provider.cc:229: ACMatchClassification(0, ACMatchClassification::DIM)); Why is this DIM instead of NONE ...
5 years, 10 months ago (2015-02-09 23:46:43 UTC) #3
Maria
https://codereview.chromium.org/911723002/diff/20001/components/omnibox/base_search_provider.cc File components/omnibox/base_search_provider.cc (right): https://codereview.chromium.org/911723002/diff/20001/components/omnibox/base_search_provider.cc#newcode229 components/omnibox/base_search_provider.cc:229: ACMatchClassification(0, ACMatchClassification::DIM)); On 2015/02/09 23:46:43, Peter Kasting wrote: > ...
5 years, 10 months ago (2015-02-10 01:13:28 UTC) #4
Peter Kasting
LGTM https://codereview.chromium.org/911723002/diff/20001/components/omnibox/base_search_provider.cc File components/omnibox/base_search_provider.cc (right): https://codereview.chromium.org/911723002/diff/20001/components/omnibox/base_search_provider.cc#newcode229 components/omnibox/base_search_provider.cc:229: ACMatchClassification(0, ACMatchClassification::DIM)); On 2015/02/10 01:13:28, Maria wrote: > ...
5 years, 10 months ago (2015-02-10 01:28:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911723002/40001
5 years, 10 months ago (2015-02-10 01:59:03 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-10 03:06:07 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 03:06:44 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e68a1cec6e2a0955df4a0c4764d6633468a91888
Cr-Commit-Position: refs/heads/master@{#315485}

Powered by Google App Engine
This is Rietveld 408576698