Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 911713003: add transitions for global properties in ics (Closed)

Created:
5 years, 10 months ago by dcarney
Modified:
5 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

add transitions for global properties in ics R=verwaest@chromium.org BUG= Committed: https://crrev.com/307d2bdd8145b2aa1207ed846f49dfa6c90d93c4 Cr-Commit-Position: refs/heads/master@{#26569}

Patch Set 1 #

Patch Set 2 : code sharing #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : GlobalObject #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : blah #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -36 lines) Patch
M src/ic/ic.cc View 1 2 3 4 3 chunks +24 lines, -9 lines 0 comments Download
M src/lookup.h View 4 chunks +9 lines, -9 lines 0 comments Download
M src/lookup.cc View 1 2 3 4 5 2 chunks +16 lines, -2 lines 0 comments Download
M src/objects.h View 1 2 3 4 2 chunks +3 lines, -4 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 7 8 4 chunks +11 lines, -12 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dcarney
ptal
5 years, 10 months ago (2015-02-10 11:37:27 UTC) #2
Toon Verwaest
lgtm
5 years, 10 months ago (2015-02-10 14:34:45 UTC) #3
dcarney
please look again, i think i have all the type nonsense sorted. the problem was ...
5 years, 10 months ago (2015-02-10 20:46:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911713003/140001
5 years, 10 months ago (2015-02-11 08:44:23 UTC) #7
commit-bot: I haz the power
Committed patchset #9 (id:140001)
5 years, 10 months ago (2015-02-11 09:15:24 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 09:15:42 UTC) #9
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/307d2bdd8145b2aa1207ed846f49dfa6c90d93c4
Cr-Commit-Position: refs/heads/master@{#26569}

Powered by Google App Engine
This is Rietveld 408576698