Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: ui/views/controls/textfield/textfield.h

Issue 9117012: Rename visual style "password" to "obscured" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: copyright Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/textfield/native_textfield_wrapper.h ('k') | ui/views/controls/textfield/textfield.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/textfield/textfield.h
diff --git a/ui/views/controls/textfield/textfield.h b/ui/views/controls/textfield/textfield.h
index b976354a778ec707b8e07c53ce04c80b726fd824..6c62fa727cb4e787bff6a96a407d03d79089611e 100644
--- a/ui/views/controls/textfield/textfield.h
+++ b/ui/views/controls/textfield/textfield.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -47,7 +47,7 @@ class VIEWS_EXPORT Textfield : public View {
enum StyleFlags {
STYLE_DEFAULT = 0,
- STYLE_PASSWORD = 1 << 0,
+ STYLE_OBSCURED = 1 << 0,
STYLE_LOWERCASE = 1 << 1
};
@@ -63,12 +63,13 @@ class VIEWS_EXPORT Textfield : public View {
bool read_only() const { return read_only_; }
void SetReadOnly(bool read_only);
- // Gets/Sets whether or not this Textfield is a password field.
- // TODO(bryeung): Currently this is only used in
+ // Gets/sets the STYLE_OBSCURED bit, controlling whether characters in this
+ // Textfield are displayed as asterisks/bullets.
+ // TODO(bryeung): Currently SetObscured is only used in
// chrome/browser/chromeos/options/wifi_config_view.cc, which is being
- // converted to WebUI. Please remove this when that happens.
- bool IsPassword() const;
- void SetPassword(bool password);
+ // converted to WebUI. Please remove it when that happens.
+ bool IsObscured() const;
+ void SetObscured(bool obscured);
// Gets/Sets the input type of this textfield.
ui::TextInputType GetTextInputType() const;
« no previous file with comments | « ui/views/controls/textfield/native_textfield_wrapper.h ('k') | ui/views/controls/textfield/textfield.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698