Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 9117012: Rename visual style "password" to "obscured" (Closed)

Created:
8 years, 11 months ago by benrg
Modified:
8 years, 11 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, penghuang+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Rename visual style "password" to "obscured" This change renames some identifiers to distinguish the visual style of being drawn **** **** from the logical property of being a password. It is split off from issue 8748001 and issue 8747001. See http://codereview.chromium.org/8748001/#msg12 and http://codereview.chromium.org/8748001/#msg14 for discussion of the name. TEXT_INPUT_TYPE_PASSWORD is unchanged; it should perhaps be renamed, but not to OBSCURED since it affects input, not display. BUG=none TEST=It compiles. Ship it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118796

Patch Set 1 #

Patch Set 2 : fix comment #

Patch Set 3 : copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -76 lines) Patch
M chrome/browser/chromeos/login/password_changed_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/crypto_module_password_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/login_view.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_gtk.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_gtk.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views_unittest.cc View 1 2 4 chunks +9 lines, -9 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/native_textfield_win.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_wrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/textfield.h View 1 2 3 chunks +8 lines, -7 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M ui/views/controls/textfield/textfield_views_model.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ui/views/controls/textfield/textfield_views_model.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/textfield_views_model_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/examples/textfield_example.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/view_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
benrg
Just renames some identifiers. Sending to owners (ben: ui/* and chrome/browser/ui/*, davemoore: chrome/browser/chromeos/login/password_changed_view.cc)
8 years, 11 months ago (2012-01-23 23:55:59 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 11 months ago (2012-01-24 00:00:23 UTC) #2
benrg
Apparently davemoore's okay was unnecessary, hope you don't mind if I just commit it. :-)
8 years, 11 months ago (2012-01-24 00:05:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benrg@chromium.org/9117012/2003
8 years, 11 months ago (2012-01-24 00:06:05 UTC) #4
commit-bot: I haz the power
Can't process patch for file ui/views/controls/textfield/textfield_views_model.h. File's status is None, patchset upload is incomplete.
8 years, 11 months ago (2012-01-24 00:06:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benrg@chromium.org/9117012/6004
8 years, 11 months ago (2012-01-24 00:07:08 UTC) #6
commit-bot: I haz the power
8 years, 11 months ago (2012-01-24 04:33:21 UTC) #7
Change committed as 118796

Powered by Google App Engine
This is Rietveld 408576698