Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 911663002: Revert of Oilpan: Rename heap classes (Closed)

Created:
5 years, 10 months ago by caseq
Modified:
5 years, 10 months ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Oilpan: Rename heap classes (patchset #3 id:40001 of https://codereview.chromium.org/906213002/) Reason for revert: This is on top of https://codereview.chromium.org/907943002/ which needs to be reverted due to lots of browser test failures. Original issue's description: > Oilpan: Rename heap classes > > This CL renames heap classes as follows to make the naming more consistent > > [Before] > BaseHeapPage <-- HeapPage, LargeObject > ThreadHeap <-- ThreadHeapForHeapPage, ThreadHeapForLargeObject > > [After] > BasePage <-- NormalPage, LargeObjectPage > BasePageHeap <-- NormalPageHeap, LargeObjectHeap > > Also this CL renames enum values of TypedHeaps (to avoid conflict with "LargeObjectHeap"). > > BUG=420515 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189806 TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com,haraken@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -253 lines) Patch
M Source/platform/heap/Heap.h View 34 chunks +73 lines, -73 lines 0 comments Download
M Source/platform/heap/Heap.cpp View 76 chunks +158 lines, -158 lines 0 comments Download
M Source/platform/heap/HeapTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/heap/ThreadState.h View 5 chunks +12 lines, -12 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/heap/Visitor.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
caseq
Created Revert of Oilpan: Rename heap classes
5 years, 10 months ago (2015-02-09 18:34:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911663002/1
5 years, 10 months ago (2015-02-09 18:35:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=189826
5 years, 10 months ago (2015-02-09 18:36:00 UTC) #3
sof
lgtm
5 years, 10 months ago (2015-02-09 18:44:30 UTC) #4
haraken
5 years, 10 months ago (2015-02-10 01:03:44 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698