Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 911623003: MIPS: Assembler support for internal references. (Closed)

Created:
5 years, 10 months ago by balazs.kilvady
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Assembler support for internal references. Port 49cbe537e715c960fb9773af2e240133726f465b BUG= Committed: https://crrev.com/e094f909fc3e364b35dcdd8aca1d6ca852653586 Cr-Commit-Position: refs/heads/master@{#26534}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -8 lines) Patch
M src/mips/assembler-mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 11 chunks +51 lines, -8 lines 0 comments Download
M src/mips/constants-mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 3 chunks +215 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
balazs.kilvady
5 years, 10 months ago (2015-02-09 20:09:37 UTC) #2
paul.l...
LGTM, but one comment nit. https://codereview.chromium.org/911623003/diff/1/src/mips/assembler-mips.cc File src/mips/assembler-mips.cc (right): https://codereview.chromium.org/911623003/diff/1/src/mips/assembler-mips.cc#newcode676 src/mips/assembler-mips.cc:676: // Check we have ...
5 years, 10 months ago (2015-02-09 20:14:38 UTC) #3
balazs.kilvady
https://codereview.chromium.org/911623003/diff/1/src/mips/assembler-mips.cc File src/mips/assembler-mips.cc (right): https://codereview.chromium.org/911623003/diff/1/src/mips/assembler-mips.cc#newcode676 src/mips/assembler-mips.cc:676: // Check we have a branch or jump instruction. ...
5 years, 10 months ago (2015-02-09 20:22:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911623003/20001
5 years, 10 months ago (2015-02-09 20:24:01 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-09 20:49:55 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 21:00:11 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e094f909fc3e364b35dcdd8aca1d6ca852653586
Cr-Commit-Position: refs/heads/master@{#26534}

Powered by Google App Engine
This is Rietveld 408576698