Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 911583003: ChromeOS: Remove ThreadRestrictions::ScopedAllowIO from WizardController. (Closed)

Created:
5 years, 10 months ago by Alexander Alekseev
Modified:
5 years, 10 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS: Remove ThreadRestrictions::ScopedAllowIO from WizardController. BUG=126905 TEST=manual Committed: https://crrev.com/5fbc0b379039ca2e177ab36a33ea612b410a40f8 Cr-Commit-Position: refs/heads/master@{#315543}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update after review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M chrome/browser/chromeos/login/wizard_controller.cc View 1 3 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Alexander Alekseev
Please review.
5 years, 10 months ago (2015-02-09 14:44:42 UTC) #2
Nikita (slow)
lgtm +thestig@
5 years, 10 months ago (2015-02-09 15:09:42 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/911583003/diff/1/chrome/browser/chromeos/login/wizard_controller.cc File chrome/browser/chromeos/login/wizard_controller.cc (right): https://codereview.chromium.org/911583003/diff/1/chrome/browser/chromeos/login/wizard_controller.cc#newcode21 chrome/browser/chromeos/login/wizard_controller.cc:21: #include "base/threading/thread_restrictions.h" You can remove this now.
5 years, 10 months ago (2015-02-09 19:34:46 UTC) #5
Alexander Alekseev
https://codereview.chromium.org/911583003/diff/1/chrome/browser/chromeos/login/wizard_controller.cc File chrome/browser/chromeos/login/wizard_controller.cc (right): https://codereview.chromium.org/911583003/diff/1/chrome/browser/chromeos/login/wizard_controller.cc#newcode21 chrome/browser/chromeos/login/wizard_controller.cc:21: #include "base/threading/thread_restrictions.h" On 2015/02/09 19:34:45, Lei Zhang wrote: > ...
5 years, 10 months ago (2015-02-10 12:04:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911583003/20001
5 years, 10 months ago (2015-02-10 12:06:01 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-10 12:33:17 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 12:34:18 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5fbc0b379039ca2e177ab36a33ea612b410a40f8
Cr-Commit-Position: refs/heads/master@{#315543}

Powered by Google App Engine
This is Rietveld 408576698