Issue 911513003: Revert of Make the glyph array entries inline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 911513003: Revert of Make the glyph array entries inline. (Closed)

Created:
5 years, 10 months ago by mtklein

Modified:
5 years, 10 months ago

Reviewers:
herb_g, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Make the glyph array entries inline. (patchset #11 id:190001 of https://codereview.chromium.org/885903002/) Reason for revert: Still broken. Original issue's description: > Make the glyph array entries inline. > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4c08f16b252a55e438a61f26e5581394ed177da1 > > Committed: https://skia.googlesource.com/skia/+/b4c29ac173e6f8844327338687248b98bc94132d TBR=reed@google.com,herb@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/5a2a5e729c081aa8ddfaab3311b7730622689abf

Patch Set 1 #

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+149 lines, -151 lines)			Patch
M	src/core/SkGlyph.h	View	2 chunks	+4 lines, -10 lines	0 comments	Download
M	src/core/SkGlyphCache.h	View	1 chunk	+14 lines, -30 lines	0 comments	Download
M	src/core/SkGlyphCache.cpp	View	6 chunks	+131 lines, -111 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911513003/1

5 years, 10 months ago (2015-02-09 15:52:43 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/5a2a5e729c081aa8ddfaab3311b7730622689abf

5 years, 10 months ago (2015-02-09 15:52:56 UTC) #3

reed1

5 years, 10 months ago (2015-02-09 16:33:25 UTC) #4

Message was sent while issue was closed.

Perhaps relevant : this change did not seem to break any layouttests -- perhaps
the bug is specific to the charcode section, and not the glyphID section.

Expand Messages | Collapse Messages