Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 911513002: X87: Super Constructor Calls need to use a vector slot, not an ic slot. (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Super Constructor Calls need to use a vector slot, not an ic slot. port 64f81870ee0bc51a32620be8face35e7cbd0da92 (r26414) original commit message: Super Constructor Calls need to use a vector slot, not an ic slot. The Ast Call node is accustomed to using a vector IC slot for the cases when it uses a CallIC. The super constructor work alters this somewhat by using a CallConstructStub instead, however the CallConstructStub expects a vector slot and not a vector ic slot. This distinction needs to be maintained because slots and ic slots have different clearing strategies and are handled differently. BUG= R=weiliang.lin@intel.com Committed: https://crrev.com/e10291d843101105a1d1a7bcba1c8741fc830033 Cr-Commit-Position: refs/heads/master@{#26511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL. thanks
5 years, 10 months ago (2015-02-09 07:39:23 UTC) #2
Weiliang
lgtm
5 years, 10 months ago (2015-02-09 07:40:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911513002/1
5 years, 10 months ago (2015-02-09 07:40:18 UTC) #5
chunyang.dai
Committed patchset #1 (id:1) manually as e10291d843101105a1d1a7bcba1c8741fc830033 (presubmit successful).
5 years, 10 months ago (2015-02-09 08:00:41 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 08:00:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e10291d843101105a1d1a7bcba1c8741fc830033
Cr-Commit-Position: refs/heads/master@{#26511}

Powered by Google App Engine
This is Rietveld 408576698