app_list::Mixer: Use range-based for loops internally.

app_list::Mixer: Use range-based for loops internally.

A lot of the code is now much more readable.

Committed: https://crrev.com/2ea6dbe3bcdfee5d91dd25083ca420c6061b3827
Cr-Commit-Position: refs/heads/master@{#315269}

[Matt Giuca, 2015-02-09 01:01:11]

mgiuca@chromium.org changed reviewers:
+ calamity@chromium.org

[calamity, 2015-02-09 03:47:59]

lgtm

https://codereview.chromium.org/911483002/diff/1/ui/app_list/search/mixer.cc
File ui/app_list/search/mixer.cc (right):

https://codereview.chromium.org/911483002/diff/1/ui/app_list/search/mixer.cc#...
ui/app_list/search/mixer.cc:64: for (SearchResult* result : provider->results())
{
const SearchResult*?

https://codereview.chromium.org/911483002/diff/1/ui/app_list/search/mixer.cc#...
ui/app_list/search/mixer.cc:202: for (const SortData& new_result_sortdata :
new_results) {
I would prefer sort_data.

https://codereview.chromium.org/911483002/diff/1/ui/app_list/search/mixer.cc#...
ui/app_list/search/mixer.cc:234: for (const SortData& result_sortdata :
*results) {
Here too.

[Matt Giuca, 2015-02-09 03:57:50]

New patchsets have been uploaded after l-g-t-m from calamity@chromium.org

[Matt Giuca, 2015-02-09 04:03:38]

https://codereview.chromium.org/911483002/diff/1/ui/app_list/search/mixer.cc
File ui/app_list/search/mixer.cc (right):

https://codereview.chromium.org/911483002/diff/1/ui/app_list/search/mixer.cc#...
ui/app_list/search/mixer.cc:64: for (SearchResult* result : provider->results())
{
No, because |result| gets put into a SortData at the end of this loop body, and
that requires a mutable SearchResult.

(For largely superficial reasons... actually I tried changing it to const and
only one test was relying on it being mutable, but it is too big of a change to
make just for this const.)

https://codereview.chromium.org/911483002/diff/1/ui/app_list/search/mixer.cc#...
ui/app_list/search/mixer.cc:202: for (const SortData& new_result_sortdata :
new_results) {
On 2015/02/09 03:47:59, calamity wrote:
> I would prefer sort_data.

Done.

https://codereview.chromium.org/911483002/diff/1/ui/app_list/search/mixer.cc#...
ui/app_list/search/mixer.cc:234: for (const SortData& result_sortdata :
*results) {
On 2015/02/09 03:47:59, calamity wrote:
> Here too.

Done.

[Matt Giuca, 2015-02-09 05:01:02]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-02-09 05:01:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/911483002/20001

[commit-bot: I haz the power, 2015-02-09 05:48:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-09 05:49:28]

Patchset 2 (id:??) landed as
https://crrev.com/2ea6dbe3bcdfee5d91dd25083ca420c6061b3827
Cr-Commit-Position: refs/heads/master@{#315269}