Issue 911453002: Fix Valgrind error in earlier time_formatting_unittest.cc change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 911453002: Fix Valgrind error in earlier time_formatting_unittest.cc change. (Closed)

Created:
5 years, 10 months ago by jww

Modified:
5 years, 10 months ago

Reviewers:
danakj, James Hawkins

CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

A memory issue occurred in https://codereview.chromium.org/827123004/ because of the use of an uninitialized value in a function call. Fortunately, it turns out that call is completely unnecessary anyway, so this simply removes it. TBR=danakj@chromium.org,jhawkins@chromium.org Committed: https://crrev.com/7590a6d65013ee81142838ede188a6ecb1e0006e Cr-Commit-Position: refs/heads/master@{#315242}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	base/i18n/time_formatting_unittest.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 4 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911453002/1

5 years, 10 months ago (2015-02-08 20:25:18 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-08 20:50:44 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/7590a6d65013ee81142838ede188a6ecb1e0006e
Cr-Commit-Position: refs/heads/master@{#315242}