Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: Source/core/dom/Iterable.h

Issue 911433003: IDL: Auto-declare remaining methods implied by maplike<>/setlike<> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-iterable-continued
Patch Set: common suffix Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/modules/V8TestInterface5.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Iterable.h
diff --git a/Source/core/dom/Iterable.h b/Source/core/dom/Iterable.h
index 71b090dcd3e4d06ae1febd6c76256e923d819246..eafe6f377e7e0cfc2ed9fe7754783fc58d5de482 100644
--- a/Source/core/dom/Iterable.h
+++ b/Source/core/dom/Iterable.h
@@ -15,7 +15,7 @@ namespace blink {
template <typename KeyType, typename ValueType>
class Iterable {
public:
- Iterator* keys(ScriptState* scriptState, ExceptionState& exceptionState)
+ Iterator* keysForBinding(ScriptState* scriptState, ExceptionState& exceptionState)
{
IterationSource* source = this->startIteration(scriptState, exceptionState);
if (!source)
@@ -23,7 +23,7 @@ public:
return new IterableIterator<KeySelector>(source);
}
- Iterator* values(ScriptState* scriptState, ExceptionState& exceptionState)
+ Iterator* valuesForBinding(ScriptState* scriptState, ExceptionState& exceptionState)
{
IterationSource* source = this->startIteration(scriptState, exceptionState);
if (!source)
@@ -31,7 +31,7 @@ public:
return new IterableIterator<ValueSelector>(source);
}
- Iterator* entries(ScriptState* scriptState, ExceptionState& exceptionState)
+ Iterator* entriesForBinding(ScriptState* scriptState, ExceptionState& exceptionState)
{
IterationSource* source = this->startIteration(scriptState, exceptionState);
if (!source)
@@ -39,7 +39,7 @@ public:
return new IterableIterator<EntrySelector>(source);
}
- void forEach(ScriptState* scriptState, const ScriptValue& thisValue, const ScriptValue& callback, const ScriptValue& thisArg, ExceptionState& exceptionState)
+ void forEachForBinding(ScriptState* scriptState, const ScriptValue& thisValue, const ScriptValue& callback, const ScriptValue& thisArg, ExceptionState& exceptionState)
{
IterationSource* source = this->startIteration(scriptState, exceptionState);
@@ -154,7 +154,7 @@ class ValueIterable : public Iterable<unsigned, ValueType> {
public:
Iterator* iterator(ScriptState* scriptState, ExceptionState& exceptionState)
{
- return this->values(scriptState, exceptionState);
+ return this->valuesForBinding(scriptState, exceptionState);
}
class IterationSource : public Iterable<unsigned, ValueType>::IterationSource {
@@ -192,7 +192,7 @@ class PairIterable : public Iterable<KeyType, ValueType> {
public:
Iterator* iterator(ScriptState* scriptState, ExceptionState& exceptionState)
{
- return this->entries(scriptState, exceptionState);
+ return this->entriesForBinding(scriptState, exceptionState);
}
};
« no previous file with comments | « Source/bindings/tests/results/modules/V8TestInterface5.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698