Source/bindings/tests/results/core/V8TestInterface3.cpp - Issue 911433003: IDL: Auto-declare remaining methods implied by maplike<>/setlike<>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterface3.cpp

Issue 911433003: IDL: Auto-declare remaining methods implied by maplike<>/setlike<> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-iterable-continued

Patch Set: common suffix Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterface2.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterface3.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterface3.cpp b/Source/bindings/tests/results/core/V8TestInterface3.cpp

index bb21ff5d7507c93c5e8b09e7baea0561f81c74f9..c897c3f7b11e37f13ba039571886a78946f95a5c 100644

--- a/Source/bindings/tests/results/core/V8TestInterface3.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterface3.cpp

@@ -58,7 +58,7 @@ static void valuesMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

ExceptionState exceptionState(ExceptionState::ExecutionContext, "values", "TestInterface3", info.Holder(), info.GetIsolate());

TestInterface3* impl = V8TestInterface3::toImpl(info.Holder());

ScriptState* scriptState = ScriptState::current(info.GetIsolate());

- RawPtr<Iterator> result = impl->values(scriptState, exceptionState);

+ RawPtr<Iterator> result = impl->valuesForBinding(scriptState, exceptionState);

if (exceptionState.hadException()) {

exceptionState.throwIfNeeded();

return;

@@ -78,7 +78,7 @@ static void entriesMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

ExceptionState exceptionState(ExceptionState::ExecutionContext, "entries", "TestInterface3", info.Holder(), info.GetIsolate());

TestInterface3* impl = V8TestInterface3::toImpl(info.Holder());

ScriptState* scriptState = ScriptState::current(info.GetIsolate());

- RawPtr<Iterator> result = impl->entries(scriptState, exceptionState);

+ RawPtr<Iterator> result = impl->entriesForBinding(scriptState, exceptionState);

if (exceptionState.hadException()) {

exceptionState.throwIfNeeded();

return;

@@ -114,7 +114,7 @@ static void forEachMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

thisArg = ScriptValue(ScriptState::current(info.GetIsolate()), info[1]);

}

ScriptState* scriptState = ScriptState::current(info.GetIsolate());

- impl->forEach(scriptState, ScriptValue(scriptState, info.This()), callback, thisArg, exceptionState);

+ impl->forEachForBinding(scriptState, ScriptValue(scriptState, info.This()), callback, thisArg, exceptionState);

if (exceptionState.hadException()) {

exceptionState.throwIfNeeded();

return;