Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 911373002: Make start page logo web contents transparent. (Closed)

Created:
5 years, 10 months ago by calamity
Modified:
5 years, 10 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_white_flash_somehow
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make start page logo web contents transparent. This CL makes the start page's logo WebView transparent. This means we won't need to update the background color of the start page view any more. BUG=442021, 457750 Committed: https://crrev.com/55f1e5199dcc7363466ff424e2a1325c2fc9fa6f Cr-Commit-Position: refs/heads/master@{#315937}

Patch Set 1 #

Patch Set 2 : disable resize background #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/resources/app_list/start_page.css View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/app_list/start_page_service.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
calamity
5 years, 10 months ago (2015-02-11 03:40:32 UTC) #3
calamity
5 years, 10 months ago (2015-02-11 03:40:32 UTC) #4
Matt Giuca
lgtm
5 years, 10 months ago (2015-02-12 02:04:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911373002/20001
5 years, 10 months ago (2015-02-12 05:37:47 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-12 06:23:08 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 06:24:14 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55f1e5199dcc7363466ff424e2a1325c2fc9fa6f
Cr-Commit-Position: refs/heads/master@{#315937}

Powered by Google App Engine
This is Rietveld 408576698