chrome/browser/ui/views/aura/launcher_icon_updater.cc - Issue 9113045: Reworks the workspace code. Here's the new heuristics:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/aura/launcher_icon_updater.cc

Issue 9113045: Reworks the workspace code. Here's the new heuristics: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Incorporated feedback and fixed bugs Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/aura/launcher_icon_updater.cc

diff --git a/chrome/browser/ui/views/aura/launcher_icon_updater.cc b/chrome/browser/ui/views/aura/launcher_icon_updater.cc

index 659e5655de34179e739cb0aa89434169e21eb115..c87024fd77b2034f4379dc515b036df6d07390dc 100644

--- a/chrome/browser/ui/views/aura/launcher_icon_updater.cc

+++ b/chrome/browser/ui/views/aura/launcher_icon_updater.cc

@@ -110,6 +110,7 @@ void LauncherIconUpdater::ActivateByID(ash::LauncherID id) {

NOTREACHED();

return;

}

+ updater->window_->Show();

ash::ActivateWindow(updater->window_);

if (tab) {

updater->tab_model_->ActivateTabAt(