ash/shell/shell_main.cc - Issue 9113045: Reworks the workspace code. Here's the new heuristics:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shell/shell_main.cc

Issue 9113045: Reworks the workspace code. Here's the new heuristics: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Incorporated feedback and fixed bugs Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/shell/shell_main.cc

diff --git a/ash/shell/shell_main.cc b/ash/shell/shell_main.cc

index ea52da8493b2b6fe633df058a3fe7c80cd6171b1..93029909995e58ede9cc7028bd47dde6a0071fea 100644

--- a/ash/shell/shell_main.cc

+++ b/ash/shell/shell_main.cc

@@ -157,7 +157,9 @@ class ShellDelegateImpl : public ash::ShellDelegate {

virtual void LauncherItemClicked(

const ash::LauncherItem& item) OVERRIDE {

- ash::ActivateWindow(watcher_->GetWindowByID(item.id));

+ aura::Window* window = watcher_->GetWindowByID(item.id);

+ window->Show();

+ ash::ActivateWindow(window);

}

virtual int GetBrowserShortcutResourceId() OVERRIDE {