Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Unified Diff: content/browser/renderer_host/resource_dispatcher_host.cc

Issue 9113028: Substitute ResourceHandlers with dummy ResourceHandler while request is transferred (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Darin's comments Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/resource_dispatcher_host.cc
diff --git a/content/browser/renderer_host/resource_dispatcher_host.cc b/content/browser/renderer_host/resource_dispatcher_host.cc
index bc833254e4e05d8c8692a999f7c076191c6df302..e87293e6aa2de5e54c7464b4ae38b71b5b41a34c 100644
--- a/content/browser/renderer_host/resource_dispatcher_host.cc
+++ b/content/browser/renderer_host/resource_dispatcher_host.cc
@@ -43,6 +43,7 @@
#include "content/browser/renderer_host/resource_queue.h"
#include "content/browser/renderer_host/resource_request_details.h"
#include "content/browser/renderer_host/sync_resource_handler.h"
+#include "content/browser/renderer_host/doomed_resource_handler.h"
#include "content/browser/resource_context.h"
#include "content/browser/ssl/ssl_client_auth_handler.h"
#include "content/browser/ssl/ssl_manager.h"
@@ -2246,8 +2247,20 @@ void ResourceDispatcherHost::set_allow_cross_origin_auth_prompt(bool value) {
void ResourceDispatcherHost::MarkAsTransferredNavigation(
const GlobalRequestID& transferred_request_id,
- net::URLRequest* ransferred_request) {
- transferred_navigations_[transferred_request_id] = ransferred_request;
+ net::URLRequest* transferred_request) {
+ transferred_navigations_[transferred_request_id] = transferred_request;
+
+ // If a URLRequest is transferred to a new RenderViewHost, its
+ // ResourceHandlers should not receive any notifications because they may
+ // depend on the state of the old RVH. We set a ResourceHandler that only
+ // allows canceling requests, because on shutdown of the RDH all pending
+ // requests are canceled. The RVH of requests that are being transferred may
+ // be gone by that time. If the request is resumed, the ResoureHandlers are
+ // substituted again.
+ ResourceDispatcherHostRequestInfo* info = InfoForRequest(transferred_request);
+ scoped_refptr<ResourceHandler> transferred_resource_handler(
+ new DoomedResourceHandler(info->resource_handler()));
+ info->set_resource_handler(transferred_resource_handler.get());
}
bool ResourceDispatcherHost::IsTransferredNavigation(

Powered by Google App Engine
This is Rietveld 408576698