core/include/fxcrt/fx_coordinates.h - Issue 911293002: Fix uninitialized value in CFX_ByteString::FormatInteger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fxcrt/fx_coordinates.h

Issue 911293002: Fix uninitialized value in CFX_ByteString::FormatInteger (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/include/fxcrt/fx_coordinates.h

diff --git a/core/include/fxcrt/fx_coordinates.h b/core/include/fxcrt/fx_coordinates.h

index 6ec3b5e1ebb2fd69fb1ecf05f5508f69fe4a1c79..288fa953b77893d6a8b6f3fd87339929dfd08564 100644

--- a/core/include/fxcrt/fx_coordinates.h

+++ b/core/include/fxcrt/fx_coordinates.h

@@ -537,7 +537,7 @@ struct FX_RECT {

int bottom;

- FX_RECT() {}

+ FX_RECT() { left = 0; top = 0; right = 0; bottom = 0; }

Tom Sepez 2015/02/10 23:17:04 nit: prefer initializer list syntax, e.g. FX_RECT

FX_RECT(int left1, int top1, int right1, int bottom1)

{