Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 911223002: Remove dead code related to new super (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove dead code related to new super Support for `new super` has been removed so this code in the full code gen is now unreachable. BUG=None LOG=N R=dslomov@chromium.org Committed: https://crrev.com/a6f0a373dc6869c0ce827b0837c72a71e6a09819 Cr-Commit-Position: refs/heads/master@{#26585}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -48 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
arv (Not doing code reviews)
PTAL
5 years, 10 months ago (2015-02-10 21:44:04 UTC) #1
Dmitry Lomov (no reviews)
lgtm
5 years, 10 months ago (2015-02-11 15:08:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911223002/1
5 years, 10 months ago (2015-02-11 15:10:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-11 15:12:00 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 15:12:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6f0a373dc6869c0ce827b0837c72a71e6a09819
Cr-Commit-Position: refs/heads/master@{#26585}

Powered by Google App Engine
This is Rietveld 408576698