Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 911203002: [Extensions Toolbar Mac] Remove ToolbarActionViewDelegateCocoa (Closed)

Created:
5 years, 10 months ago by Devlin
Modified:
5 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Toolbar Mac] Remove ToolbarActionViewDelegateCocoa This class was used for more at one point, but with various refactors to make more code platform-agnostic, it's been made pretty obsolete. Get rid of it. BUG=457392 Committed: https://crrev.com/ed1f6906d46de89f87e94c4ab34551a578912bd1 Cr-Commit-Position: refs/heads/master@{#316044}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -50 lines) Patch
M chrome/browser/ui/cocoa/extensions/browser_action_button.mm View 4 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm View 3 chunks +21 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/page_action_decoration.h View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/browser/ui/cocoa/toolbar/toolbar_action_view_delegate_cocoa.h View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Devlin
Woohoo, less code! :)
5 years, 10 months ago (2015-02-12 19:11:28 UTC) #3
Avi (use Gerrit)
lgtm!
5 years, 10 months ago (2015-02-12 19:16:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911203002/20001
5 years, 10 months ago (2015-02-12 20:32:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-02-12 20:36:30 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 20:37:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed1f6906d46de89f87e94c4ab34551a578912bd1
Cr-Commit-Position: refs/heads/master@{#316044}

Powered by Google App Engine
This is Rietveld 408576698