chrome/chrome_browser.gypi - Issue 911153002: Moved the TraceUploader to chrome/ and abstracted it for alternative new upload destinations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 911153002: Moved the TraceUploader to chrome/ and abstracted it for alternative new upload destinations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/tracing/crash_service_uploader.h ('K') | « chrome/browser/tracing/crash_service_uploader.cc ('k') | content/browser/tracing/trace_uploader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 013e52b37be91df51b3d53feba725ffdf054875a..3b9fa558c9c096e495c336dbf23e645164b617ac 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1456,7 +1456,7 @@

'chrome_browser_libsecret_sources': [

'browser/password_manager/native_backend_libsecret.cc',

'browser/password_manager/native_backend_libsecret.h',

- ],

+ ],

'chrome_browser_google_sources': [

'browser/google/chrome_google_url_tracker_client.cc',

'browser/google/chrome_google_url_tracker_client.h',

@@ -2777,6 +2777,12 @@

'browser/themes/theme_syncable_service.cc',

'browser/themes/theme_syncable_service.h',

+ 'chrome_browser_tracing_sources': [

Lei Zhang 2015/02/10 20:32:33 You need to include this set of files in the GN bu

+ 'browser/tracing/chrome_tracing_delegate.cc',

+ 'browser/tracing/chrome_tracing_delegate.h',

+ 'browser/tracing/crash_service_uploader.cc',

+ 'browser/tracing/crash_service_uploader.h',

+ ],

'chrome_browser_undo_sources': [

'browser/undo/bookmark_undo_service.cc',

'browser/undo/bookmark_undo_service_factory.cc',

@@ -3019,6 +3025,7 @@

'<@(chrome_browser_signin_sources)',

'<@(chrome_browser_ssl_sources)',

'<@(chrome_browser_sync_sources)',

+ '<@(chrome_browser_tracing_sources)',

Lei Zhang 2015/02/10 20:32:33 This is in a !IOS block. Does Android need this co

oystein (OOO til 10th of July) 2015/02/10 21:08:12 Good point; we hope to eventually reuse parts of t

'<@(chrome_browser_web_resource_sources)',

# These files are generated by GRIT.