content/public/browser/content_browser_client.h - Issue 911153002: Moved the TraceUploader to chrome/ and abstracted it for alternative new upload destinations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/content_browser_client.h

Issue 911153002: Moved the TraceUploader to chrome/ and abstracted it for alternative new upload destinations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix TraceUploader ownership Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/tracing/crash_service_uploader.cc ('K') | « content/content_browser.gypi ('k') | content/public/browser/content_browser_client.cc » ('j') | content/public/browser/trace_uploader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/content_browser_client.h

diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h

index d2ae7a0dd59c07dd4157d4eb2683965cb4bb539e..666cc913bbb6911ae9932a3064af84621de7eefb 100644

--- a/content/public/browser/content_browser_client.h

+++ b/content/public/browser/content_browser_client.h

@@ -104,6 +104,7 @@ class RenderViewHost;

class ResourceContext;

class ServiceRegistry;

class SiteInstance;

+class TracingDelegate;

Charlie Reis 2015/02/12 17:11:32 nit: Alphabetize.

oystein (OOO til 10th of July) 2015/02/13 17:02:45 Done.

class SpeechRecognitionManagerDelegate;

class WebContents;

class WebContentsViewDelegate;

@@ -570,6 +571,10 @@ class CONTENT_EXPORT ContentBrowserClient {

// It's valid to return nullptr.

virtual DevToolsManagerDelegate* GetDevToolsManagerDelegate();

+ // Creates a new TracingDelegate. The caller owns the returned value.

+ // It's valid to return nullptr.

+ virtual TracingDelegate* GetTracingDelegate();

// Returns true if plugin referred to by the url can use

// pp::FileIO::RequestOSFileHandle.

virtual bool IsPluginAllowedToCallRequestOSFileHandle(