chrome/browser/tracing/chrome_tracing_delegate.h - Issue 911153002: Moved the TraceUploader to chrome/ and abstracted it for alternative new upload destinations.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/tracing/chrome_tracing_delegate.h

Issue 911153002: Moved the TraceUploader to chrome/ and abstracted it for alternative new upload destinations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/tracing/chrome_tracing_delegate.cc » ('j') | chrome/browser/tracing/crash_service_uploader.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_TRACING_CHROME_TRACING_DELEGATE_H_

	6 #define CHROME_BROWSER_TRACING_CHROME_TRACING_DELEGATE_H_

	7

	8 #include "content/public/browser/tracing_delegate.h"

	9

	10 class ChromeTracingDelegate : public content::TracingDelegate {

	11 public:

	12 content::TraceUploader* GetTraceUploader(
	Lei Zhang 2015/02/10 22:28:16 Is it possible to change the interface to return a Is it possible to change the interface to return a scoped_ptr so it's obvious that the callers takes ownership of the TraceUploader? oystein (OOO til 10th of July) 2015/02/10 23:40:15 Done. Looks like the original code here was leakin Show quoted text On 2015/02/10 22:28:16, Lei Zhang wrote: > Is it possible to change the interface to return a scoped_ptr so it's obvious > that the callers takes ownership of the TraceUploader? Done. Looks like the original code here was leaking this object each time.
	13 net::URLRequestContextGetter* request_context) override;

	14 };

	15

	16 #endif // CHROME_BROWSER_TRACING_CHROME_TRACING_DELEGATE_H_

OLD	NEW