Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: Source/WebCore/ChangeLog

Issue 9111020: Merge 101903 - REGRESSION (r91125): Polyline tool in google docs is broken (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/963/
Patch Set: Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: Source/WebCore/ChangeLog
===================================================================
--- Source/WebCore/ChangeLog (revision 104173)
+++ Source/WebCore/ChangeLog (working copy)
@@ -1,5259 +1,3 @@
-2011-12-10 Noel Gordon <noel.gordon@gmail.com>
-
- WebPImageDecoder progressive decodes fail to decode valid images
- https://bugs.webkit.org/show_bug.cgi?id=74062
-
- Reviewed by Adam Barth.
-
- The WEBP header is followed by a so-called P0 header, then some data to
- decode. If a partial P0 header is received during progressive decodes,
- WebPIDecGetRGB() returns false; that makes the decoder enter the failed
- state, no image appears on the page.
-
- James Zern (webp) recommended the following via e-mail:
-
- WebPIUpdate() validates input data, and will return an error status for
- malformed data (bit-stream error, invalid data). Otherwise, it returns
- OK or SUSPENDED. OK means that decoding is done/complete/no-error, and
- SUSPENDED means more input data is needed to complete decoding. A NULL
- return from WebPIDecGetRGB() is valid at this time due to a partial P0,
- and should not be interpreted as a decoding failure.
-
- No new tests. Not something DumpRenderTree can easily test.
-
- * platform/image-decoders/webp/WEBPImageDecoder.cpp:
- (WebCore::WEBPImageDecoder::decode): A NULL WebPIDecGetRGB() return is
- acceptable here. Return false instead of failing the decoder.
-
-2011-12-09 Benjamin Poulain <bpoulain@apple.com>
-
- Add the FileSystem functions of iOS
- https://bugs.webkit.org/show_bug.cgi?id=74164
-
- Reviewed by David Kilzer.
-
- Two functions are needed on iOS for temporary files and directories.
-
- * WebCore.exp.in:
- * WebCore.xcodeproj/project.pbxproj:
- * platform/ios/FileSystemIOS.h: Added.
- * platform/ios/FileSystemIOS.mm: Added.
- (WebCore::createTemporaryDirectory):
- (WebCore::createTemporaryFile):
-
-2011-12-09 Jacky Jiang <zhajiang@rim.com>
-
- Remove ResourceHandle::bufferedData() from ResourceHandleBlackBerry.cpp
- https://bugs.webkit.org/show_bug.cgi?id=74197
-
- The bufferedData() was removed in r95120.
-
- Reviewed by Rob Buis.
-
- Trivial fix, so no new tests.
-
- * platform/network/blackberry/ResourceHandleBlackBerry.cpp:
-
-2011-12-09 Eric Penner <epenner@google.com>
-
- [chromium] Prevent ASSERT in legitimate out-of-memory case.
- https://bugs.webkit.org/show_bug.cgi?id=74215
-
- Reviewed by James Robinson.
-
- * platform/graphics/chromium/TiledLayerChromium.cpp:
- (WebCore::TiledLayerChromium::updateCompositorResources):
-
-2011-12-09 Arko Saha <arko@motorola.com>
-
- NameNodeListCache should be invalidated when name attribute changes/modified.
- https://bugs.webkit.org/show_bug.cgi?id=70810
-
- Reviewed by Ryosuke Niwa.
-
- Test: fast/dom/getelementsbyname-invalidation-cache.html
-
- * html/HTMLAnchorElement.cpp:
- (WebCore::HTMLAnchorElement::parseMappedAttribute):
- * html/HTMLAppletElement.cpp:
- (WebCore::HTMLAppletElement::parseMappedAttribute):
- * html/HTMLElement.cpp:
- (WebCore::HTMLElement::parseMappedAttribute):
- * html/HTMLEmbedElement.cpp:
- (WebCore::HTMLEmbedElement::parseMappedAttribute):
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::parseMappedAttribute):
- * html/HTMLFrameElementBase.cpp:
- (WebCore::HTMLFrameElementBase::parseMappedAttribute):
- * html/HTMLIFrameElement.cpp:
- (WebCore::HTMLIFrameElement::parseMappedAttribute):
- * html/HTMLImageElement.cpp:
- (WebCore::HTMLImageElement::parseMappedAttribute):
- * html/HTMLMapElement.cpp:
- (WebCore::HTMLMapElement::parseMappedAttribute):
- * html/HTMLMetaElement.cpp:
- (WebCore::HTMLMetaElement::parseMappedAttribute):
- * html/HTMLObjectElement.cpp:
- (WebCore::HTMLObjectElement::parseMappedAttribute):
- * html/HTMLParamElement.cpp:
- (WebCore::HTMLParamElement::parseMappedAttribute):
-
-2011-12-09 Anders Carlsson <andersca@apple.com>
-
- Fix Lion release build.
-
- * platform/mac/ScrollAnimatorMac.mm:
- (-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
-
-2011-12-09 Mark Pilgrim <pilgrim@chromium.org>
-
- [FileSystem API] Entry.remove successCallback is required
- https://bugs.webkit.org/show_bug.cgi?id=69639
-
- Reviewed by Adam Barth.
-
- Test: fast/filesystem/simple-required-arguments-remove.html
-
- * fileapi/Entry.idl: remove [Optional] flag from Entry.remove.successCallback parameter
-
-2011-12-09 Tim Horton <timothy_horton@apple.com>
-
- background-image transitions trigger between equivalent images
- https://bugs.webkit.org/show_bug.cgi?id=74229
- <rdar://problem/10558627>
-
- Reviewed by Darin Adler.
- Patch by Simon Fraser.
-
- For animation property wrappers around StyleImage properties,
- test the equivalence of the image itself, instead of equality of
- the StyleImage pointer.
-
- Test: transitions/equivalent-background-image-no-transition.html
-
- * page/animation/AnimationBase.cpp:
- (WebCore::StyleImagePropertyWrapper::StyleImagePropertyWrapper):
- (WebCore::StyleImagePropertyWrapper::equals):
- (WebCore::FillLayerStyleImagePropertyWrapper::FillLayerStyleImagePropertyWrapper):
- (WebCore::FillLayerStyleImagePropertyWrapper::equals):
- (WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
- (WebCore::AnimationBase::ensurePropertyMap):
-
-2011-12-09 Mary Wu <mary.wu@torchmobile.com.cn>
-
- Small style fix on DragDataBlackBerry.cpp
- https://bugs.webkit.org/show_bug.cgi?id=74171
-
- Reviewed by Rob Buis.
-
- Style fix, no function impact, no new tests.
-
- * platform/blackberry/DragDataBlackBerry.cpp:
- (WebCore::DragData::containsURL):
- (WebCore::DragData::asFilenames):
- (WebCore::DragData::asURL):
- (WebCore::DragData::asFragment):
-
-2011-12-09 Tony Chang <tony@chromium.org>
-
- add css parsing for flex-flow: wrap and wrap-reverse
- https://bugs.webkit.org/show_bug.cgi?id=74008
-
- Reviewed by Ojan Vafai.
-
- Also save 2 bits in StyleFlexibleBoxData by changing the size of m_flexFlow (there are only 4 enum values).
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Print the wrap value if it exists.
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseValue): Parse a second token and put the values into a CSSValueList.
- * css/CSSPrimitiveValueMappings.h:
- (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- (WebCore::CSSPrimitiveValue::operator EFlexWrap):
- * css/CSSStyleApplyProperty.cpp:
- (WebCore::ApplyPropertyFlexFlow::applyInheritValue): Does not inherit.
- (WebCore::ApplyPropertyFlexFlow::applyInitialValue):
- (WebCore::ApplyPropertyFlexFlow::applyValue): Special handler for setting two render style values from one
- CSS property.
- (WebCore::ApplyPropertyFlexFlow::createHandler):
- (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- * css/CSSValueKeywords.in:
- * rendering/style/RenderStyle.h:
- (WebCore::InheritedFlags::flexWrap):
- (WebCore::InheritedFlags::setFlexWrap):
- (WebCore::InheritedFlags::initialFlexWrap):
- * rendering/style/RenderStyleConstants.h: EFlexWrap to hold flex wrap values.
- * rendering/style/StyleFlexibleBoxData.cpp:
- (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
- (WebCore::StyleFlexibleBoxData::operator==):
- * rendering/style/StyleFlexibleBoxData.h: 2 bits is enough to hold the 4 flexFlow values.
-
-2011-12-09 KwangHyuk Kim <hyuki.kim@samsung.com>
-
- [EFL] Add RefPtrEfl specialization for evas_object.
- https://bugs.webkit.org/show_bug.cgi?id=73790
-
- Reviewed by Ryosuke Niwa.
-
- As evas_object is also based on reference count, RefPtr is applied for evas_object.
-
- * PlatformEfl.cmake:
- * platform/efl/RefPtrEfl.cpp: Added.
- (WTF::refIfNotNull):
- (WTF::derefIfNotNull):
- * platform/efl/RefPtrEfl.h: Added.
-
-2011-12-09 Tony Chang <tony@chromium.org>
-
- REGRESSION(102234): 2-3% layout regression
- https://bugs.webkit.org/show_bug.cgi?id=74141
-
- Reviewed by David Hyatt.
-
- Don't allocate a RuleSet when there are no regions.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::initForRegionStyling):
-
-2011-12-09 Anders Carlsson <andersca@apple.com>
-
- Fix assertion failure in ScrollAnimatorMac
- https://bugs.webkit.org/show_bug.cgi?id=74222
-
- Reviewed by Andreas Kling.
-
- * platform/mac/ScrollAnimatorMac.mm:
- (-[WebScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
- This can be called with a nil scrollerImp, just return NSZeroPoint when that happens.
-
-2011-12-09 Anders Carlsson <andersca@apple.com>
-
- Move the "is currently drawing into layer" flag out into ScrollbarThemeMac
- https://bugs.webkit.org/show_bug.cgi?id=74217
-
- Reviewed by Beth Dakin.
-
- There's no need to store this flag inside ScrollAnimatorMac, just make it a global and put it in ScrollbarThemeMac instead.
-
- * platform/mac/ScrollAnimatorMac.h:
- * platform/mac/ScrollAnimatorMac.mm:
- (-[WebScrollbarPainterDelegate layer]):
- (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
- * platform/mac/ScrollbarThemeMac.h:
- * platform/mac/ScrollbarThemeMac.mm:
- (WebCore::ScrollbarThemeMac::isCurrentlyDrawingIntoLayer):
- (WebCore::ScrollbarThemeMac::paint):
-
-2011-12-09 Anders Carlsson <andersca@apple.com>
-
- Minor cleanup in ScrollAnimatorMac.mm
- https://bugs.webkit.org/show_bug.cgi?id=74211
-
- Reviewed by Andreas Kling.
-
- * platform/mac/ScrollAnimatorMac.mm:
- (-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
- No need to get the scrollbar from the scroll animator anymore.
-
- (-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
- (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
- Try to get data from the scrollbar and/or the scrollable area instead of the scrollbar painter.
-
-2011-12-09 David Levin <levin@chromium.org>
-
- Regression(r53595): Sync xhr requests in workers aren't terminated on worker close.
- https://bugs.webkit.org/show_bug.cgi?id=71695
-
- Reviewed by Zoltan Herczeg.
-
- Overview: Message loops rely on the message queue being killed in order
- to exit. r53595 stopped this from happening because killing a message loop
- would also stop it from doing database clean up tasks. The database clean up
- tasks needed to be tasks due to ordering issues. (They wanted to run after
- certain order tasks were run.) This was solved by once again terminating
- the message queue but then still runnning clean-up tasks from the killed
- message queue.
-
- * workers/WorkerRunLoop.cpp:
- (WebCore::WorkerRunLoop::run): Added the call to run clean-up tasks.
- (WebCore::WorkerRunLoop::runInMode):
- (WebCore::WorkerRunLoop::runCleanupTasks): Loop to simply clear out all clean up tasks.
- (WebCore::WorkerRunLoop::Task::performTask): Stop non-clean up tasks
- from running after the loop has been terminated.
- * workers/WorkerRunLoop.h:
- (WebCore::WorkerRunLoop::terminated): Just made it const.
- * workers/WorkerThread.cpp:
- (WebCore::WorkerThreadShutdownFinishTask::performTask): Removed
- the terminate clause since it was put back in stop.
- (WebCore::WorkerThread::stop): Terminate the run loop so
- that all loops will exit and clean up tasks will run. Also removed a comment
- about nested workers because nested workers are no longer imminent and the
- issue mentioned is one of many that should logically be investigated -- behavior correctness
- in the face of different orderings of shutdown between the document and each worker --
- when implementing them.
-
-2011-12-09 Tony Chang <tony@chromium.org>
-
- Unreviewed, rolling out r102416.
- http://trac.webkit.org/changeset/102416
- https://bugs.webkit.org/show_bug.cgi?id=73394
-
- Chromium Win clobber builds are failing.
-
- * WebCore.gyp/WebCore.gyp:
- * WebCore.gyp/scripts/action_derivedsourcesallinone.py:
- (main):
- * WebCore.gypi:
- * bindings/scripts/generate-bindings.pl:
- * page/DOMWindow.idl:
- * webaudio/DOMWindowWebAudio.idl: Removed.
-
-2011-12-09 Eric Carlson <eric.carlson@apple.com>
-
- JSC wrappers for TextTrack and TextTrackCue should not be collected during event dispatch or when owner is reachable
- https://bugs.webkit.org/show_bug.cgi?id=72179
-
- Reviewed by Geoff Garen.
-
- Tests: media/track/text-track-cue-is-reachable.html
- media/track/text-track-is-reachable.html
-
- * GNUmakefile.list.am: Add JSTextTrackCueCustom.cpp and JSTextTrackCustom.cpp.
- * Target.pri: Ditto.
- * WebCore.gypi: Ditto.
- * WebCore.xcodeproj/project.pbxproj: Ditto
- * bindings/js/JSBindingsAllInOne.cpp: Ditto.
-
- * bindings/js/JSTextTrackCueCustom.cpp: Added.
- (WebCore::JSTextTrackCueOwner::isReachableFromOpaqueRoots): New.
- (WebCore::JSTextTrackCueOwner::visitChildren): New.
-
- * bindings/js/JSTextTrackCustom.cpp: Added.
- (WebCore::JSTextTrackOwner::isReachableFromOpaqueRoots): New.
- (WebCore::JSTextTrack::visitChildren): New, mark all cues.
- * bindings/js/JSTextTrackCustom.h: Added.
- (WebCore::root): New.
-
- * bindings/js/JSTextTrackListCustom.cpp:
- (WebCore::JSTextTrackList::visitChildren): New, mark all tracks.
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::trackWillBeRemoved): TextTracks::remove now takes a TextTrack*.
-
- * html/LoadableTextTrack.h:
- (WebCore::LoadableTextTrack::trackElement): New, return the <track>.
-
- * html/TextTrack.cpp:
- (WebCore::TextTrack::TextTrack): Initialize m_mediaElement.
- * html/TextTrack.h:
- (WebCore::TextTrack::setMediaElement): New.
- (WebCore::TextTrack::mediaElement): Ditto.
-
- * html/TextTrack.idl: Add CustomIsReachable and CustomMarkFunction.
-
- * html/TextTrackCue.idl: Add CustomIsReachable.
-
- * html/track/TextTrackList.cpp:
- (TextTrackList::append): Set track's media element.
- (TextTrackList::remove): Clear track's media element. Take a raw ptr, not a PassRefPtr.
- * html/track/TextTrackList.h:
- * html/track/TextTrackList.idl: Add CustomMarkFunction
-
-2011-12-09 Chris Fleizach <cfleizach@apple.com>
-
- WebKit should ignore images with @alt matching only whitespace
- https://bugs.webkit.org/show_bug.cgi?id=74189
-
- Reviewed by Darin Adler.
-
- Test: accessibility/img-alt-tag-only-whitespace.html
-
- * accessibility/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
-
-2011-12-09 Anders Carlsson <andersca@apple.com>
-
- Remove NSAnimationContext calls
- https://bugs.webkit.org/show_bug.cgi?id=74207
-
- Reviewed by Sam Weinig.
-
- NSAnimationContext is not used for NSAnimation subclasses, so the calls to beginGrouping/endGrouping and setDuration:
- are essentially no-ops. Remove them.
-
- * platform/mac/ScrollAnimatorMac.mm:
- (-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
- (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
-
-2011-12-09 Anders Carlsson <andersca@apple.com>
-
- Rename scrollAnimatorDestroyed to invalidate
- https://bugs.webkit.org/show_bug.cgi?id=74206
-
- Reviewed by Sam Weinig.
-
- Since these methods can be called when both scrollbars are destroyed and the scroll animator itself is
- destroyed, rename it to something more neutral.
-
- * platform/mac/ScrollAnimatorMac.mm:
- (-[WebScrollAnimationHelperDelegate invalidate]):
- (-[WebScrollbarPartAnimation invalidate]):
- (-[WebScrollbarPainterDelegate invalidate]):
- (WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
- (WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
- (WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
-
-2011-12-09 Anders Carlsson <andersca@apple.com>
-
- WebScrollbarPainterControllerDelegate should know about the ScrollableArea, not the ScrollAnimatorMac
- https://bugs.webkit.org/show_bug.cgi?id=74204
-
- Reviewed by Sam Weinig.
-
- It makes more logical sense to associate the WebScrollbarPainterControllerDelegate object with its ScrollableArea, since
- painting has nothing to do with animation.
-
- * platform/mac/ScrollAnimatorMac.mm:
- (-[WebScrollbarPainterControllerDelegate initWithScrollableArea:]):
- (-[WebScrollbarPainterControllerDelegate invalidate]):
- (-[WebScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
- (-[WebScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
- (-[WebScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
- (-[WebScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
- (-[WebScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
- (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
- (WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
-
-2011-12-09 Jarred Nicholls <jarred@sencha.com>
-
- [JSC] Allow cached attributes in bindings that declare a custom mark function
- https://bugs.webkit.org/show_bug.cgi?id=74187
-
- Reviewed by Oliver Hunt.
-
- No new tests, current binding tests are sufficient.
-
- * bindings/scripts/CodeGeneratorJS.pm:
- (GenerateImplementation):
-
-2011-12-09 Anders Carlsson <andersca@apple.com>
-
- Remove duplicate animation ivars
- https://bugs.webkit.org/show_bug.cgi?id=74194
-
- Reviewed by Sam Weinig.
-
- Since we now have one WebScrollbarPainterDelegate for each scrollbar, we no longer need separate
- vertical/horizontal animation objects, so get rid of them.
-
- * platform/mac/ScrollAnimatorMac.mm:
- (-[WebScrollbarPainterDelegate cancelAnimations]):
- (-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
- (-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
- (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
- (-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):
-
-2011-12-09 Anders Carlsson <andersca@apple.com>
-
- WebScrollbarPartAnimation should only know about the scrollbar it's animating
- https://bugs.webkit.org/show_bug.cgi?id=74192
-
- Reviewed by Sam Weinig.
-
- * platform/mac/ScrollAnimatorMac.mm:
- (-[WebScrollbarPartAnimation initWithScrollbar:featureToAnimate:animateFrom:animateTo:duration:]):
- Change the designated initializer to just take the scrollbar. Also, make the animation non-blocking here
- so we don't have to do it in all the call sites.
-
- (-[WebScrollbarPartAnimation startAnimation]):
- Update the scrollbar painter.
-
- (-[WebScrollbarPartAnimation setCurrentProgress:]):
- Just invalidate the scrollbar we're animating.
-
- (-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
- (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
- Update call sites to use the new designated initializer.
-
-2011-12-08 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
-
- Inspector: Don't translate the context when rendering the highlights on a tiled layer.
- https://bugs.webkit.org/show_bug.cgi?id=74085
-
- Reviewed by Kenneth Rohde Christiansen.
-
- When the frame view is using fixed layouting, the page overlay is the size of the whole
- page and the context shouldn't be translated. The visible rect is still used in that
- case to display element titles within the visible rect.
-
- Also:
- - Rename overlayRect to visibleRect to reduce confusion in this case.
- - Remove the superfluous boundingBox check.
-
- * inspector/DOMNodeHighlighter.cpp:
-
-2011-12-09 Vsevolod Vlasov <vsevik@chromium.org>
-
- Unreviewed inspector utilities syntax fix.
-
- * inspector/front-end/utilities.js:
- ():
-
-2011-12-09 Joone Hur <joone.hur@collabora.co.uk>, Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
-
- [GTK] Initial implementation of Accelerated Compositing using Clutter
- https://bugs.webkit.org/show_bug.cgi?id=73319
-
- Reviewed by Gustavo Noronha Silva.
-
- No new tests added as this feature will be able to reuse the existing
- CSS3 transforms layout tests.
-
- * GNUmakefile.am: Include WebCore/platform/graphics/clutter path.
- * GNUmakefile.list.am: Add GraphicsLayerClutter.
- * platform/clutter/GRefPtrClutter.cpp: Added.
- (WTF::adoptGRef):
- (WTF::ClutterActor):
- * platform/clutter/GRefPtrClutter.h: Added.
- * platform/graphics/GraphicsLayer.h: Define PlatformLayer type, which represents ClutterActor.
- * platform/graphics/clutter/GraphicsLayerClutter.cpp: Boilerplate implementation.
- (WebCore::GraphicsLayerClutter::GraphicsLayerClutter):
- (WebCore::GraphicsLayerClutter::platformLayer):
- * platform/graphics/clutter/GraphicsLayerClutter.h: Boilerplate implementation.
-
-2011-12-08 Vsevolod Vlasov <vsevik@chromium.org>
-
- Web Inspector: Introduce a Map class allowing to store values indexed by arbitrary objects.
- https://bugs.webkit.org/show_bug.cgi?id=74084
-
- Reviewed by Pavel Feldman.
-
- Test: inspector/map.html
-
- * inspector/front-end/treeoutline.js:
- (TreeOutline):
- ():
- (TreeElement.prototype.collapse):
- (TreeElement.prototype.expand):
- * inspector/front-end/utilities.js:
- ():
-
-2011-12-09 Peter Rybin <peter.rybin@gmail.com>
-
- Web Inspector: [protocol] generate C++ classes for protocol JSON named types
- https://bugs.webkit.org/show_bug.cgi?id=72835
-
- Reviewed by Yury Semikhatsky.
-
- Extends python generator functionality.
- Makes constructor in InspectorObject public.
-
- * inspector/CodeGeneratorInspector.py:
- * inspector/InspectorValues.h:
-
-2011-12-08 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
-
- [Qt] [WK2] Webkit should release TextureMapper GL objects if page paint node is deallocated.
- https://bugs.webkit.org/show_bug.cgi?id=73591
-
- Reviewed by Noam Rosenthal.
-
- Implementation of helper function to remove all GL allocated tiles
- when QQuickWebView gets removed from canvas.
-
- Tested by new API test in WK2 (tst_QQuickWebView::removeFromCanvas).
-
- * platform/graphics/texmap/TextureMapperNode.cpp:
- (WebCore::TextureMapperNode::purgeNodeTexturesRecursive):
- * platform/graphics/texmap/TextureMapperNode.h:
-
-2011-12-08 Leo Yang <leo.yang@torchmobile.com.cn>
-
- Upstream platform/network/blackberry/DeferredData.{h, cpp}, NetworkJob.{h, cpp} and NetworkManager.{h, cpp}
- https://bugs.webkit.org/show_bug.cgi?id=73791
-
- Reviewed by Rob Buis.
-
- Other main contributors:
- Joe Mason <jmason@rim.com>
- Lianghui Chen <liachen@rim.com>
- Charles Wei <charles.wei@torchmobile.com.cn>
-
- Initial upstream, can't be built yet, no new tests.
-
- * platform/network/blackberry/DeferredData.cpp: Added.
- * platform/network/blackberry/DeferredData.h: Added.
- * platform/network/blackberry/NetworkJob.cpp: Added.
- * platform/network/blackberry/NetworkJob.h: Added.
- * platform/network/blackberry/NetworkManager.cpp: Added.
- * platform/network/blackberry/NetworkManager.h: Added.
-
-2011-12-08 Ryosuke Niwa <rniwa@webkit.org>
-
- It's semantically incorrect to call notifyNodeListsAttributeChanged in dispatchSubtreeModifiedEvent
- https://bugs.webkit.org/show_bug.cgi?id=74028
-
- Reviewed by Darin Adler.
-
- Remove a call to notifyNodeListsAttributeChanged in dispatchSubtreeModified and add explicit calls
- to notifyNodeListsAttributeChanged at appropriate places.
-
- Also merge notifyNodeListsChildrenChanged with notifyLocalNodeListsChildrenChanged, and
- notifyNodeListsAttributeChanged with notifyLocalNodeListsAttributeChanged, and rename them to
- invalidateNodeListsCacheAfterAttributeChanges and invalidateNodeListsCacheAfterNodeChanges respectively.
-
- * dom/Attr.cpp:
- (WebCore::Attr::childrenChanged):
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::childrenChanged):
- * dom/Document.cpp:
- (WebCore::Document::updateRangesAfterNodeChanges):
- * dom/Document.h:
- * dom/NamedNodeMap.cpp:
- (WebCore::NamedNodeMap::addAttribute):
- (WebCore::NamedNodeMap::removeAttribute):
- * dom/Node.cpp:
- (WebCore::removeNodeListCacheIfPossible):
- (WebCore::Node::unregisterDynamicNodeList):
- (WebCore::Node::invalidateNodeListsCacheAfterAttributeChanges):
- (WebCore::Node::invalidateNodeListsCacheAfterNodeChanges):
- (WebCore::Node::dispatchSubtreeModifiedEvent):
- * dom/Node.h:
- * dom/NodeRareData.h:
- * dom/StyledElement.cpp:
- (WebCore::StyledElement::classAttributeChanged):
-
-2011-12-08 Kenichi Ishibashi <bashi@chromium.org>
-
- Unreviewed, rolling out r102418.
- http://trac.webkit.org/changeset/102418
- https://bugs.webkit.org/show_bug.cgi?id=71870
-
- Caused Chromium build failure.
-
- * CMakeLists.txt:
- * DerivedSources.make:
- * DerivedSources.pri:
- * GNUmakefile.list.am:
- * Target.pri:
- * WebCore.gypi:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSWebGLRenderingContextCustom.cpp:
- (WebCore::toJS):
- * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
- (WebCore::toV8Object):
- * html/canvas/WebGLExtension.h:
- * html/canvas/WebGLRenderingContext.cpp:
- (WebCore::WebGLRenderingContext::getExtension):
- (WebCore::WebGLRenderingContext::getSupportedExtensions):
- (WebCore::WebGLRenderingContext::maybeRestoreContext):
- * html/canvas/WebGLRenderingContext.h:
- * html/canvas/WebKitLoseContext.cpp: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.cpp.
- (WebCore::WebKitLoseContext::WebKitLoseContext):
- (WebCore::WebKitLoseContext::~WebKitLoseContext):
- (WebCore::WebKitLoseContext::getName):
- (WebCore::WebKitLoseContext::create):
- (WebCore::WebKitLoseContext::loseContext):
- (WebCore::WebKitLoseContext::restoreContext):
- * html/canvas/WebKitLoseContext.h: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.h.
- * html/canvas/WebKitLoseContext.idl: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.idl.
-
-2011-12-08 Fady Samuel <fsamuel@chromium.org>
-
- [Chromium] Enable viewport metatag
- https://bugs.webkit.org/show_bug.cgi?id=73495
-
- Reviewed by Darin Fisher.
-
- Recompute viewpot parameters on frame rect resize.
-
- * page/FrameView.cpp:
- (WebCore::FrameView::setFrameRect):
-
-2011-12-08 Kent Tamura <tkent@chromium.org>
-
- Build fix for r102419.
- https://bugs.webkit.org/show_bug.cgi?id=73916
-
- * platform/PopupMenuClient.h:
- (WebCore::PopupMenuClient::listBoxSelectItem):
- Remove unused argument names.
-
-2011-12-08 Kentaro Hara <haraken@chromium.org>
-
- Unreviewed. Rebaselined run-bindings-tests results.
-
- * bindings/scripts/test/JS/JSFloat64Array.cpp:
- * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- * bindings/scripts/test/JS/JSTestInterface.cpp:
- * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
- * bindings/scripts/test/JS/JSTestObj.cpp:
- * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
-
-2011-12-08 Mary Wu <mary.wu@torchmobile.com.cn>
-
- Upstream BlackBerry porting of MIMETypeRegistry/KeyboardEvent
- https://bugs.webkit.org/show_bug.cgi?id=73534
-
- Reviewed by Rob Buis.
-
- Other main contributors:
- Mike Fenton <mifenton@rim.com>
- Joe Mason <jmason@rim.com>
- Max Feil <mfeil@qnx.com>
- Lukas Sydorowski <lsydorowski@rim.com>
- Crystal Zhang <haizhang@rim.com>
-
- Initial upstream, no new tests.
-
- * platform/blackberry/MIMETypeRegistryBlackBerry.cpp: Added.
- (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
- (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
- * platform/blackberry/PlatformKeyboardEventBlackBerry.cpp: Added.
- (WebCore::keyIdentifierForBlackBerryCharacter):
- (WebCore::windowsKeyCodeForBlackBerryCharacter):
- (WebCore::adjustCharacterFromOS):
- (WebCore::toWebCorePlatformKeyboardEventType):
- (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
- (WebCore::PlatformKeyboardEvent::currentCapsLockState):
- (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
- (WebCore::PlatformKeyboardEvent::getCurrentModifierState):
-
-2011-12-08 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r101619.
- http://trac.webkit.org/changeset/101619
- https://bugs.webkit.org/show_bug.cgi?id=74158
-
- this patch produces bad behaviour on mac (Requested by
- jeremya_ on #webkit).
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleMouseMoveEvent):
- (WebCore::EventHandler::dragSourceEndedAt):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateHoverActiveState):
-
-2011-12-08 Adam Klein <adamk@chromium.org>
-
- [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
- https://bugs.webkit.org/show_bug.cgi?id=73492
-
- Reviewed by Adam Barth.
-
- Test: fast/mutation/inline-event-listener.html
-
- * bindings/v8/V8LazyEventListener.cpp:
- (WebCore::V8LazyEventListener::prepareListenerObject): Call v8::Script::Run directly instead of going through V8Proxy.
-
-2011-12-08 Hayato Ito <hayato@chromium.org>
-
- Suppress rendering of light children when ShadowRoot is dynamically created.
- https://bugs.webkit.org/show_bug.cgi?id=72441
-
- Reviewed by Ryosuke Niwa.
-
- Tests: fast/dom/shadow/dynamically-created-shadow-root-expected.html
- fast/dom/shadow/dynamically-created-shadow-root.html
-
- * dom/Element.cpp:
- (WebCore::Element::setShadowRoot):
-
-2011-12-08 Pierre Rossi <pierre.rossi@gmail.com>
-
- Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
- https://bugs.webkit.org/show_bug.cgi?id=73916
-
- This was needed for Qt since the mobile theme, which can be picked
- up at runtime, delegates the rendering of list boxes.
-
- Reviewed by Kent Tamura.
-
- No new tests, there's no functional change.
-
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::usesMenuList):
- * html/HTMLSelectElement.h:
- * platform/PopupMenuClient.h:
- (WebCore::PopupMenuClient::listBoxSelectItem):
- (WebCore::PopupMenuClient::multiple):
- * platform/qt/RenderThemeQtMobile.h:
- (WebCore::RenderThemeQtMobile::delegatesMenuListRendering):
- * rendering/RenderMenuList.cpp:
- (WebCore::RenderMenuList::multiple):
- * rendering/RenderMenuList.h:
- * rendering/RenderTheme.h:
- (WebCore::RenderTheme::delegatesMenuListRendering):
-
-2011-12-08 Kenneth Russell <kbr@google.com>
-
- Rename WEBKIT_lose_context to WEBKIT_WEBGL_lose_context
- https://bugs.webkit.org/show_bug.cgi?id=71870
-
- Reviewed by James Robinson.
-
- Rename largely done with do-webcore-rename with a couple of
- necessary manual fixups. Ran WebGL layout tests.
-
- * CMakeLists.txt:
- * DerivedSources.make:
- * DerivedSources.pri:
- * GNUmakefile.list.am:
- * Target.pri:
- * WebCore.gypi:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSWebGLRenderingContextCustom.cpp:
- (WebCore::toJS):
- * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
- (WebCore::toV8Object):
- * html/canvas/WebGLExtension.h:
- * html/canvas/WebGLLoseContext.cpp: Copied from Source/WebCore/html/canvas/WebKitLoseContext.cpp.
- (WebCore::WebGLLoseContext::WebGLLoseContext):
- (WebCore::WebGLLoseContext::~WebGLLoseContext):
- (WebCore::WebGLLoseContext::getName):
- (WebCore::WebGLLoseContext::create):
- (WebCore::WebGLLoseContext::loseContext):
- (WebCore::WebGLLoseContext::restoreContext):
- * html/canvas/WebGLLoseContext.h: Copied from Source/WebCore/html/canvas/WebKitLoseContext.h.
- * html/canvas/WebGLLoseContext.idl: Copied from Source/WebCore/html/canvas/WebKitLoseContext.idl.
- * html/canvas/WebGLRenderingContext.cpp:
- (WebCore::WebGLRenderingContext::getExtension):
- (WebCore::WebGLRenderingContext::getSupportedExtensions):
- (WebCore::WebGLRenderingContext::maybeRestoreContext):
- * html/canvas/WebGLRenderingContext.h:
- * html/canvas/WebKitLoseContext.cpp: Removed.
- * html/canvas/WebKitLoseContext.h: Removed.
- * html/canvas/WebKitLoseContext.idl: Removed.
-
-2011-12-08 Kentaro Hara <haraken@chromium.org>
-
- Use the [Supplemental] IDL for webaudio attributes in Chromium
- https://bugs.webkit.org/show_bug.cgi?id=73394
-
- Reviewed by Adam Barth.
-
- - Overview: Using the [Supplemental] IDL, this patch moves the attribute
- declarations of webaudio from DOMWindow.idl into a new IDL file
- webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained
- feature (aka a module).
-
- - This patch changes the build flow of WebCore.gyp as follows:
-
- Previous build flow:
- foreach $idl (all IDL files) {
- generate-bindings.pl depends on $idl;
- generate-bindings.pl reads $idl;
- generate-bindings.pl generates .h and .cpp files for $idl;
- }
-
- New build flow (See the discussions in bug 72138 for more details):
- resolve-supplemental.pl depends on all IDL files;
- resolve-supplemental.pl reads all IDL files;
- resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
- resolve-supplemental.pl outputs supplemental_dependency.tmp;
- foreach $idl (all IDL files) {
- generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
- generate-bindings.pl reads $idl;
- generate-bindings.pl reads supplemental_dependency.tmp;
- generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl;
- }
-
- - This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL
- will be removed after build scripts for all platforms support the [Supplemental] IDL.
- The motivation for the [Supplemented] IDL is as follows:
-
- In order to support the [Supplemental] IDL, we need to
- (1) run resolve-supplemental.pl and generate supplemental_dependency.tmp
- (2) and run generate-bindings.pl with the supplemental_dependency.tmp.
-
- This build flow requires a change on the following build scripts,
- but changing all the build scripts all at once without any regression is too difficult:
-
- - DerivedSources.make
- - DerivedSources.pri
- - GNUmakefile.am
- - PlatformBlackBerry.cmake
- - UseJSC.cmake
- - UseV8.cmake
- - WebCore.vcproj/MigrateScripts
- - WebCore.vcproj/WebCore.vcproj
- - bindings/gobject/GNUmakefile.am
- - WebCore.gyp/WebCore.gyp
-
- Thus, we are planning to change the build scripts one by one, which implies that
- we need to allow the temporary state in which some build scripts support [Supplemental] IDL
- but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented].
- The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental]
- in another IDL file somewhere, like this:
-
- DOMWindowWebAudio.idl:
- interface [
- Supplemental=DOMWindow
- ] DOMWindowWebAudio {
- attribute attr1;
- attribute attr2;
- };
-
- DOMWindow.idl:
- interface [
- ] DOMWindow {
- attribute [Supplemented] attr1; // This line will be removed after all build scripts support the [Su IDL
- attribute [Supplemented] attr2; // This line will be removed after all build scripts support the [Su IDL.
- attribute attr3;
- attribute attr4;
- };
-
- Assuming these IDL files, this patch implements the following logic in generate-bindings.pl:
-
- - If a given build script supports the [Supplemental] IDL,
- generate-bindings.pl ignores all attributes with the [Supplemented] IDL.
- - Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL
- as normal attributes and instead ignores all attributes with the [Supplemental] IDL
- (i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL).
-
- Tests: webaudio/*
-
- * WebCore.gyp/WebCore.gyp: Describes the build flow that I described above.
- * WebCore.gyp/scripts/action_derivedsourcesallinone.py:
- (main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file. If the file name is a "/cygdrive/c/..."-style path, it is converted to a "C:\cygwin\..."-style path by the cygpath command.
- * WebCore.gypi: Added DOMWindowWebAudio.idl.
- * bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL.
- * page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL.
- * webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl.
-
-2011-12-08 Van Lam <vanlam@google.com>
-
- Caret keeps blinking during forward-delete
- https://bugs.webkit.org/show_bug.cgi?id=38564
-
- Reviewed by Darin Adler.
-
- Currently updateAppearance determines if the caret should stop blinking
- based on whether or not the editing operation changed the position of
- the caret; so the caret stops blinking in case of typing text and
- backwards delete (which always displace the caret) but does not stop
- blinking in the case of forward delete (which does not displace the
- caret).
-
- Added a boolean member function shouldStopCaretBlinking in EditCommand
- which will return true if the object is a TypingCommand (my
- understanding here is that all TypingCommands should stop the caret
- from blinking for a cycle, currently 0.5 seconds). Then used this
- function to stop the caret from blinking if the last editing command
- is a TypingCommand.
-
- * editing/EditCommand.h:
- (WebCore::EditCommand::shouldStopCaretBlinking):
- * editing/FrameSelection.cpp:
- (WebCore::FrameSelection::updateAppearance):
- * editing/TypingCommand.h:
- (WebCore::TypingCommand::shouldStopCaretBlinking):
-
-2011-12-08 Adam Klein <adamk@chromium.org>
-
- Use HashMap<Node*, OwnPtr<...>> in ChildListMutationScope
- https://bugs.webkit.org/show_bug.cgi?id=73964
-
- Reviewed by Darin Adler.
-
- Re-landing r102267 with a fix for the clang build.
-
- No new tests, refactoring only.
-
- * dom/ChildListMutationScope.cpp:
- (WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::childAdded):
- (WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::willRemoveChild):
- (WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::incrementScopingLevel):
- (WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::decrementScopingLevel):
-
-2011-12-08 Anders Carlsson <andersca@apple.com>
-
- WebScrollbarPainterDelegate should have a pointer to its Scrollbar
- https://bugs.webkit.org/show_bug.cgi?id=74149
-
- Reviewed by Darin Adler.
-
- This is another step towards making the scroll animation code more robust.
-
- * platform/mac/ScrollAnimatorMac.mm:
- (-[WebScrollbarPainterDelegate initWithScrollbar:WebCore::]):
- (-[WebScrollbarPainterDelegate scrollAnimator]):
- (-[WebScrollbarPainterDelegate layer]):
- (-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
- (-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
- (-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
- (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
- (-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):
- (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
- (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
-
-2011-12-08 Rakesh KN <rakesh.kn@motorola.com>
-
- keyboard event doesn't fire while moving mouse with button pressed
- https://bugs.webkit.org/show_bug.cgi?id=73821
-
- Reviewed by Alexey Proskuryakov.
-
- Autoscroll should not stop on key press.
-
- Test: fast/events/autoscroll-should-not-stop-on-keypress.html
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::keyEvent):
- Removed the check for autoscroll so that autoscroll is not stopped on
- key press and key event is processed.
-
-2011-12-08 Anders Carlsson <andersca@apple.com>
-
- Add scrollAnimator getter method to WebScrollbarPainterDelegate
- https://bugs.webkit.org/show_bug.cgi?id=74146
-
- Reviewed by Beth Dakin.
-
- * platform/mac/ScrollAnimatorMac.mm:
- (-[WebScrollbarPainterDelegate scrollAnimator]):
- (-[WebScrollbarPainterDelegate layer]):
- (-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
- (-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
- (-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
- (-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
- (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
-
-2011-12-08 James Robinson <jamesr@chromium.org>
-
- Improve handling of frame removal during requestAnimationFrame callback invocation
- https://bugs.webkit.org/show_bug.cgi?id=74036
-
- Reviewed by Adam Barth.
-
- See bug for details.
-
- Test: fast/animation/request-animation-frame-detach-element.html
-
- * dom/Document.cpp:
- (WebCore::Document::removedLastRef):
- (WebCore::Document::detach):
- * dom/Document.h:
- * dom/ScriptedAnimationController.cpp:
- (WebCore::ScriptedAnimationController::~ScriptedAnimationController):
- (WebCore::ScriptedAnimationController::serviceScriptedAnimations):
- (WebCore::ScriptedAnimationController::scheduleAnimation):
- * dom/ScriptedAnimationController.h:
- (WebCore::ScriptedAnimationController::create):
- (WebCore::ScriptedAnimationController::clearDocumentPointer):
- * page/FrameView.cpp:
- (WebCore::FrameView::serviceScriptedAnimations):
-
-2011-12-08 Yongjun Zhang <yongjun_zhang@apple.com>
-
- Use bitfield for bool data members in BitmapImage.
- https://bugs.webkit.org/show_bug.cgi?id=74102
-
- Reviewed by Darin Adler.
-
- Class BitmapImage and FrameData has bool data members, we can use bitfield for those data
- members to reduce the BitmapImage's memory footprint.
-
- * platform/graphics/BitmapImage.cpp:
- (WebCore::BitmapImage::BitmapImage):
- * platform/graphics/BitmapImage.h:
- (WebCore::FrameData::FrameData):
- * platform/graphics/cairo/ImageCairo.cpp:
- (WebCore::BitmapImage::BitmapImage):
- * platform/graphics/cg/ImageCG.cpp:
- (WebCore::BitmapImage::BitmapImage):
- * platform/graphics/openvg/ImageOpenVG.cpp:
- (WebCore::BitmapImage::BitmapImage):
- * platform/graphics/qt/ImageQt.cpp:
- (WebCore::BitmapImage::BitmapImage):
-
-2011-12-08 Anders Carlsson <andersca@apple.com>
-
- Fix a paste-o in ScrollAnimatorMac::updateScrollerStyle
- https://bugs.webkit.org/show_bug.cgi?id=74145
-
- Reviewed by Sam Weinig.
-
- Call setHorizontalScrollerImp to set the horizontal scrollbar painter.
-
- * platform/mac/ScrollAnimatorMac.mm:
- (WebCore::ScrollAnimatorMac::updateScrollerStyle):
-
-2011-12-08 Anders Carlsson <andersca@apple.com>
-
- Create one WebScrollbarPainterDelegate for each scrollbar
- https://bugs.webkit.org/show_bug.cgi?id=74142
-
- Reviewed by Sam Weinig.
-
- Create and destroy WebScrollbarPainterDelegate objects as scrollbars come and go.
- This is a step towards simplifying the WebScrollbarPainterDelegate object.
-
- * platform/mac/ScrollAnimatorMac.h:
- * platform/mac/ScrollAnimatorMac.mm:
- (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
- (WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
- (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
- (WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
- (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
- (WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
- (WebCore::ScrollAnimatorMac::cancelAnimations):
-
-2011-12-08 David Reveman <reveman@chromium.org>
-
- [Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
- https://bugs.webkit.org/show_bug.cgi?id=74017
-
- Reviewed by James Robinson.
-
- Add per-tile drawing to page settings.
-
- No new tests.
-
- * page/Settings.h:
- (WebCore::Settings::setPerTileDrawingEnabled):
- (WebCore::Settings::perTileDrawingEnabled):
- * testing/Internals.cpp:
- (WebCore::Internals::setPerTileDrawingEnabled):
- * testing/Internals.h:
-
-2011-12-08 Anders Carlsson <andersca@apple.com>
-
- Add a scrollbarPainterForScrollbar helper function
- https://bugs.webkit.org/show_bug.cgi?id=74139
-
- Reviewed by Sam Weinig.
-
- * platform/mac/ScrollAnimatorMac.mm:
- (macScrollbarTheme):
- (scrollbarPainterForScrollbar):
- (WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
- (WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
- (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
- (WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
- (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
- (WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
-
-2011-12-08 James Robinson <jamesr@chromium.org>
-
- [chromium] Move NonCompositedContentHost to WebKit
- https://bugs.webkit.org/show_bug.cgi?id=74047
-
- Reviewed by Kenneth Russell.
-
- Updates WebCore.gypi to remove files no longer within WebCore and removes unused forward declaration and include
- from LayerRendererChromium.
-
- * WebCore.gypi:
- * platform/graphics/chromium/LayerRendererChromium.cpp:
- * platform/graphics/chromium/LayerRendererChromium.h:
-
-2011-12-08 Sami Kyostila <skyostil@google.com>
-
- [chromium] Layer contents scale change should trigger invalidation
-
- https://bugs.webkit.org/show_bug.cgi?id=74086
-
- When the contents scale of a layer is changed, the entire contents of
- the layer should be marked dirty.
-
- Reviewed by James Robinson.
-
- * platform/graphics/chromium/LayerChromium.cpp:
- (WebCore::LayerChromium::setContentsScale):
-
-2011-12-08 Stephen White <senorblanco@chromium.org>
-
- [chromium] Add CSS_FILTERS custom binding file to WebCore.gypi.
- https://bugs.webkit.org/show_bug.cgi?id=74091
-
- Reviewed by Adam Barth.
-
- If it builds, you're happy.
-
- * WebCore.gypi:
-
-2011-12-08 Ryosuke Niwa <rniwa@webkit.org>
-
- Line breaks are lost when pasted into textarea text starting with a blank line set while textarea is hidden
- https://bugs.webkit.org/show_bug.cgi?id=74126
-
- Reviewed by Tony Chang.
-
- The bug was caused by the code that generated text out of pre-rendered text was generating div's inside the fragment
- pasted into textarea even though serialization algorithm in textarea doesn't handle block elements.
-
- Fixed the bug by special-casing this in createFragmentFromText. In the long run, we should really get rid of this
- whole pre-rendering trick.
-
- * editing/markup.cpp:
- (WebCore::createFragmentFromText):
-
-2011-12-08 Florin Malita <fmalita@google.com>
-
- Moving SVG elements on the page doesn't always erase element at the old position
- https://bugs.webkit.org/show_bug.cgi?id=74002
-
- Reviewed by Darin Adler.
-
- Test: svg/repaint/container-repaint.svg
-
- * rendering/svg/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::layout):
- Save the old repaint bounds before updating the viewport.
-
-2011-12-08 Tim Horton <timothy_horton@apple.com>
-
- Enable animations of CSS images using -webkit-cross-fade
- https://bugs.webkit.org/show_bug.cgi?id=74049
- <rdar://problem/10209303>
-
- Reviewed by Simon Fraser.
-
- Add support for animating CSS images in the following properties:
- - background(-image)
- - border-image(-source)
- - list-style(-image)
- - -webkit-mask-box-image(-source)
- - -webkit-mask-image(-source)
-
- This patch only adds support for transitioning between NinePieceImages
- where all of the properties except the image itself are equal, and the
- size of the images are equal. Other cases will not animate.
-
- Add animation blend functions for StyleImage and NinePieceImage.
-
- Apply the proper compositing operation to -webkit-cross-fade, and
- fix handling of the destination and source areas to support scaling.
-
- Tests: animations/cross-fade-background-image.html
- animations/cross-fade-border-image-source.html
- animations/cross-fade-list-style-image.html
- animations/cross-fade-webkit-mask-box-image.html
- animations/cross-fade-webkit-mask-image.html
-
- * css/CSSCrossfadeValue.cpp:
- (WebCore::cachedImageForCSSValue):
- (WebCore::CSSCrossfadeValue::fixedSize):
- (WebCore::CSSCrossfadeValue::image):
- * css/CSSImageValue.cpp:
- (WebCore::CSSImageValue::CSSImageValue):
- * css/CSSImageValue.h:
- (WebCore::CSSImageValue::create):
- * page/animation/AnimationBase.cpp:
- (WebCore::crossfadeBlend):
- (WebCore::blendFunc):
- (WebCore::RefCountedPropertyWrapper::RefCountedPropertyWrapper):
- (WebCore::RefCountedPropertyWrapper::blend):
- (WebCore::FillLayerRefCountedPropertyWrapper::FillLayerRefCountedPropertyWrapper):
- (WebCore::FillLayerRefCountedPropertyWrapper::blend):
- (WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
- (WebCore::AnimationBase::ensurePropertyMap):
- (WebCore::addShorthandProperties):
- * platform/graphics/CrossfadeGeneratedImage.cpp:
- (WebCore::CrossfadeGeneratedImage::drawCrossfade):
- (WebCore::CrossfadeGeneratedImage::draw):
- (WebCore::CrossfadeGeneratedImage::drawPattern):
- * platform/graphics/CrossfadeGeneratedImage.h:
- * rendering/style/RenderStyle.h:
- (WebCore::InheritedFlags::setMaskImage):
-
-2011-12-08 Stephen White <senorblanco@chromium.org>
-
- Use Skia's implementation of Gaussian blur when accelerated filters
- are enabled.
- https://bugs.webkit.org/show_bug.cgi?id=73949
-
- Reviewed by Zoltan Herczeg.
-
- In the future, this will be covered by the SVG tests run in GPU mode.
-
- * WebCore.gypi:
- Add FEGaussianBlurSkia.cpp to the build.
- * platform/graphics/filters/FEGaussianBlur.cpp:
- (WebCore::FEGaussianBlur::platformApplySoftware):
- Call out to platformApplySkia() when USE_SKIA is enabled.
- * platform/graphics/filters/FEGaussianBlur.h:
- platformApplySkia() declaration.
- * platform/graphics/filters/skia: Added.
- * platform/graphics/filters/skia/FEGaussianBlurSkia.cpp: Added.
- (WebCore::FEGaussianBlur::platformApplySkia):
- On the Skia port, use SkBlurImageFilter for drawing
- Gaussian blurs in accelerated mode.
- * platform/graphics/skia/ImageBufferSkia.cpp:
- (WebCore::ImageBuffer::copyImage):
- Implement ImageBuffer::copyImage() with DontCopyBackingStore semantics.
-
-2011-12-08 Erik Arvidsson <arv@chromium.org>
-
- CodeGeneratorV8: Fix issue with overloaded static conditional methods
- https://bugs.webkit.org/show_bug.cgi?id=74114
-
- Reviewed by Adam Barth.
-
- The code generator was missing checks for Conditional for overloaded methods.
-
- * bindings/scripts/CodeGeneratorV8.pm:
- (GenerateOverloadedFunctionCallback): Generate needed #ifdefs.
- (GenerateFunctionCallback): Ditto.
- * bindings/scripts/test/V8/V8TestObj.cpp: Wrap conditional methods with #ifdefs.
- (WebCore::ConfigureV8TestObjTemplate):
-
-2011-12-08 Dominic Mazzoni <dmazzoni@google.com>
-
- AccessibilityController should support listening to notifications on all elements.
- https://bugs.webkit.org/show_bug.cgi?id=72866
-
- Changes accessibilitySetShouldRepostNotifications from an instance method
- into a class method so that it can be used for global notification listeners,
- not just for listeners on a particular object.
-
- Reviewed by Chris Fleizach.
-
- Test: accessibility/notification-listeners.html
-
- * accessibility/mac/WebAccessibilityObjectWrapper.h:
- * accessibility/mac/WebAccessibilityObjectWrapper.mm:
- (+[WebAccessibilityObjectWrapper accessibilitySetShouldRepostNotifications:]):
- (-[WebAccessibilityObjectWrapper accessibilityPostedNotification:]):
-
-2011-12-08 Vsevolod Vlasov <vsevik@chromium.org>
-
- Web Inspector: Rename createScriptCallStack() without parameters to createScriptCallStackForInspector().
- https://bugs.webkit.org/show_bug.cgi?id=74120
-
- Reviewed by Pavel Feldman.
-
- * bindings/js/ScriptCallStackFactory.cpp:
- (WebCore::createScriptCallStackForInspector):
- * bindings/js/ScriptCallStackFactory.h:
- * bindings/scripts/CodeGeneratorJS.pm:
- (GenerateParametersCheck):
- * bindings/scripts/CodeGeneratorV8.pm:
- (GenerateFunctionCallback):
- * bindings/scripts/test/JS/JSTestObj.cpp:
- (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
- * bindings/scripts/test/V8/V8TestObj.cpp:
- (WebCore::TestObjInternal::customArgsAndExceptionCallback):
- * bindings/v8/ScriptCallStackFactory.cpp:
- (WebCore::createScriptCallStackForInspector):
- * bindings/v8/ScriptCallStackFactory.h:
-
-2011-12-08 Adrienne Walker <enne@google.com>
-
- [chromium] Remove dead code in compositor
- https://bugs.webkit.org/show_bug.cgi?id=74103
-
- Reviewed by James Robinson.
-
- Tested via the compiler.
-
- * platform/graphics/chromium/LayerChromium.h:
- * platform/graphics/chromium/LayerRendererChromium.cpp:
- * platform/graphics/chromium/LayerRendererChromium.h:
-
-2011-12-08 Eric Penner <epenner@google.com>
-
- [chromium] Need to adjust memory limit and viewport multipliers.
- https://bugs.webkit.org/show_bug.cgi?id=74022
-
- Reviewed by James Robinson.
-
- * platform/graphics/chromium/TextureManager.cpp:
- (WebCore::TextureManager::highLimitBytes): Changing constants
- (WebCore::TextureManager::reclaimLimitBytes): ditto
-
-2011-12-08 Benjamin Poulain <bpoulain@apple.com>
-
- Add a platform EventLoop for iOS
- https://bugs.webkit.org/show_bug.cgi?id=74043
-
- Reviewed by David Kilzer.
-
- * WebCore.xcodeproj/project.pbxproj:
- * platform/ios/EventLoopIOS.mm: Added.
- (WebCore::EventLoop::cycle):
-
-2011-12-08 Pavel Feldman <pfeldman@google.com>
-
- Web Inspector: return node counts on the document / detached root basis
- https://bugs.webkit.org/show_bug.cgi?id=74104
-
- Reviewed by Yury Semikhatsky.
-
- * bindings/js/ScriptProfiler.h:
- * bindings/v8/ScriptProfiler.cpp:
- (WebCore::ScriptProfiler::domNodeCount):
- * bindings/v8/ScriptProfiler.h:
- * inspector/Inspector.json:
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::InspectorController):
- * inspector/InspectorMemoryAgent.cpp:
- (WebCore::InspectorMemoryAgent::getDOMNodeCount):
- (WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
- * inspector/InspectorMemoryAgent.h:
- (WebCore::InspectorMemoryAgent::create):
-
-2011-12-08 Andreas Kling <kling@webkit.org>
-
- RenderObject: Rename styleSlowCase() to styleInRegion().
-
- Rubber-stamped by David Hyatt.
-
- * WebCore.exp.in:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::styleInRegion):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::style):
-
-2011-12-08 Andreas Kling <kling@webkit.org>
-
- Optimize RenderObject::containingBlock().
- <http://webkit.org/b/74109>
-
- Reviewed by David Hyatt.
-
- When climbing the parent chain to locate the containing block-level element,
- use !isRenderBlock() to reject renderers rather than checking against an arbitrary
- list of non-block renderers and then rejecting anything that isn't a block anyway.
-
- RenderObject::containingBlock() was very hot (2.0%) when scrolling on youtube.com.
- This change takes it down to 1.0% (60% of which is RenderObject::isRenderBlock().)
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::containingBlock):
-
-2011-12-08 Nayan Kumar K <nayankk@motorola.com>
-
- Define DEBUG_GL_COMMANDS only in debug builds.
- https://bugs.webkit.org/show_bug.cgi?id=74083
-
- Reviewed by Noam Rosenthal.
-
- No tests added as this change does not affect functionality.
-
- * platform/graphics/opengl/TextureMapperGL.cpp:
-
-2011-12-08 Ryosuke Niwa <rniwa@webkit.org>
-
- CompositeEditCommand should not be kept alive for undo and redo
- https://bugs.webkit.org/show_bug.cgi?id=64414
-
- Reviewed by Enrica Casucci.
-
- This patch introduces EditCommandComposition that replaces CompositeEditCommand for
- undo and redo purposes. Furthermore, we now keep a list of commands instead of a tree of commands
- to unapply and reapply edit commands that composes an undoable action.
-
- Each top-level CompositeEditCommand holds a ref-pointer to EditCommandComposition,
- and applyCommandToComposite adds new SimpleEditCommands to the list.
-
- * editing/CompositeEditCommand.cpp:
- (WebCore::EditCommandComposition::create):
- (WebCore::EditCommandComposition::doApply): Never used.
- (WebCore::EditCommandComposition::doUnapply):
- (WebCore::EditCommandComposition::doReapply):
- (WebCore::EditCommandComposition::append):
- (WebCore::CompositeEditCommand::~CompositeEditCommand): Add an assertion to ensure we didn't create
- a composition for CompositeEditCommands that have parents.
- (WebCore::CompositeEditCommand::doUnapply): Never used.
- (WebCore::CompositeEditCommand::doReapply): Never used.
- (WebCore::CompositeEditCommand::ensureComposition): Creates and attaches a EditCommandComposition.
- (WebCore::CompositeEditCommand::applyCommandToComposite): Append a SimpleEditCommand to the composition.
-
- * editing/CompositeEditCommand.h:
- (WebCore::EditCommandComposition::EditCommandComposition):
- (WebCore::CompositeEditCommand::composition):
- (WebCore::toEditCommandComposition):
- (WebCore::toCompositeEditCommand):
-
- * editing/DeleteButtonController.cpp: Wrap RemoveNodeCommand in RemoveTargetCommand since top level
- commands are now required to be a CompositeEditCommand.
- (WebCore::RemoveTargetCommand::create):
- (WebCore::RemoveTargetCommand::RemoveTargetCommand):
- (WebCore::RemoveTargetCommand::doApply):
- (WebCore::DeleteButtonController::deleteTarget):
-
- * editing/EditCommand.cpp:
- (WebCore::EditCommand::EditCommand): New constructor; used by EditCommandComposition.
- (WebCore::EditCommand::apply): Create a composition for a top-level command.
- (WebCore::EditCommand::unapply): Since we clear m_parent of SimpleEditCommand as soon as they are
- added to EditCommandComposition, we can't use isTopLevelCommand() to differentiate EditCommandComposition
- from SimpleEditCommand. Use isEditCommandComposition() instead.
- (WebCore::EditCommand::reapply): Ditto.
- (WebCore::compositionIfPossible):
- (WebCore::EditCommand::setStartingSelection): Update the starting selection of EditCommandComposition.
- (WebCore::EditCommand::setEndingSelection): Ditto.
- (WebCore::EditCommand::setParent): Accepts a null pointer in order to avoid keeping a stale pointer in
- m_parent inside SimpleEditCommand when CompositeEditCommand goes away.
-
- * editing/EditCommand.h:
- (WebCore::EditCommand::isSimpleEditCommand):
- (WebCore::EditCommand::isCompositeEditCommand):
- (WebCore::EditCommand::isEditCommandComposition):
- (WebCore::EditCommand::parent):
- (WebCore::toSimpleEditCommand):
-
- * editing/Editor.cpp:
- (WebCore::Editor::appliedEditing): Register a EditCommandComposition, instead of a CompositeEditCommand
- to the undo stack.
- (WebCore::Editor::unappliedEditing): Unapplied or reapplied commands are now always EditCommandComposition.
- (WebCore::Editor::reappliedEditing):
- * editing/Editor.h:
-
-2011-12-08 Stephen White <senorblanco@chromium.org>
-
- Add missing V8 bindings to get CSS_FILTERS to compile in Chromium.
- https://bugs.webkit.org/show_bug.cgi?id=74091
-
- Reviewed by Kenneth Russell.
-
- Will be covered by tests in css3/filters (when enabled).
-
- * bindings/v8/custom/V8WebKitCSSFilterValueCustom.cpp: Added.
- (WebCore::V8WebKitCSSFilterValue::indexedPropertyGetter):
-
-2011-12-08 Beth Dakin <bdakin@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=73348
- REGRESSION: Assertion when loading a page with a scrollable RenderLayer
- -and corresponding-
- <rdar://problem/10518918>
-
- Reviewed by Darin Adler.
-
- The main problem here is that certain delegate calls into AppKit for overlay
- scrollbars can cause AppKit to call back into WebKit looking for more information.
- The assertion happens when WebKit tells AppKit that the scroll position has
- changed during a layout, and AppKit immediately asks WebKit to convert some
- coordinates, and WebKit asserts that you shouldn't do that while a layout is still
- happening. It's still possible for AppKit to call this delegate method while a
- layout is happening, and we should guard against that. This patch, however, does
- not do that.
-
- This change instead addresses the reason this assertion started happening much
- more frequently recently, which is that it recently became true that
- notifyPositionChanged() can be called when the position has not changed. To fix
- the assertion AND the bug that that change was intended to fix, we can just make
- sure that either the position OR the scroll origin has changed before calling
- notifyPositionChanged().
-
- * platform/mac/ScrollAnimatorMac.mm:
- (WebCore::ScrollAnimatorMac::immediateScrollToPoint):
-
- Call resetScrollOriginChanged() after the scroll instead of before so that we know
- whether or not to call notifyPositionChanged().
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::updateScrollbars):
-
-2011-12-08 Kaustubh Atrawalkar <kaustubh@motorola.com>
-
- Fixing support for static conditional overloaded functions.
- https://bugs.webkit.org/show_bug.cgi?id=74068
-
- Reviewed by Adam Barth.
-
- * bindings/scripts/CodeGeneratorJS.pm:
- (GenerateImplementation): Pushing "static" keyword after condition "#if".
- * bindings/scripts/test/CPP/WebDOMTestObj.cpp:
- (WebDOMTestObj::overloadedMethod1): Added newly generated bindings.
- * bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
- * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
- (webkit_dom_test_obj_overloaded_method1):
- * bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
- * bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
- (WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
- (WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
- (WebCore::jsTestObjConstructorFunctionOverloadedMethod1):
- * bindings/scripts/test/JS/JSTestObj.h: Ditto.
- * bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
- * bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
- (-[DOMTestObj overloadedMethod1:]):
- * bindings/scripts/test/TestObj.idl: Ditto.
- * bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
- (WebCore::TestObjInternal::overloadedMethod11Callback):
- (WebCore::TestObjInternal::overloadedMethod12Callback):
- (WebCore::TestObjInternal::overloadedMethod1Callback):
- (WebCore::ConfigureV8TestObjTemplate):
-
-2011-12-08 Andreas Kling <kling@webkit.org>
-
- Remove EventListenerMap destructor.
- <http://webkit.org/b/74096>
-
- Reviewed by Darin Adler.
-
- Let the compiler generate ~EventListenerMap(). We only needed it when the hash map
- was managing raw pointers.
-
- We're losing the no-iterators assertion from clear() by doing this, but that was
- superfluous to begin with - we were just using it to avoid duplicating code.
-
- * dom/EventListenerMap.cpp:
- * dom/EventListenerMap.h:
-
-2011-12-08 Takashi Toyoshima <toyoshim@chromium.org>
-
- Provide more specific error description for SocketStreamError.
- https://bugs.webkit.org/show_bug.cgi?id=74066
-
- Reviewed by Martin Robinson.
-
- No new tests because this change just improve error messages for unexpected failures.
-
- * platform/network/soup/SocketStreamError.h: Add an argument for passing error description.
- (WebCore::SocketStreamError::SocketStreamError):
- * platform/network/soup/SocketStreamHandleSoup.cpp: Add error description for SocketStreamError.
- (WebCore::SocketStreamHandle::connected):
- (WebCore::SocketStreamHandle::readBytes):
- (WebCore::SocketStreamHandle::platformSend):
- (WebCore::SocketStreamHandle::platformClose):
-
-2011-12-08 Mihnea Ovidenie <mihnea@adobe.com>
-
- [CSSRegions][CSSOM] Implement NamedFlow interface
- https://bugs.webkit.org/show_bug.cgi?id=66642
-
- Reviewed by David Hyatt.
-
- Add WebKitNamedFlow to support the NamedFlow interface. No methods are
- yet implemented on this interface. The NamedFlow object is a live object.
- The first time user asks for it, it gets a valid JS object whose properties
- will reflect the changes to the flow thread.
-
- Tests: fast/regions/webkit-named-flow-existing-flow.html
- fast/regions/webkit-named-flow-flow-added.html
- fast/regions/webkit-named-flow-modified-flow.html
- fast/regions/webkit-named-flow-non-existing-flow.html
- fast/regions/webkit-named-flow-removed-flow.html
- fast/regions/webkit-named-flow-same-object.html
-
- * CMakeLists.txt:
- * DerivedSources.cpp:
- * DerivedSources.make:
- * DerivedSources.pri:
- * GNUmakefile.list.am:
- * Target.pri:
- * WebCore.gypi:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/gobject/GNUmakefile.am:
- * dom/DOMAllInOne.cpp:
- * dom/Document.cpp:
- (WebCore::Document::webkitGetFlowByName):
- * dom/Document.h:
- * dom/Document.idl:
- * dom/NodeRenderingContext.cpp:
- (WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
- * dom/WebKitNamedFlow.cpp: Added.
- (WebCore::WebKitNamedFlow::WebKitNamedFlow):
- (WebCore::WebKitNamedFlow::~WebKitNamedFlow):
- * dom/WebKitNamedFlow.h: Added.
- (WebCore::WebKitNamedFlow::create):
- * dom/WebKitNamedFlow.idl: Added.
- * rendering/RenderFlowThread.cpp:
- (WebCore::RenderFlowThread::ensureNamedFlow):
- * rendering/RenderFlowThread.h:
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::createObject):
- * rendering/RenderView.cpp:
- (WebCore::RenderView::ensureRenderFlowThreadWithName):
- * rendering/RenderView.h:
-
-2011-12-08 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r102321.
- http://trac.webkit.org/changeset/102321
- https://bugs.webkit.org/show_bug.cgi?id=74072
-
- "Breaks all Chromium clobbered builds" (Requested by apavlov_
- on #webkit).
-
- * WebCore.gyp/WebCore.gyp:
- * WebCore.gyp/scripts/action_derivedsourcesallinone.py:
- (main):
- * WebCore.gypi:
- * bindings/scripts/generate-bindings.pl:
- * page/DOMWindow.idl:
- * webaudio/DOMWindowWebAudio.idl: Removed.
-
-2011-12-08 Shinya Kawanaka <shinyak@google.com>
-
- Refactoring: Editor::requestCheckingFor should take SpellCheckRequest object.
- https://bugs.webkit.org/show_bug.cgi?id=74033
-
- Reviewed by Hajime Morita.
-
- SpellChecker::requestCheckingFor takes SpellCheckRequest object in order to make it easy to
- pass necessary information to requestCheckingFor.
-
- No new tests. Covered by existing tests.
-
- * editing/Editor.cpp:
- (WebCore::Editor::replaceSelectionWithFragment):
- Uses the new interface.
- (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): ditto.
- * editing/SpellChecker.cpp:
- (WebCore::SpellCheckRequest::SpellCheckRequest):
- (WebCore::SpellCheckRequest::~SpellCheckRequest):
- (WebCore::SpellCheckRequest::create):
- Creates a new SpellCheckRequest object.
- (WebCore::SpellChecker::requestCheckingFor):
- Uses the new interface.
- (WebCore::SpellChecker::didCheck):
- * editing/SpellChecker.h:
- (WebCore::SpellCheckRequest::setSequence):
- (WebCore::SpellCheckRequest::sequence):
- (WebCore::SpellCheckRequest::checkingRange):
- (WebCore::SpellCheckRequest::paragraphRange):
- (WebCore::SpellCheckRequest::text):
- (WebCore::SpellCheckRequest::mask):
- (WebCore::SpellCheckRequest::rootEditableElement):
-
-2011-12-08 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r102323.
- http://trac.webkit.org/changeset/102323
- https://bugs.webkit.org/show_bug.cgi?id=74069
-
- Caused Chromium and GTK build failure (Requested by bashi on
- #webkit).
-
- * testing/Internals.cpp:
- (WebCore::Internals::getPageScaleFactor):
- * testing/Internals.h:
- * testing/Internals.idl:
-
-2011-12-08 Fady Samuel <fsamuel@chromium.org>
-
- Move scalePageBy from eventSender to window.internals
- https://bugs.webkit.org/show_bug.cgi?id=64512
-
- Reviewed by Simon Fraser.
-
- Added setPageScaleFactor to window.internals.
- Renamed window.internals.getPageScaleFactor to window.internals.pageScaleFactor
- to match the webkit style.
-
- * testing/Internals.cpp:
- (WebCore::Internals::pageScaleFactor):
- (WebCore::Internals::setPageScaleFactor):
- * testing/Internals.h:
- * testing/Internals.idl:
-
-2011-12-08 Kentaro Hara <haraken@chromium.org>
-
- Use the [Supplemental] IDL for webaudio attributes in Chromium
- https://bugs.webkit.org/show_bug.cgi?id=73394
-
- Reviewed by Adam Barth.
-
- - Overview: Using the [Supplemental] IDL, this patch moves the attribute
- declarations of webaudio from DOMWindow.idl into a new IDL file
- webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained
- feature (aka a module).
-
- - This patch changes the build flow of WebCore.gyp as follows:
-
- Previous build flow:
- foreach $idl (all IDL files) {
- generate-bindings.pl depends on $idl;
- generate-bindings.pl reads $idl;
- generate-bindings.pl generates .h and .cpp files for $idl;
- }
-
- New build flow (See the discussions in bug 72138 for more details):
- resolve-supplemental.pl depends on all IDL files;
- resolve-supplemental.pl reads all IDL files;
- resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
- resolve-supplemental.pl outputs supplemental_dependency.tmp;
- foreach $idl (all IDL files) {
- generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
- generate-bindings.pl reads $idl;
- generate-bindings.pl reads supplemental_dependency.tmp;
- generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl;
- }
-
- - This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL
- will be removed after build scripts for all platforms support the [Supplemental] IDL.
- The motivation for the [Supplemented] IDL is as follows:
-
- In order to support the [Supplemental] IDL, we need to
- (1) run resolve-supplemental.pl and generate supplemental_dependency.tmp
- (2) and run generate-bindings.pl with the supplemental_dependency.tmp.
-
- This build flow requires a change on the following build scripts,
- but changing all the build scripts all at once without any regression is too difficult:
-
- - DerivedSources.make
- - DerivedSources.pri
- - GNUmakefile.am
- - PlatformBlackBerry.cmake
- - UseJSC.cmake
- - UseV8.cmake
- - WebCore.vcproj/MigrateScripts
- - WebCore.vcproj/WebCore.vcproj
- - bindings/gobject/GNUmakefile.am
- - WebCore.gyp/WebCore.gyp
-
- Thus, we are planning to change the build scripts one by one, which implies that
- we need to allow the temporary state in which some build scripts support [Supplemental] IDL
- but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented].
- The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental]
- in another IDL file somewhere, like this:
-
- DOMWindowWebAudio.idl:
- interface [
- Supplemental=DOMWindow
- ] DOMWindowWebAudio {
- attribute attr1;
- attribute attr2;
- };
-
- DOMWindow.idl:
- interface [
- ] DOMWindow {
- attribute [Supplemented] attr1; // This line will be removed after all build scripts support the [Su IDL
- attribute [Supplemented] attr2; // This line will be removed after all build scripts support the [Su IDL.
- attribute attr3;
- attribute attr4;
- };
-
- Assuming these IDL files, this patch implements the following logic in generate-bindings.pl:
-
- - If a given build script supports the [Supplemental] IDL,
- generate-bindings.pl ignores all attributes with the [Supplemented] IDL.
- - Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL
- as normal attributes and instead ignores all attributes with the [Supplemental] IDL
- (i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL).
-
- Tests: webaudio/*
-
- * WebCore.gyp/WebCore.gyp: Describes the build flow that I described above.
- * WebCore.gyp/scripts/action_derivedsourcesallinone.py:
- (main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file. If the file name is a "/cygdrive/c/..."-style path, it is converted to a "C:\cygwin\..."-style path by the cygpath command.
- * WebCore.gypi: Added DOMWindowWebAudio.idl.
- * bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL.
- * page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL.
- * webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl.
-
-2011-12-07 Yosifumi Inoue <yosin@chromium.org>
-
- CSS color gets adjusted for disabled input elements
- https://bugs.webkit.org/show_bug.cgi?id=54643
-
- Reviewed by Kent Tamura.
-
- No new tests. covered by existing tests. Need rebasing some existing tests for Chromimum.
-
- Remove automatic color adjustment for disabled text control for Chromimum.
-
- * css/themeChromium.css: Add CSS entries for default style for disabled input and textarea elements.
- * WebCore/rendering/RenderTextControl.cpp:
- (disabledTextColor): Removed for PLATFORM(CHROMIUM)
- (RenderTextControl::adjustInnerTextStyle): Don't call disabledTextColor for Chromium.
-
-2011-12-07 Dmitry Lomov <dslomov@google.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=74038
- [V8][Chromium] Support legacy argument order in window.postMessage/window.webkitPostMessage.
-
- Reviewed by David Levin.
-
- * bindings/v8/custom/V8DOMWindowCustom.cpp:
- (WebCore::isLegacyTargetOriginDesignation):
- (WebCore::handlePostMessageCallback):
-
-2011-12-07 Mary Wu <mary.wu@torchmobile.com.cn>
-
- Upstream 4 files into WebCore/platform/blackberry
- https://bugs.webkit.org/show_bug.cgi?id=73541
-
- Reviewed by Antonio Gomes.
-
- Initial upstream of BlackBerry porting of PlatformScreen/
- SSLKeyGenerator/Sound/Widget, no new tests.
-
- * PlatformBlackBerry.cmake: Modified to remove empty file "WheelEventBlackBerry.cpp"
- * platform/blackberry/PlatformScreenBlackBerry.cpp: Added.
- (WebCore::screenIsMonochrome):
- (WebCore::screenDepthPerComponent):
- (WebCore::screenDepth):
- (WebCore::screenAvailableRect):
- (WebCore::screenRect):
- * platform/blackberry/SSLKeyGeneratorBlackBerry.cpp: Added.
- (WebCore::getSupportedKeySizes):
- (WebCore::signedPublicKeyAndChallengeString):
- * platform/blackberry/SoundBlackBerry.cpp: Added.
- (WebCore::systemBeep):
- * platform/blackberry/WidgetBlackBerry.cpp: Added.
- (WebCore::Widget::Widget):
- (WebCore::Widget::~Widget):
- (WebCore::Widget::hide):
- (WebCore::Widget::paint):
- (WebCore::Widget::setCursor):
- (WebCore::Widget::setFocus):
- (WebCore::Widget::setFrameRect):
- (WebCore::Widget::setIsSelected):
- (WebCore::Widget::show):
- (WebCore::Widget::frameRect):
-
-2011-12-07 Kenichi Ishibashi <bashi@chromium.org>
-
- Refactor CSSParser::parseFontFaceSrc()
- https://bugs.webkit.org/show_bug.cgi?id=73989
-
- Reviewed by Darin Adler.
-
- Test: fast/css/font-face-src-parsing.html
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseFontFaceSrcURI): Added.
- (WebCore::CSSParser::parseFontFaceSrcLocal): Added.
- (WebCore::CSSParser::parseFontFaceSrc): Rewrote.
- * css/CSSParser.h:
-
-2011-12-07 Xingnan Wang <xingnan.wang@intel.com>
-
- Implement the SSE optimization in SincResampler::process()
- https://bugs.webkit.org/show_bug.cgi?id=73789
-
- Reviewed by Benjamin Poulain.
-
- Here is about 70% performance improvement on the hot spot of sample convolving.
-
- * platform/audio/SincResampler.cpp:
-
-2011-12-07 Luke Macpherson <macpherson@chromium.org>
-
- Implement border image source properties in CSSStyleApplyProperty.
- https://bugs.webkit.org/show_bug.cgi?id=73981
-
- Reviewed by Andreas Kling.
-
- No new tests / refactoring only.
-
- * css/CSSStyleApplyProperty.cpp:
- (WebCore::ApplyPropertyBorderImageSource::applyValue):
- (WebCore::ApplyPropertyBorderImageSource::createHandler):
- (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::applyProperty):
-
-2011-12-07 Noel Gordon <noel.gordon@gmail.com>
-
- WebPImageDecoder should not do a full image decode if progressive decoding is active
- https://bugs.webkit.org/show_bug.cgi?id=74041
-
- Reviewed by Adam Barth.
-
- If the decoder input data state reaches allDataReceived during a progressive image
- decode, the decoder performs a full image decode.
-
- On allDataReceived, check if we already have a decoder, and if so, continue to run
- the progressive decoder.
-
- No new tests. No change in behavior.
-
- * platform/image-decoders/webp/WEBPImageDecoder.cpp:
- (WebCore::WEBPImageDecoder::decode):
-
-2011-12-07 Alexandre Elias <aelias@google.com>
-
- [chromium] Add page-scale animation support to Impl thread
- https://bugs.webkit.org/show_bug.cgi?id=72996
-
- Reviewed by James Robinson.
-
- This adds a new math helper class to compute the progress of the
- animation, and code in the CCLayerTreeHostImpl to apply the animation
- frame by frame.
-
- No new tests. (https://bugs.webkit.org/show_bug.cgi?id=71529 filed.)
-
- * WebCore.gypi:
- * platform/graphics/chromium/cc/CCInputHandler.h:
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- (WebCore::CCLayerTreeHostImpl::animate):
- (WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
- (WebCore::CCLayerTreeHostImpl::processScrollDeltas):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- * platform/graphics/chromium/cc/CCPageScaleAnimation.cpp: Added.
- (WebCore::CCPageScaleAnimation::CCPageScaleAnimation):
- (WebCore::CCPageScaleAnimation::initialize):
- (WebCore::CCPageScaleAnimation::zoomTo):
- (WebCore::CCPageScaleAnimation::zoomWithAnchor):
- (WebCore::CCPageScaleAnimation::zoomElsewhere):
- (WebCore::CCPageScaleAnimation::scrollOffsetAtTime):
- (WebCore::CCPageScaleAnimation::pageScaleAtTime):
- (WebCore::CCPageScaleAnimation::isAnimationCompleteAtTime):
- (WebCore::CCPageScaleAnimation::progressRatioForTime):
- (WebCore::CCPageScaleAnimation::scrollOffsetAtRatio):
- (WebCore::CCPageScaleAnimation::pageScaleAtRatio):
- * platform/graphics/chromium/cc/CCPageScaleAnimation.h: Added.
- (WebCore::CCPageScaleAnimation::startTime):
- (WebCore::CCPageScaleAnimation::duration):
- (WebCore::CCPageScaleAnimation::endTime):
- (WebCore::CCPageScaleAnimation::finalScrollOffset):
- (WebCore::CCPageScaleAnimation::finalPageScale):
-
-2011-12-07 Shinya Kawanaka <shinyak@google.com>
-
- Editor::markAndReplaceFor should take Range instead of TextCheckingParagraph.
- https://bugs.webkit.org/show_bug.cgi?id=74035
-
- Reviewed by Hajime Morita.
-
- Editor::markAndReplaceFor takes chekcing range and paragraph range instead of
- spelling paragraph and grammar paragraph.
-
- No new tests. Covered by existing tests.
-
- * editing/Editor.cpp:
- (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
- (WebCore::Editor::markAndReplaceFor):
- * editing/Editor.h:
- * editing/TextCheckingHelper.cpp:
- (WebCore::TextCheckingParagraph::TextCheckingParagraph):
- * editing/TextCheckingHelper.h:
-
-2011-12-07 Ami Fischman <fischman@chromium.org>
-
- Force LTR layout for media controls even in RTL documents.
- https://bugs.webkit.org/show_bug.cgi?id=74024
-
- Reviewed by Darin Adler.
-
- Test: media/controls-layout-direction.html
-
- * css/mediaControls.css:
- (::-webkit-media-controls):
-
-2011-12-07 Mark Pilgrim <pilgrim@chromium.org>
-
- [FileSystem API] requestFileSystem successCallback is required
- https://bugs.webkit.org/show_bug.cgi?id=69637
-
- Reviewed by Darin Adler.
-
- * page/DOMWindow.idl: remove [Optional] flag from successCallback parameter
-
-2011-12-07 Leo Yang <leo.yang@torchmobile.com.cn>
-
- Upstream the BlackBerry porting of network Resource
- https://bugs.webkit.org/show_bug.cgi?id=73388
-
- Reviewed by Rob Buis.
-
- Other main contributors:
- Joe Mason <jmason@rim.com>
- Yong Li <yoli@rim.com>
- Gary Simmons <gsimmons@rim.com>
- Genevieve Mak <gmak@rim.com>
- Chris Guan <chris.guan@torchmobile.com.cn>
- Mike Lattanzio <mlattanzio@rim.com>
-
- Initial upstream, can't be built yet, no new tests.
-
- * platform/network/blackberry/ResourceError.h: Added.
- * platform/network/blackberry/ResourceErrorBlackBerry.cpp: Added.
- * platform/network/blackberry/ResourceHandleBlackBerry.cpp: Added.
- * platform/network/blackberry/ResourceRequest.h: Added.
- * platform/network/blackberry/ResourceRequestBlackBerry.cpp: Added.
- * platform/network/blackberry/ResourceResponse.h: Added.
- * platform/network/blackberry/ResourceResponseBlackBerry.cpp: Added.
-
-2011-12-07 Fady Samuel <fsamuel@chromium.org>
-
- [Chromium] Plumb DPI info into PlatformScreen
- https://bugs.webkit.org/show_bug.cgi?id=70556
-
- Reviewed by Darin Fisher.
-
- Make DPI information accessible from WebKit through
- PlatformScreen. This is useful when making scaling
- computations on various devices (e.g. Viewport meta tag).
-
- This patch adds DPI plumbing on Chromium Win/Mac/Linux
- platforms.
-
- * page/Screen.cpp:
- (WebCore::Screen::horizontalDPI):
- (WebCore::Screen::verticalDPI):
- * page/Screen.h:
- * platform/PlatformScreen.h:
- * platform/chromium/PlatformScreenChromium.cpp:
- (WebCore::screenHorizontalDPI):
- (WebCore::screenVerticalDPI):
- * platform/chromium/PlatformSupport.h:
- * platform/efl/PlatformScreenEfl.cpp:
- (WebCore::screenHorizontalDPI):
- (WebCore::screenVerticalDPI):
- * platform/gtk/PlatformScreenGtk.cpp:
- (WebCore::screenHorizontalDPI):
- (WebCore::screenVerticalDPI):
- * platform/mac/PlatformScreenMac.mm:
- (WebCore::screenHorizontalDPI):
- (WebCore::screenVerticalDPI):
- * platform/qt/PlatformScreenQt.cpp:
- (WebCore::screenHorizontalDPI):
- (WebCore::screenVerticalDPI):
- * platform/win/PlatformScreenWin.cpp:
- (WebCore::screenHorizontalDPI):
- (WebCore::screenVerticalDPI):
-
-2011-12-07 Aaron Colwell <acolwell@chromium.org>
-
- Revert mixed content handling for video fix and follow-up test expectations & Skipped changes.
- (r101883, r101918, r101927, r101981, r101986, r101997)
- https://bugs.webkit.org/show_bug.cgi?id=72178
-
- Reviewed by Adam Barth.
-
- * loader/SubresourceLoader.cpp:
- (WebCore::SubresourceLoader::willSendRequest):
- * loader/cache/CachedRawResource.cpp:
- * loader/cache/CachedRawResource.h:
- * loader/cache/CachedResource.cpp:
- (WebCore::defaultPriorityForResourceType):
- (WebCore::cachedResourceTypeToTargetType):
- * loader/cache/CachedResource.h:
- * loader/cache/CachedResourceLoader.cpp:
- (WebCore::createResource):
- (WebCore::CachedResourceLoader::checkInsecureContent):
- (WebCore::CachedResourceLoader::canRequest):
- (WebCore::CachedResourceLoader::requestResource):
-
-2011-12-07 Ryuan Choi <ryuan.choi@samsung.com>
-
- [EFL] Introduce AssertMatchingEnums.cpp.
- https://bugs.webkit.org/show_bug.cgi?id=65238
-
- Reviewed by Filip Pizlo.
-
- Remove switch statement which convert EWK_TOUCH_PointType enum values to
- WebCore::PlatformTouchPoint::State enum values.
- Newly added AssertMatchingEnums.cpp assure that they are equal.
-
- No new tests, no new functionality.
-
- * platform/efl/PlatformTouchEventEfl.cpp:
- (WebCore::PlatformTouchEvent::PlatformTouchEvent):
-
-2011-12-07 Shawn Singh <shawnsingh@chromium.org>
-
- [chromium] Clearing root surface should happen after damage tracking
- https://bugs.webkit.org/show_bug.cgi?id=73958
-
- Reviewed by James Robinson.
-
- No new semantics, covered by existing layout tests.
-
- * platform/graphics/chromium/LayerRendererChromium.cpp:
- (WebCore::LayerRendererChromium::clearSurfaceForDebug):
- (WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
- (WebCore::LayerRendererChromium::drawLayersInternal):
- * platform/graphics/chromium/LayerRendererChromium.h:
-
-2011-12-07 Florin Malita <fmalita@google.com>
-
- <li value="0"> behaves like <li> (the same for negative numbers)
- https://bugs.webkit.org/show_bug.cgi?id=73911
-
- Reviewed by Alexey Proskuryakov.
-
- Allow LI values <= 0 and consolidate the value processing logic.
-
- * html/HTMLLIElement.cpp:
- (WebCore::HTMLLIElement::parseMappedAttribute):
- Delegated value parsing to parseValue().
-
- (WebCore::HTMLLIElement::attach):
- Ditto. Explicit value null testing is no longer necessary,
- as parseValue's toInt() performs an equivalent check.
-
- (WebCore::HTMLLIElement::parseValue):
- Consolidated value parsing logic.
-
- * html/HTMLLIElement.h:
-
-2011-12-07 Joshua Bell <jsbell@chromium.org>
-
- IndexedDB: Replace bool args in IDBKeyRange private methods with enum
- https://bugs.webkit.org/show_bug.cgi?id=70743
-
- Reviewed by Tony Chang.
-
- No new tests - no functional changes.
-
- * storage/IDBKeyRange.cpp:
- (WebCore::IDBKeyRange::IDBKeyRange):
- (WebCore::IDBKeyRange::bound):
- * storage/IDBKeyRange.h:
- (WebCore::IDBKeyRange::create):
- (WebCore::IDBKeyRange::lowerOpen):
- (WebCore::IDBKeyRange::upperOpen):
-
-2011-12-07 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r102267.
- http://trac.webkit.org/changeset/102267
- https://bugs.webkit.org/show_bug.cgi?id=74032
-
- Breaks build on Chromium Mac Debug (Requested by aklein on
- #webkit).
-
- * dom/ChildListMutationScope.cpp:
- (WebCore::MutationAccumulationRouter::MutationAccumulationRouter::childAdded):
- (WebCore::MutationAccumulationRouter::MutationAccumulationRouter::willRemoveChild):
- (WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):
- (WebCore::MutationAccumulationRouter::MutationAccumulationRouter::decrementScopingLevel):
-
-2011-12-07 Kentaro Hara <haraken@chromium.org>
-
- REGRESSION (r95249): Right side can be truncated when printing
- https://bugs.webkit.org/show_bug.cgi?id=73868
-
- Reviewed by Darin Adler.
-
- When we print a page with an overflowed width, the right side of the page
- can be truncated. This is due to a wrong rendering calculation.
- Since 'maximumShrinkFactor' is a ratio based on 'pageSize',
- 'maximumShrinkFactor' should multiply (not 'originalPageSize') but 'pageSize'.
- This bug happens if all the following conditions are met:
- - pageLogicalWidth < docLogicalWidth
- - originalPageSize.width * maximumShrinkFactor < docLogicalWidth
- - docLogicalWidth < pageLogicalWidth * maximumShrinkFactor
-
- Test: printing/width-overflow.html
-
- * page/FrameView.cpp:
- (WebCore::FrameView::forceLayoutForPagination):
-
-2011-12-07 Yong Li <yoli@rim.com>
-
- Defer ScriptExecutionContext::Task's in Document when page loading is deferred.
- Schedule them with timer when page loading is resumed. The tasks will be performed
- in the original order. This fixes the problem that database callbacks could be missed
- when page loading was deferred.
- https://bugs.webkit.org/show_bug.cgi?id=49401
-
-
- Reviewed by Darin Adler.
-
- Manual test added: ManualTests/database-callback-deferred.html.
-
- * dom/Document.cpp:
- (WebCore::Document::Document):
- (WebCore::Document::didReceiveTask):
- (WebCore::Document::postTask):
- (WebCore::Document::pendingTasksTimerFired):
- (WebCore::Document::suspendScheduledTasks):
- (WebCore::Document::resumeScheduledTasks):
- * dom/Document.h:
- * page/PageGroupLoadDeferrer.cpp:
- (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
- (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
-
-2011-12-07 Andreas Kling <kling@webkit.org>
-
- RenderObject::style(): Inline early-return condition.
- <http://webkit.org/b/74019>
-
- Reviewed by Anders Carlsson.
-
- style() was very hot (6.1%) when scrolling around on youtube.com,
- and 100% of the calls were taking the early return path.
-
- Inlined the !isRenderFlowThread() check and renamed the function to
- styleSlowCase().
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::styleSlowCase):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::style):
-
-2011-12-07 Adam Klein <adamk@chromium.org>
-
- Use HashMap<Node*, OwnPtr<...>> in ChildListMutationScope
- https://bugs.webkit.org/show_bug.cgi?id=73964
-
- Reviewed by Ryosuke Niwa.
-
- No new tests, refactoring only.
-
- * dom/ChildListMutationScope.cpp:
- (WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::childAdded):
- (WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::willRemoveChild):
- (WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::incrementScopingLevel):
- (WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::decrementScopingLevel):
-
-2011-12-07 Andreas Kling <kling@webkit.org>
-
- RenderLayer::updateZOrderLists(): Inline early-return condition.
- <http://webkit.org/b/74013>
-
- Reviewed by Anders Carlsson.
-
- updateZOrderLists() was hot (1.2%) when scrolling around on youtube.com,
- and 85% of the calls were taking the early return path.
-
- Inlined the two checks for the early return and renamed the function
- to updateZOrderListsSlowCase(). Also reversed their order to avoid the
- virtual call (RenderObject::isRenderView()) if possible.
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::updateZOrderListsSlowCase):
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::updateZOrderLists):
-
-2011-12-07 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r102244.
- http://trac.webkit.org/changeset/102244
- https://bugs.webkit.org/show_bug.cgi?id=74016
-
- caused debug test timeouts (Requested by simonjam on #webkit).
-
- * platform/graphics/skia/ImageBufferSkia.cpp:
- (WebCore::putImageData):
- (WebCore::ImageBuffer::putUnmultipliedImageData):
- (WebCore::ImageBuffer::putPremultipliedImageData):
-
-2011-12-07 Adam Klein <adamk@chromium.org>
-
- Layout Test inspector/debugger/dom-breakpoints.html fails on chromium linux debug with ENABLE(MUTATION_OBSERVERS)
- https://bugs.webkit.org/show_bug.cgi?id=73919
-
- Reviewed by Ojan Vafai.
-
- Use StyleAttributeMutationScope to manage DOM breakpoints for style property changes.
-
- Instead of calling InspectorInstrumentation::didInvalidateStyleAttr()
- directly in setNeedsStyleRecalc, set a bool in the current
- StyleAttributeMutationScope, and delay the call until the scope's
- counter runs down to zero. This keeps the inspector JS from re-entering
- CSSMutableStyleDeclaration until all StyleAttributeMutationScope work is done.
-
- Also fix a small bug in StyleAttributeMutationScope, where
- s_shouldDeliver wasn't getting reset properly to false.
-
- * css/CSSMutableStyleDeclaration.cpp:
- (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
-
-2011-12-07 Ken Buchanan <kenrb@chromium.org>
-
- Crash from multicol spans with layers
- https://bugs.webkit.org/show_bug.cgi?id=68030
-
- Reviewed by David Hyatt.
-
- The layer tree diverges from the render tree when a span is being split
- between columns. This patch causes the layer tree to be updated when necessary.
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::splitFlow)
- (WebCore::RenderBlock::splitBlocks)
-
-2011-12-07 Alexey Proskuryakov <ap@apple.com>
-
- Handling of !important in inline style sets is broken
- https://bugs.webkit.org/show_bug.cgi?id=73941
-
- Reviewed by Dave Hyatt.
-
- This behavior was introduced in bug 8223 to match IE and Firefox. But it doesn't appear that we're matching
- any browser today, and CSSOM spec agrees with them.
-
- * WebCore.exp.in: Don't export CSSStyleDeclaration::setProperty(), no one is using it.
-
- * bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::putDelegate): Use regular
- setProperty(), not the incorrect version that's being removed. Properties set via IDL attributes are never
- important.
-
- * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: (WebCore::V8CSSStyleDeclaration::namedPropertySetter):
- Made the same fix for v8. Why did v8 bindings authors copy/paste the code?!
-
- * css/CSSStyleDeclaration.cpp:
- * css/CSSStyleDeclaration.h:
- Removed a version of setProperty() that attempted to parse the value and extract !important from it.
-
- * html/ImageDocument.cpp:
- (WebCore::ImageDocument::resizeImageToFit):
- (WebCore::ImageDocument::restoreImageSize):
- (WebCore::ImageDocument::windowSizeChanged):
- * page/DragController.cpp:
- (WebCore::DragController::concludeEditDrag):
- We never needed to use this version of setProperty() here, it was just unnecessarily slower.
-
-2011-12-07 Xianzhu Wang <wangxianzhu@chromium.org>
-
- In FontCacheAndroid.cpp should keep the pointer valid returned from CString::data()
- https://bugs.webkit.org/show_bug.cgi?id=73849
-
- The changed code has been covered by many existing layout tests.
-
- Reviewed by Adam Barth.
-
- * platform/graphics/chromium/FontCacheAndroid.cpp:
- (WebCore::FontCache::createFontPlatformData):
-
-2011-12-07 Xiaomei Ji <xji@chromium.org>
-
- Turn on move caret by word visually for Windows platform.
- https://bugs.webkit.org/show_bug.cgi?id=59652
-
- Reviewed by Ryosuke Niwa.
-
- We already support (arrow key) moving cursor by character in visual order.
- This patch implements (ctrl/alt-arrow) moving cursor by word in visual order (in Windows).
- It matches Firefox's default behavior.
-
- Without this patch, ctrl(alt for mac)-arrow key or
- selection.modify("move", "left"/"right", "word") moves cursor by word in logical order.
-
- IE implements moving cursor by logical order for both arrow key and ctrl-arrow key.
- Firefox implements moving cursor by visual order for both operations.
- From Chromium bug report, native speakers would like moving cursor by visual order since it
- is more intuitive.
-
- The patch is only enabled for Windows (by EditingBehavior) because current implementation
- matches Windows' native behavior.
- For exmaple, if the logical text is "abc def hij", the cursor positions are
- "|abc |def |hij|" no matter pressing ctrl-left-arrow or ctrl-right-arrow.
-
- Mac and Linux's native behavior is slightly different. In which, when pressing
- ctrl-left-arrow, the cursor positions are "|abc |def |hij|". When pressing ctrl-right-arrow,
- the cursor positions are "|abc| def| hij|". We will implement it next.
-
- Test: editing/selection/move-left-right-by-word-mac.html
-
- * editing/EditingBehavior.h:
- (WebCore::EditingBehavior::shouldMoveLeftRightByWordInVisualOrder):
- * editing/FrameSelection.cpp: Remove experimental enum WebKitVisualWordGranularity.
- (WebCore::FrameSelection::modifyExtendingRight):
- (WebCore::FrameSelection::modifyExtendingForward):
- (WebCore::FrameSelection::modifyMovingRight):
- (WebCore::FrameSelection::modifyMovingForward):
- (WebCore::FrameSelection::modifyExtendingLeft):
- (WebCore::FrameSelection::modifyExtendingBackward):
- (WebCore::FrameSelection::modifyMovingLeft):
- (WebCore::FrameSelection::modifyMovingBackward):
- * editing/TextGranularity.h: Remove experimental enum WebKitVisualWordGranularity.
- * editing/VisibleSelection.cpp: Remove experimental enum WebKitVisualWordGranularity.
- (WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
- * page/DOMSelection.cpp: Remove experimental experimental flag -webkit-visual-word.
- (WebCore::DOMSelection::modify):
-
-2011-12-07 Jonathan Backer <backer@chromium.org>
-
- [chromium] Plumb damage from WebExternalTextureLayer and WebPluginContainer to CCDamageTracker
- https://bugs.webkit.org/show_bug.cgi?id=73485
-
- Reviewed by Darin Fisher.
-
- * platform/graphics/chromium/PluginLayerChromium.cpp:
- (WebCore::PluginLayerChromium::updateCompositorResources):
- (WebCore::PluginLayerChromium::invalidateRect):
- * platform/graphics/chromium/PluginLayerChromium.h:
-
-2011-12-07 Mary Wu <mary.wu@torchmobile.com.cn>
-
- Upstream 5 files into WebCore/platform/blackberry
- https://bugs.webkit.org/show_bug.cgi?id=73632
-
- Reviewed by Rob Buis.
-
- Initial upstream, no new tests.
-
- * PlatformBlackBerry.cmake: Remove two empty files from build list.
- * platform/blackberry/PopupMenuBlackBerry.cpp: Added.
- (WebCore::PopupMenuBlackBerry::PopupMenuBlackBerry):
- (WebCore::PopupMenuBlackBerry::~PopupMenuBlackBerry):
- (WebCore::PopupMenuBlackBerry::show):
- (WebCore::PopupMenuBlackBerry::hide):
- (WebCore::PopupMenuBlackBerry::updateFromElement):
- (WebCore::PopupMenuBlackBerry::disconnectClient):
- * platform/blackberry/PopupMenuBlackBerry.h: Added.
- (WebCore::PopupMenuBlackBerry::client):
- * platform/blackberry/ScrollbarThemeBlackBerry.cpp: Added.
- (WebCore::ScrollbarTheme::nativeTheme):
- * platform/blackberry/SearchPopupMenuBlackBerry.cpp: Added.
- (WebCore::SearchPopupMenuBlackBerry::SearchPopupMenuBlackBerry):
- (WebCore::SearchPopupMenuBlackBerry::popupMenu):
- (WebCore::SearchPopupMenuBlackBerry::enabled):
- (WebCore::SearchPopupMenuBlackBerry::saveRecentSearches):
- (WebCore::SearchPopupMenuBlackBerry::loadRecentSearches):
- * platform/blackberry/SearchPopupMenuBlackBerry.h: Added.
-
-2011-12-07 Dan Bernstein <mitz@apple.com>
-
- Fixed the definition of BUTTON_CELL_DRAW_WITH_FRAME_DRAWS_FOCUS_RING from r102246.
-
- * platform/mac/ThemeMac.mm: Added parentheses.
-
-2011-12-07 Dan Bernstein <mitz@apple.com>
-
- <rdar://problem/10542095> Focus rings are not drawn around push buttons, radio buttons and checkboxes
-
- Reviewed by Darin Adler.
-
- Instead of relying on -setShowsFirstResponder: to make -drawWithFrame:inView: draw the focus
- ring, use -drawFocusRingMaskWithFrame:inView:.
-
- * platform/mac/ThemeMac.mm:
- (-[NSCell _web_drawFocusRingWithFrame:inView:]): Added. Sets up the focus ring style and a
- transparency layer, then uses -drawFocusRingMaskWithFrame:inView: to draw the focus ring.
- (WebCore::updateStates): Eliminated calls to get and set showsFirstResponder.
- (WebCore::paintCheckbox): Changed to use -_web_drawFocusRingWithFrame:inView:.
- (WebCore::paintRadio): Ditto.
- (WebCore::paintButton): Ditto.
-
-2011-12-07 Brian Salomon <bsalomon@google.com>
-
- [CHROMIUM/SKIA] Handle put[Un/Pre]multipliedImageData conversions in Skia rather than ImageBuffer
- https://bugs.webkit.org/show_bug.cgi?id=73953
-
- Reviewed by Stephen White.
-
- Tested by existing canvas2d layout tests.
-
- * platform/graphics/skia/ImageBufferSkia.cpp:
- (WebCore::putImageData):
- (WebCore::ImageBuffer::putUnmultipliedImageData):
- (WebCore::ImageBuffer::putPremultipliedImageData):
-
-2011-12-07 Andreas Kling <kling@webkit.org>
-
- Micro-optimize ScrollView::visibleContentRect().
- <http://webkit.org/b/74001>
-
- Reviewed by Anders Carlsson.
-
- Reorder the scrollbar exclusion code to minimize the number of virtual calls
- to ScrollableArea::verticalScrollbar(), ScrollableArea::horizontalScrollbar()
- and Scrollbar::isOverlayScrollbar().
-
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::visibleContentRect):
-
-2011-12-07 Andreas Kling <kling@webkit.org>
-
- ApplyPropertyBorderImage: Remove unneeded template argument for mapNinePieceImage().
- <http://webkit.org/b/73998>
-
- Reviewed by Antti Koivisto.
-
- Have ApplyPropertyBorderImage call mapNinePieceImage() directly now that it's
- public (instead of passing it as a template argument.)
-
- * css/CSSStyleApplyProperty.cpp:
- (WebCore::ApplyPropertyBorderImage::applyValue):
- (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
-
-2011-12-07 Jessie Berlin <jberlin@apple.com>
-
- Mac build fix after r102235.
-
- * WebCore.exp.in:
-
-2011-11-30 Simon Hausmann <simon.hausmann@nokia.com>
-
- [Qt] V8 debug build fixes.
-
- Reviewed by Tor Arne Vestbø.
-
- * Target.pri: Add missing files to the build.
- * loader/SubresourceLoader.cpp: Add missing CString.h header file inclusion,
- that is implicitly included with Chromium builds and only needed in ASSERTS
- in debug builds.
- * loader/cache/CachedResource.cpp: Ditto.
- * page/FrameTree.cpp: Ditto.
- * platform/graphics/MediaPlayer.cpp: Ditto.
-
-2011-11-30 Simon Hausmann <simon.hausmann@nokia.com>
-
- [Qt] V8 build fixes.
-
- Reviewed by Tor Arne Vestbø.
-
- * Target.pri: Don't load(javascriptcore) if we're building with v8.
-
-2011-12-07 Mary Wu <mary.wu@torchmobile.com.cn>
-
- Change function name InitializeLoggingChannelsIfNecessary to follow coding style guideline
- https://bugs.webkit.org/show_bug.cgi?id=73986
-
- Reviewed by Kenneth Rohde Christiansen.
-
- Just function name change, no new tests.
-
- * platform/Logging.h:
- * platform/efl/LoggingEfl.cpp:
- (WebCore::initializeLoggingChannelsIfNecessary):
- * platform/gtk/LoggingGtk.cpp:
- (WebCore::initializeLoggingChannelsIfNecessary):
- * platform/mac/LoggingMac.mm:
- (WebCore::initializeLoggingChannelsIfNecessary):
- * platform/qt/LoggingQt.cpp:
- (WebCore::initializeLoggingChannelsIfNecessary):
- * platform/win/LoggingWin.cpp:
- (WebCore::initializeLoggingChannelsIfNecessary):
- * platform/wx/LoggingWx.cpp:
- (WebCore::initializeLoggingChannelsIfNecessary):
-
-2011-12-07 Mihnea Ovidenie <mihnea@adobe.com>
-
- [CSSRegions]Add support for background-color in region styling
- https://bugs.webkit.org/show_bug.cgi?id=71488
-
- Reviewed by David Hyatt.
-
- Tests: fast/regions/region-style-block-background-color.html
- fast/regions/region-style-block-background-color2.html
- fast/regions/region-style-image-background-color.html
- fast/regions/region-style-inline-background-color.html
-
- * WebCore.exp.in:
- * css/CSSStyleSelector.cpp:
- (WebCore::RuleData::regionStyleRule):
- (WebCore::CSSStyleSelector::CSSStyleSelector):
- (WebCore::CSSStyleSelector::addMatchedDeclaration):
- (WebCore::CSSStyleSelector::matchRules):
- (WebCore::CSSStyleSelector::matchAllRules):
- (WebCore::CSSStyleSelector::initForRegionStyling):
- (WebCore::CSSStyleSelector::styleForElement):
- (WebCore::CSSStyleSelector::pseudoStyleForElement):
- (WebCore::RuleData::RuleData):
- (WebCore::RuleSet::RuleSet):
- (WebCore::RuleSet::addToRuleSet):
- (WebCore::CSSStyleSelector::applyDeclarations):
- (WebCore::isValidRegionStyleProperty):
- (WebCore::CSSStyleSelector::applyProperty):
- * css/CSSStyleSelector.h:
- (WebCore::CSSStyleSelector::setRegionForStyling):
- (WebCore::CSSStyleSelector::regionForStyling):
- (WebCore::CSSStyleSelector::applyPropertyToRegionStyle):
- * rendering/RenderFlowThread.cpp:
- (WebCore::RenderFlowThread::clearRenderRegionRangeMap):
- (WebCore::RenderFlowThread::~RenderFlowThread):
- (WebCore::RenderFlowThread::layout):
- (WebCore::RenderFlowThread::clearRenderObjectCustomStyle):
- (WebCore::RenderFlowThread::setRegionRangeForBox):
- * rendering/RenderFlowThread.h:
- * rendering/RenderLayer.cpp:
- (WebCore::CurrentRenderRegionMaintainer::CurrentRenderRegionMaintainer):
- (WebCore::CurrentRenderRegionMaintainer::~CurrentRenderRegionMaintainer):
- (WebCore::RenderLayer::paint):
- (WebCore::RenderLayer::hitTest):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::style):
- * rendering/RenderObject.h:
- (WebCore::RenderObject::canHaveRegionStyle):
- * rendering/RenderObjectChildList.cpp:
- (WebCore::RenderObjectChildList::removeChildNode):
- * rendering/RenderRegion.cpp:
- (WebCore::RenderRegion::layout):
- (WebCore::RenderRegion::renderObjectRegionStyle):
- (WebCore::RenderRegion::computeStyleInRegion):
- (WebCore::RenderRegion::clearObjectStyleInRegion):
- * rendering/RenderRegion.h:
- * rendering/RenderView.cpp:
- (WebCore::RenderView::RenderView):
- * rendering/RenderView.h:
- (WebCore::RenderView::currentRenderRegion):
- (WebCore::RenderView::setCurrentRenderRegion):
-
-2011-12-01 Vsevolod Vlasov <vsevik@chromium.org>
-
- Web Inspector: Extract default call stack creation and check for front-end from console.
- https://bugs.webkit.org/show_bug.cgi?id=73566
-
- Reviewed by Yury Semikhatsky.
-
- * bindings/js/ScriptCallStackFactory.cpp:
- (WebCore::createScriptCallStack):
- * bindings/js/ScriptCallStackFactory.h:
- * bindings/scripts/CodeGeneratorJS.pm:
- (GenerateParametersCheck):
- * bindings/scripts/CodeGeneratorV8.pm:
- (GenerateFunctionCallback):
- * bindings/scripts/test/JS/JSTestObj.cpp:
- (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
- * bindings/scripts/test/V8/V8TestObj.cpp:
- (WebCore::TestObjInternal::customArgsAndExceptionCallback):
- * bindings/v8/ScriptCallStackFactory.cpp:
- (WebCore::createScriptCallStack):
- * bindings/v8/ScriptCallStackFactory.h:
- * inspector/InspectorInstrumentation.cpp:
- (WebCore::InspectorInstrumentation::hasFrontendForScriptContext):
- * inspector/InspectorInstrumentation.h:
- (WebCore::InspectorInstrumentation::hasFrontendForScriptContext):
- * inspector/WorkerInspectorController.h:
- (WebCore::WorkerInspectorController::hasFrontend):
- * page/Console.cpp:
- * page/Console.h:
-
-2011-12-07 Shinya Kawanaka <shinyak@google.com>
-
- Internals should have a method to reutrn the max sequence number of spellcheck reqeust.
- https://bugs.webkit.org/show_bug.cgi?id=73511
-
- Reviewed by Hajime Morita.
-
- Internal state of SpellChecker should be able to be exposed for testing SpellChecker.
- This patch will enable us to know asynchronous spellcheck has finished or not.
-
- Test: editing/spelling/spellcheck-sequencenum.html
-
- * editing/SpellChecker.cpp:
- (WebCore::SpellChecker::SpellChecker):
- (WebCore::SpellChecker::createRequest):
- (WebCore::SpellChecker::didCheck):
- * editing/SpellChecker.h:
- (WebCore::SpellChecker::lastRequestSequence):
- Interface to take SpellCheck sequence numbers.
- (WebCore::SpellChecker::lastProcessedSequence): ditto.
- * testing/Internals.cpp:
- (WebCore::spellchecker):
- (WebCore::Internals::lastSpellCheckRequestSequence):
- (WebCore::Internals::lastSpellCheckProcessedSequence):
- * testing/Internals.h:
- * testing/Internals.idl:
-
-2011-12-07 Ryosuke Niwa <rniwa@webkit.org>
-
- TypingCommand duplicates code to obtain the last typing command
- https://bugs.webkit.org/show_bug.cgi?id=73984
-
- Reviewed by Kent Tamura.
-
- Extracted lastTypingCommandIfStillOpenForTyping out of isOpenForMoreTypingCommand
- and a bunch of TypingCommand static member functions.
-
- Also made more member functions of TypingCommand private.
-
- * editing/Editor.cpp:
- (WebCore::Editor::setComposition):
- * editing/FrameSelection.cpp:
- (WebCore::FrameSelection::setSelection):
- * editing/TypingCommand.cpp:
- (WebCore::TypingCommand::deleteSelection):
- (WebCore::TypingCommand::deleteKeyPressed):
- (WebCore::TypingCommand::forwardDeleteKeyPressed):
- (WebCore::TypingCommand::insertText):
- (WebCore::TypingCommand::insertLineBreak):
- (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
- (WebCore::TypingCommand::insertParagraphSeparator):
- (WebCore::TypingCommand::lastTypingCommandIfStillOpenForTyping):
- (WebCore::TypingCommand::closeTyping):
- * editing/TypingCommand.h:
- (WebCore::TypingCommand::isOpenForMoreTyping):
- (WebCore::TypingCommand::closeTyping):
-
-2011-12-06 Mary Wu <mary.wu@torchmobile.com.cn>
-
- upstream BlackBerry porting of KURL/Logging
- https://bugs.webkit.org/show_bug.cgi?id=73524
-
- Reviewed by Antonio Gomes.
-
- * platform/blackberry/KURLBlackBerry.cpp: Added.
- (WebCore::KURL::fileSystemPath):
- * platform/blackberry/LoggingBlackBerry.cpp: Added.
- (WebCore::initializeWithUserDefault):
- (WebCore::InitializeLoggingChannelsIfNecessary):
-
-2011-12-06 Leo Yang <leo.yang@torchmobile.com.cn>
-
- [BlackBerry] Remove redundant files in PlatformBlackBerry.cmake
- https://bugs.webkit.org/show_bug.cgi?id=73976
-
- Reviewed by Antonio Gomes.
-
- The listing of the following files in PlatformBlackBerry.cmake are redundant. They should be removed.
- platform/network/blackberry/MultipartResponseDelegate.cpp
- platform/network/blackberry/NetworkManager.cpp
- platform/network/blackberry/NetworkStateNotifierBlackBerry.cpp
- platform/network/blackberry/ResourceErrorBlackBerry.cpp
- platform/network/blackberry/ResourceRequestBlackBerry.cpp
-
- * PlatformBlackBerry.cmake:
-
-2011-12-06 Shinya Kawanaka <shinyak@google.com>
-
- Refactoring: Editor::markAllMisspellingsAndBadGrammarInRanges should be refactored.
- https://bugs.webkit.org/show_bug.cgi?id=73628
-
- Reviewed by Hajime Morita.
-
- Extracted a code for adding markers and replacing misspelled words from WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges.
-
- No new tests. covered by existing tests.
-
- * editing/Editor.cpp:
- (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
- Extracted a code for adding markers and replacing missplled words, and moved to markAndReplaceFor.
- (WebCore::Editor::markAndReplaceFor):
- * editing/Editor.h:
-
-2011-12-06 Julien Chaffraix <jchaffraix@webkit.org>
-
- Avoid calling calculateRects in RenderLayer::paintLayer when the rectangles are not needed
- https://bugs.webkit.org/show_bug.cgi?id=73754
-
- Reviewed by Simon Fraser.
-
- Performance change, no change in behavior.
-
- RenderLayer::paintLayer can easily be called a million time when scrolling on a big table with
- td { overflow: hidden; }. We would spend a lot of time recomputing the rectangles that we never
- unused for painting as our layer was not self-painting (clipping layer only) and we did not paint
- some overlay scrollbars.
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::paintLayer):
- Simplified and moved the shouldPaint logic earlier in the function. Now the branches
- are checking the same boolean which makes the logic more obvious. A consequence of
- filling shouldPaint earlier is that we call |calculateRects| only if there is a chance
- the rectangles will used. Also cached the result of isSelfPaintingLayer() in a local
- variable (isSelfPaintingLayer() is fairly expensive due to several virtual calls).
-
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::paintIntoLayer):
- For coherency, applied the same optimizations here too: added an early return instead
- of conditionaly call |calculateRects| as we don't have to restore any clip.
-
-2011-12-06 Benjamin Poulain <benjamin@webkit.org>
-
- Simplify KURL's checkEncodedString()
- https://bugs.webkit.org/show_bug.cgi?id=73890
-
- Reviewed by Andreas Kling.
-
- The Macro UNUSED_PARAM is not supposed to be used for this case,
- use ASSERT_UNUSED instead.
-
- * platform/KURL.cpp:
- (WebCore::checkEncodedString):
-
-2011-12-06 Ryosuke Niwa <rniwa@webkit.org>
-
- The code to create a NodeListsNodeData is duplicated everywhere
- https://bugs.webkit.org/show_bug.cgi?id=73961
-
- Reviewed by Darin Adler.
-
- Extracted the logic to create NodeListsNodeData as NodeRareData::ensureNodeLists.
-
- * dom/Document.cpp:
- (WebCore::Document::getItems):
- * dom/Node.cpp:
- (WebCore::Node::childNodes):
- (WebCore::Node::registerDynamicNodeList):
- (WebCore::Node::getElementsByTagName):
- (WebCore::Node::getElementsByTagNameNS):
- (WebCore::Node::getElementsByName):
- (WebCore::Node::getElementsByClassName):
- * dom/NodeRareData.h:
- (WebCore::NodeRareData::ensureNodeLists):
- * html/HTMLFormControlElement.cpp:
- (WebCore::HTMLFormControlElement::labels):
-
-2011-12-06 Leo Yang <leo.yang@torchmobile.com.cn>
-
- Upstream about: feature in WebKit/blackberry/WebCoreSupport/
- https://bugs.webkit.org/show_bug.cgi?id=73612
-
- Reviewed by Antonio Gomes.
-
- * PlatformBlackBerry.cmake: Move platform/network/blackberry/AboutData.{h, cpp}
- to WebKit/blackberry/WebCoreSupport
-
-2011-12-06 Benjamin Poulain <bpoulain@apple.com>
-
- WebKit Mac does not build without CONTEXT MENU
- https://bugs.webkit.org/show_bug.cgi?id=73962
-
- Reviewed by Pavel Feldman.
-
- In the patch r100903, the symbols were exported under ENABLE(CONTEXT_MENUS)
- because the feature is triggered from the menus.
-
- The implementation has no dependency on the context menu but is necessary to build
- when the inspector is enabled.
- This patch moves the exported symbols from ENABLE(CONTEXT_MENUS) to ENABLE(INSPECTOR).
-
- * WebCore.exp.in:
-
-2011-12-06 Adrienne Walker <enne@google.com>
-
- [chromium] setNeedsCommit on non-composited host layers should trigger commit
- https://bugs.webkit.org/show_bug.cgi?id=73711
-
- Reviewed by James Robinson.
-
- Pipe non-composited content host syncs to setNeedsCommit.
-
- Since now the NonCompositedContentHost generates setNeedsCommit, don't
- call it unnecessarily, e.g. calling setBackgroundColor to the same
- color each frame should not retrigger more commits.
-
- * platform/graphics/chromium/GraphicsLayerChromium.cpp:
- (WebCore::GraphicsLayerChromium::setAnchorPoint):
- (WebCore::GraphicsLayerChromium::setTransform):
- (WebCore::GraphicsLayerChromium::setChildrenTransform):
- (WebCore::GraphicsLayerChromium::setMasksToBounds):
- (WebCore::GraphicsLayerChromium::setBackgroundColor):
- (WebCore::GraphicsLayerChromium::clearBackgroundColor):
- (WebCore::GraphicsLayerChromium::setContentsOpaque):
- (WebCore::GraphicsLayerChromium::setBackfaceVisibility):
- (WebCore::GraphicsLayerChromium::setOpacity):
- * platform/graphics/chromium/LayerChromium.cpp:
- (WebCore::LayerChromium::setNeedsCommit):
- (WebCore::LayerChromium::setAnchorPoint):
- (WebCore::LayerChromium::setAnchorPointZ):
- (WebCore::LayerChromium::setBackgroundColor):
- (WebCore::LayerChromium::setMasksToBounds):
- (WebCore::LayerChromium::setMaskLayer):
- (WebCore::LayerChromium::setOpacity):
- (WebCore::LayerChromium::setOpaque):
- (WebCore::LayerChromium::setPosition):
- (WebCore::LayerChromium::setSublayerTransform):
- (WebCore::LayerChromium::setTransform):
- (WebCore::LayerChromium::setScrollPosition):
- (WebCore::LayerChromium::setScrollable):
- (WebCore::LayerChromium::setDoubleSided):
- * platform/graphics/chromium/LayerChromium.h:
- (WebCore::LayerChromium::setReplicaLayer):
- * platform/graphics/chromium/NonCompositedContentHost.cpp:
- (WebCore::NonCompositedContentHost::notifySyncRequired):
- * platform/graphics/chromium/NonCompositedContentHost.h:
-
-2011-12-06 Kenichi Ishibashi <bashi@chromium.org>
-
- [Chromium] unknown characters symbol on \n in complex script text (RTL and LTR)
- https://bugs.webkit.org/show_bug.cgi?id=73806
-
- Reviewed by Tony Chang.
-
- Sets fMergeNeutralItems to 1 instead of merging script items based on their tags.
-
- Tests: platform/chromium/fast/text/international/chromium-complex-text-non-printable-expected.html
- platform/chromium/fast/text/international/chromium-complex-text-non-printable.html
-
- * platform/graphics/chromium/UniscribeHelper.cpp:
- (WebCore::UniscribeHelper::fillRuns): Removed a block which merges script items.
-
-2011-12-06 Luke Macpherson <macpherson@chromium.org>
-
- Implement remaining border-image and webkit-maskbox-image properties in CSSStyleApplyProperty.
- https://bugs.webkit.org/show_bug.cgi?id=73391
-
- Reviewed by Hajime Morita.
-
- No new tests / refacoring only.
-
- * css/CSSStyleApplyProperty.cpp:
- (WebCore::ApplyPropertyBorderImageModifier::getValue):
- (WebCore::ApplyPropertyBorderImageModifier::setValue):
- (WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
- (WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
- (WebCore::ApplyPropertyBorderImageModifier::applyValue):
- (WebCore::ApplyPropertyBorderImageModifier::createHandler):
- (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
- * css/CSSStyleSelector.cpp:
- (WebCore::CSSStyleSelector::applyProperty):
- * css/CSSStyleSelector.h:
-
-2011-12-06 Pavel Feldman <pfeldman@google.com>
-
- Web Inspector: introduce a memory agent stub.
- https://bugs.webkit.org/show_bug.cgi?id=73930
-
- Reviewed by Timothy Hatcher.
-
- We'd like to experiment with the memory stats and hence need a
- nice home for that. Adding this undocumented agent / domain for now.
-
- * CMakeLists.txt:
- * GNUmakefile.list.am:
- * Target.pri:
- * WebCore.gypi:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/ScriptProfiler.h:
- (WebCore::ScriptProfiler::nodeCount):
- * bindings/v8/ScriptProfiler.cpp:
- (WebCore::ScriptProfiler::nodeCount):
- * bindings/v8/ScriptProfiler.h:
- * inspector/Inspector.json:
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::InspectorController):
- * inspector/InspectorMemoryAgent.cpp: Added.
- (WebCore::InspectorMemoryAgent::~InspectorMemoryAgent):
- (WebCore::InspectorMemoryAgent::getNodeCounter):
- (WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
- * inspector/InspectorMemoryAgent.h: Added.
- (WebCore::InspectorMemoryAgent::create):
-
-2011-12-06 Julien Chaffraix <jchaffraix@webkit.org>
-
- Unreviewed build fix after 102183.
-
- * rendering/style/RenderStyle.h:
- (WebCore::InheritedFlags::initialGridTrackValue):
- Use DEFINE_STATIC_LOCAL to avoid having an exit-time destructor.
-
-2011-12-06 Julien Chaffraix <jchaffraix@webkit.org>
-
- Inline RenderObject::view()
- https://bugs.webkit.org/show_bug.cgi?id=73733
-
- Reviewed by Darin Adler.
-
- Micro-performance optimization, no change in behavior.
-
- RenderObject::view() is super hot and is taking ~4-5% of the time in some
- benchmarks as it is called several hundred thousands times. For some reason,
- the compiler did not inline it even though it is very simple in release builds.
-
- * WebCore.exp.in: Removed RenderObject::view() as it is inlined now.
-
- * rendering/RenderObject.cpp: Moved the implementation from here ...
- * rendering/RenderView.h:
- (WebCore::RenderObject::view): ... to here to avoid a cyclic
- dependency between RenderObject and RenderView. Also marked the
- function as ALWAYS_INLINE.
-
- * rendering/RenderObject.h:
- * rendering/svg/RenderSVGResourceContainer.cpp:
- Added #include "RenderView.h" as the code checks for view() during repaint.
-
-2011-12-06 Julien Chaffraix <jchaffraix@webkit.org>
-
- CSS Grid Layout: Add support for parsing multiple grid-columns or grid-rows
- https://bugs.webkit.org/show_bug.cgi?id=73272
-
- Reviewed by Tony Chang.
-
- Test: fast/css-grid-layout/grid-columns-rows-get-set-multiple.html
-
- Updated our supported syntax to match the following:
- <track-list> := [ <track-breadth> ]+ | 'none'
- <track-breadth> := <length> | <percentage> | 'auto'
- (the naming loosely matches the specification)
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::valueForGridTrackBreadth): Added function to handle a breadth
- (extended with 'auto' that the spec puts in <track-minmax>).
-
- (WebCore::valueForGridTrackList): Create a space seperated list of
- track breadth or none.
-
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated
- to use the new functions.
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseGridTrackList): Extended the function to
- match the new syntax.
-
- * css/CSSStyleApplyProperty.cpp:
- (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Removed our
- simple implementation. Replaced by the CSSStyleSelector functions.
-
- * css/CSSStyleSelector.cpp:
- (WebCore::createGridTrackBreadth):
- (WebCore::createGridTrackList):
- Added those 2 functions to convert the CSSPrimitiveValue to a Vector
- as expected by RenderStyle.
-
- (WebCore::CSSStyleSelector::applyProperty): Added our 2 properties
- now that it is not handled by CSSStyleApplyProperty.
-
- * rendering/style/RenderStyle.h:
- (WebCore::InheritedFlags::gridColumns):
- (WebCore::InheritedFlags::gridRows):
- (WebCore::InheritedFlags::setGridColumns):
- (WebCore::InheritedFlags::setGridRows):
- (WebCore::InheritedFlags::initialGridColumns):
- (WebCore::InheritedFlags::initialGridRows):
- Updated the previous methods to take a Vector of Length.
-
- (WebCore::InheritedFlags::initialGridTrackValue):
- Needed function to return a Vector with one 'none' Length (the initial
- value per the specification).
-
- * rendering/style/StyleGridData.h: Updated to use a Vector.
-
-2011-12-06 David Reveman <reveman@chromium.org>
-
- [Chromium] Implement tile-sized painting using SkPicture.
- https://bugs.webkit.org/show_bug.cgi?id=71869
-
- Reviewed by James Robinson.
-
- Add texture uploader that paints tile-sized chunks using SkPicture
- recording and playback. Expose setting which allows this texture
- updater to be enabled.
-
- No new tests. Covered by existing tests.
-
- * WebCore.gypi:
- * platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp: Added.
- (WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::Texture):
- (WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):
- (WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
- (WebCore::BitmapSkPictureCanvasLayerTextureUpdater::create):
- (WebCore::BitmapSkPictureCanvasLayerTextureUpdater::BitmapSkPictureCanvasLayerTextureUpdater):
- (WebCore::BitmapSkPictureCanvasLayerTextureUpdater::~BitmapSkPictureCanvasLayerTextureUpdater):
- (WebCore::BitmapSkPictureCanvasLayerTextureUpdater::createTexture):
- (WebCore::BitmapSkPictureCanvasLayerTextureUpdater::sampledTexelFormat):
- (WebCore::BitmapSkPictureCanvasLayerTextureUpdater::prepareToUpdate):
- (WebCore::BitmapSkPictureCanvasLayerTextureUpdater::paintContentsRect):
- (WebCore::BitmapSkPictureCanvasLayerTextureUpdater::updateTextureRect):
- * platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h: Added.
- (WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::textureUpdater):
- (WebCore::BitmapSkPictureCanvasLayerTextureUpdater::orientation):
- * platform/graphics/chromium/ContentLayerChromium.cpp:
- (WebCore::ContentLayerChromium::createTextureUpdater):
- * platform/graphics/chromium/cc/CCLayerTreeHost.h:
- (WebCore::CCSettings::CCSettings):
-
-2011-12-06 Adrienne Walker <enne@google.com>
-
- [chromium] Don't crash if tile upload happens without painting first
- https://bugs.webkit.org/show_bug.cgi?id=73939
-
- Reviewed by James Robinson.
-
- Remove at least one place (in ImageLayerChromium) where this could
- happen.
-
- Although this shouldn't happen, we should be robust to it in the
- chance that other code causes it to.
-
- * platform/graphics/chromium/ImageLayerChromium.cpp:
- (WebCore::ImageLayerChromium::paintContentsIfDirty):
- * platform/graphics/chromium/TiledLayerChromium.cpp:
- (WebCore::TiledLayerChromium::updateCompositorResources):
-
-2011-12-06 Ruben <chromium@hybridsource.org>
-
- Enable web audio by default on non-Mac POSIX platforms
- https://bugs.webkit.org/show_bug.cgi?id=73491
-
- Reviewed by Tony Chang.
-
- No new tests, just changing gyp includes.
-
- * WebCore.gyp/WebCore.gyp:
-
-2011-12-06 Benjamin Poulain <benjamin@webkit.org>
-
- Put length in its own variable in KURL copyASCII
- https://bugs.webkit.org/show_bug.cgi?id=73928
-
- Reviewed by Darin Adler.
-
- * platform/KURL.cpp:
- (WebCore::copyASCII):
-
-2011-12-06 Dana Jansens <danakj@chromium.org>
-
- [chromium] Set opaque flag for ImageLayerChromium
- https://bugs.webkit.org/show_bug.cgi?id=72964
-
- Reviewed by James Robinson.
-
- Unit test in tests/ImageLayerChromiumTest.cpp.
-
- * platform/graphics/chromium/GraphicsLayerChromium.cpp:
- (WebCore::GraphicsLayerChromium::setContentsToImage):
- * platform/graphics/chromium/GraphicsLayerChromium.h:
- (WebCore::GraphicsLayerChromium::contentsLayer):
- * platform/graphics/chromium/ImageLayerChromium.cpp:
- (WebCore::ImageLayerChromium::setContents):
-
-2011-12-06 Alexandre Elias <aelias@google.com>
-
- [chromium] Apply sent deltas on finishCommit
- https://bugs.webkit.org/show_bug.cgi?id=73884
-
- Reviewed by James Robinson.
-
- This moves scroll and pageScale "sent" deltas to be applied to
- the layer at the end of the commit, instead of the beginning.
-
- This has several advantages, especially for page scale:
- - When pageScale changes, no longer any need to change the scroll's
- coordinate space at beginning of commit, which is complex and prone to
- bugs (this fixes a problem where we were forgetting to modify the
- scrollPosition before).
- - No need for non-commit-related code to consider the "sent" values.
- m_pageScale is now always the content scale factor, and
- m_pageScaleDelta is the scale to be on the impl-side matrix.
- - This will make it easy to send arbitrary fake or future delta
- values for example while pinch zooming out.
-
- The scroll logic is similarly altered for consistency's sake. Note that
- I also moved the tree synchronize to the beginning of finishCommit
- in order to avoid having to change the pageScale coordinate space of
- sentScrollDelta in adjustScrollsForPageScaleChange().
-
- No new tests. (Refactoring of existing code.)
-
- * platform/graphics/chromium/LayerChromium.cpp:
- (WebCore::LayerChromium::pushPropertiesTo):
- * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
- (WebCore::CCLayerTreeHost::finishCommitOnImplThread):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- (WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
- (WebCore::CCLayerTreeHostImpl::applyPageScaleDeltaToScrollLayer):
- (WebCore::CCLayerTreeHostImpl::processScrollDeltas):
-
-2011-12-06 Gavin Barraclough <barraclough@apple.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=68328
- The generator and intrinsic fields in HashTableValue/HashEntry and associated structures and methods are redundant
-
- Reviewed by Geoff Garen.
-
- Intrinsic is no longer in the DFG namespace, is always in the
- hash table. Removed ThunkGenerator.
-
- * bindings/scripts/CodeGeneratorJS.pm:
- (GenerateHashTable):
-
-2011-12-06 Dimitri Glazkov <dglazkov@chromium.org>
-
- Unreviewed, rolling out r102091.
- http://trac.webkit.org/changeset/102091
- https://bugs.webkit.org/show_bug.cgi?id=73711
-
- Caused Clang Linux compile failure.
-
- * platform/graphics/chromium/GraphicsLayerChromium.cpp:
- (WebCore::GraphicsLayerChromium::setAnchorPoint):
- (WebCore::GraphicsLayerChromium::setTransform):
- (WebCore::GraphicsLayerChromium::setChildrenTransform):
- (WebCore::GraphicsLayerChromium::setMasksToBounds):
- (WebCore::GraphicsLayerChromium::setBackgroundColor):
- (WebCore::GraphicsLayerChromium::clearBackgroundColor):
- (WebCore::GraphicsLayerChromium::setContentsOpaque):
- (WebCore::GraphicsLayerChromium::setBackfaceVisibility):
- (WebCore::GraphicsLayerChromium::setOpacity):
- * platform/graphics/chromium/LayerChromium.cpp:
- (WebCore::LayerChromium::setNeedsCommit):
- * platform/graphics/chromium/LayerChromium.h:
- (WebCore::LayerChromium::setAnchorPoint):
- (WebCore::LayerChromium::setAnchorPointZ):
- (WebCore::LayerChromium::setBackgroundColor):
- (WebCore::LayerChromium::setMasksToBounds):
- (WebCore::LayerChromium::setMaskLayer):
- (WebCore::LayerChromium::setOpacity):
- (WebCore::LayerChromium::setOpaque):
- (WebCore::LayerChromium::setPosition):
- (WebCore::LayerChromium::setSublayerTransform):
- (WebCore::LayerChromium::setTransform):
- (WebCore::LayerChromium::setScrollPosition):
- (WebCore::LayerChromium::setScrollable):
- (WebCore::LayerChromium::setDoubleSided):
- (WebCore::LayerChromium::setReplicaLayer):
- * platform/graphics/chromium/NonCompositedContentHost.cpp:
- (WebCore::NonCompositedContentHost::notifySyncRequired):
- * platform/graphics/chromium/NonCompositedContentHost.h:
-
-2011-12-06 Dana Jansens <danakj@chromium.org>
-
- [Chromium] Make root layer always opaque
- https://bugs.webkit.org/show_bug.cgi?id=70564
-
- Reviewed by James Robinson.
-
- * platform/graphics/chromium/NonCompositedContentHost.cpp:
- (WebCore::NonCompositedContentHost::NonCompositedContentHost):
- * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
- (WebCore::CCTiledLayerImpl::draw):
-
-2011-12-06 Noel Gordon <noel.gordon@gmail.com>
-
- WebPImageDecoder computes image width and height multiple times
- https://bugs.webkit.org/show_bug.cgi?id=73796
-
- Reviewed by Adam Barth.
-
- Once sufficient image data arrives, we can compute the decoded image height
- and width from the WEBP image header data.
-
- From then on, the decoded image size is known so there's no need to re-read
- it from the WEBP image header again.
-
- No change in behavior, so no new tests.
-
- * platform/image-decoders/webp/WEBPImageDecoder.cpp:
- (WebCore::WEBPImageDecoder::decode):
-
-2011-12-06 Mike Reed <reed@google.com>
-
- optimize TransformationMatrix::scale by not calling through to generic multiply
- https://bugs.webkit.org/show_bug.cgi?id=73830
-
- Reviewed by Kenneth Russell.
-
- No new tests. Optimization only, existing tests exercise the code
-
- * platform/graphics/transforms/TransformationMatrix.cpp:
- (WebCore::TransformationMatrix::scaleNonUniform):
- (WebCore::TransformationMatrix::scale3d):
-
-2011-12-06 Eric Carlson <eric.carlson@apple.com>
-
- Revert WebCore track Settings changes made in r101977
- https://bugs.webkit.org/show_bug.cgi?id=73879
-
- Reviewed by Sam Weinig.
-
- No new tests yet, still nothing to test.
-
- * page/Settings.cpp: Move the preference setters back into the .h file.
- * page/Settings.h:
- (WebCore::Settings::setShouldDisplaySubtitles):
- (WebCore::Settings::setShouldDisplayCaptions):
- (WebCore::Settings::setShouldDisplayTextDescriptions):
-
-2011-12-06 Andreas Kling <kling@webkit.org>
-
- MediaList: Remove constructor that takes a CSSImportRule*.
- <http://webkit.org/b/73833>
-
- Reviewed by Antti Koivisto.
-
- * css/MediaList.h:
- * css/MediaList.cpp:
-
- Remove MediaList(CSSImportRule*, ...) constructor.
-
- * css/CSSImportRule.cpp:
- (WebCore::CSSImportRule::CSSImportRule):
-
- Have CSSImportRule construct its MediaList by passing the parent
- style sheet, which is exactly what the old constructor accomplished.
- Also assert that we're always created with a non-null parent sheet.
-
-2011-12-06 Jarred Nicholls <jarred@sencha.com>
-
- getComputedStyle returns wrong value for margin-*
- https://bugs.webkit.org/show_bug.cgi?id=73334
-
- margin-* getComputedStyle values should return the "used" absolute value when there is a renderer
- and the specified value is relative (percentage, auto, etc.).
- When there is no renderer, the specified value should be returned.
- See http://dev.w3.org/csswg/cssom/#resolved-values.
-
- Reviewed by Darin Adler.
-
- Test: fast/css/getComputedStyle/getComputedStyle-resolved-values.html
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
-
-2011-12-06 Alexey Proskuryakov <ap@apple.com>
-
- REGRESSION (WebKit2): Kill ring is not cleared when selection changes
- https://bugs.webkit.org/show_bug.cgi?id=73888
- <rdar://problem/10532310>
-
- Reviewed by Mark Rowe.
-
- Test: editing/pasteboard/emacs-ctrl-k-with-move.html
-
- * editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): Moved the code to clear
- kill ring from Mac WebKit, as it's needed in all Mac ports at least.
-
-2011-12-06 Darin Adler <darin@apple.com>
-
- Use HashMap<OwnPtr> in CollectionCache
- https://bugs.webkit.org/show_bug.cgi?id=73784
-
- Reviewed by Andreas Kling.
-
- * html/CollectionCache.cpp:
- (WebCore::CollectionCache::copyCacheMap): Use adoptPtr.
- (WebCore::CollectionCache::reset): Removed now-unneeded calls to deleteAllValues.
- (WebCore::append): Added. Helper function for appending elements to the maps from
- the collection cache.
-
- * html/CollectionCache.h: Changed mapped type in NodeCacheMap to OwnPtr.
- Added append function.
-
- * html/HTMLCollection.cpp:
- (WebCore::nameShouldBeVisibleInDocumentAll): Added, to factor out common code in
- two functions below.
- (WebCore::HTMLCollection::checkForNameMatch): Changed to call nameShouldBeVisibleInDocumentAll.
- (WebCore::HTMLCollection::updateNameCache): Ditto. Also updated cache code to use the append
- function, so it will work with OwnPtr. Also eliminated an unneeded get call before
- each hash table add; we do both at once in the new append function.
- * html/HTMLFormCollection.cpp:
- (WebCore::HTMLFormCollection::updateNameCache): More of the same.
-
-2011-12-06 Yury Semikhatsky <yurys@chromium.org>
-
- [Chromium] Web Inspector: getFunctionLocation should return scriptId as String not as int
- https://bugs.webkit.org/show_bug.cgi?id=73892
-
- Reviewed by Pavel Feldman.
-
- * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
- (WebCore::V8InjectedScriptHost::functionLocationCallback): scriptId should be a string not a number
- * inspector/Inspector.json: removed unused parameter
-
-2011-11-21 Balazs Kelemen <kbalazs@webkit.org>
-
- Enable ParallelJobs by default
- https://bugs.webkit.org/show_bug.cgi?id=70032
-
- Reviewed by Zoltan Herczeg.
-
- Covered by existing tests.
-
- According to measurements on Mac and Linux it is a
- considerable speedup for SVG on multicore.
-
- Remove the ENABLE(PARALLEL_JOBS) guard. Fix the Windows build
- by qualifying ParallelJobs with the WTF namespace (otherwise
- MSVC believes it belongs to WebCore which is likely a compiler bug).
-
- * platform/graphics/filters/FEConvolveMatrix.cpp:
- (WebCore::FEConvolveMatrix::setInteriorPixelsWorker):
- (WebCore::FEConvolveMatrix::platformApplySoftware):
- * platform/graphics/filters/FEConvolveMatrix.h:
- * platform/graphics/filters/FEGaussianBlur.cpp:
- (WebCore::FEGaussianBlur::platformApplyWorker):
- (WebCore::FEGaussianBlur::platformApply):
- * platform/graphics/filters/FEGaussianBlur.h:
- * platform/graphics/filters/FELighting.cpp:
- (WebCore::FELighting::platformApplyGenericWorker):
- (WebCore::FELighting::platformApplyGeneric):
- * platform/graphics/filters/FELighting.h:
- * platform/graphics/filters/FEMorphology.cpp:
- (WebCore::FEMorphology::platformApplyWorker):
- (WebCore::FEMorphology::platformApply):
- * platform/graphics/filters/FEMorphology.h:
- * platform/graphics/filters/FETurbulence.cpp:
- (WebCore::FETurbulence::fillRegionWorker):
- (WebCore::FETurbulence::platformApplySoftware):
- * platform/graphics/filters/FETurbulence.h:
- * platform/graphics/filters/arm/FELightingNEON.cpp:
- (WebCore::FELighting::platformApplyNeonWorker):
- * platform/graphics/filters/arm/FELightingNEON.h:
- (WebCore::FELighting::platformApplyNeon):
-
-2011-12-06 Andreas Kling <kling@webkit.org>
-
- Unreviewed assertion fix for r102123.
-
- * platform/KURL.cpp:
- (WebCore::checkEncodedString):
-
-2011-12-06 Benjamin Poulain <benjamin@webkit.org>
-
- Simplify KURL's checkEncodedString()
- https://bugs.webkit.org/show_bug.cgi?id=73890
-
- Reviewed by Andreas Kling.
-
- The method was reimplementing String::containsOnlyASCII().
- Use the method from String and we can remove the #if NDEBUG.
-
- * platform/KURL.cpp:
- (WebCore::checkEncodedString):
-
-2011-12-06 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r102111.
- http://trac.webkit.org/changeset/102111
- https://bugs.webkit.org/show_bug.cgi?id=73902
-
- Breaks compilation (Requested by vsevik on #webkit).
-
- * editing/Editor.cpp:
- (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
- * editing/Editor.h:
-
-2011-12-06 Hajime Morrita <morrita@chromium.org>
-
- [Refactoring] Accessing Node::m_document should be minimized.
- https://bugs.webkit.org/show_bug.cgi?id=73800
-
- Reviewed by Kent Tamura.
-
- No new tests. No behavioral change.
-
- Replaced m_document reference with the document() accessor
- or temporaril variables. This is a preparation for using
- m_document space to point a shadow root pointer.
-
- * dom/Document.h:
- (WebCore::Node::Node):
- * dom/Node.cpp:
- (WebCore::Node::~Node):
-
-2011-12-06 Shinya Kawanaka <shinyak@google.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=73889
- TextCheckingParagraph::offsetTo should not have a side effect.
-
- Reviewed by Hajime Morita.
-
- Since TextCheckingParagraph::offsetTo had a side effect, its cache often became inconsistent.
- This is likely to cause a bug when changing SpellChecker and Editor.
-
- No new tests. Covered by existing tests.
-
- * editing/TextCheckingHelper.cpp:
- (WebCore::TextCheckingParagraph::offsetTo):
-
-2011-12-06 Eric Penner <epenner@google.com>
-
- [chromium] Set texture limits as multiples of viewport size instead of hardcoded values
- https://bugs.webkit.org/show_bug.cgi?id=72202
-
- Reviewed by James Robinson.
-
- * platform/graphics/chromium/LayerRendererChromium.cpp:
- (WebCore::LayerRendererChromium::drawLayers): added viewport param
- (WebCore::LayerRendererChromium::initializeSharedObjects): ditto
- * platform/graphics/chromium/TextureManager.cpp:
- (WebCore::TextureManager::highLimitBytes): calculated based on viewport
- (WebCore::TextureManager::reclaimLimitBytes): ditto
- (WebCore::TextureManager::lowLimitBytes): ditto
- (WebCore::TextureManager::TextureManager): added viewport param
- (WebCore::TextureManager::setMaxMemoryLimitBytes): changed name
- (WebCore::TextureManager::setPreferredMemoryLimitBytes): added function
- (WebCore::TextureManager::requestTexture): added viewport param
- * platform/graphics/chromium/TextureManager.h: ditto
- (WebCore::TextureManager::create): ditto
- * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: ditto
- (WebCore::CCLayerTreeHost::initialize): ditto
- (WebCore::CCLayerTreeHost::beginCommitOnImplThread): ditto
- (WebCore::CCLayerTreeHost::setViewport): ditto
- (WebCore::CCLayerTreeHost::setVisible): ditto
- (WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread): ditto
-
-2011-12-06 Huang Dongsung <luxtella@company100.net>
-
- [TexMap][QT] Draw the borders of media and webgl elements in TexMap.
- https://bugs.webkit.org/show_bug.cgi?id=73817
-
- GraphicsContext3D only draws the content of the WebGL canvas, not the additional
- CSS such as the borders. TextureMapper should render the content of a
- media/webgl layer before drawing the actual canvas.
- This makes LayoutTests/compositing/webgl/webgl-reflection.html work.
-
- Reviewed by Noam Rosenthal.
-
- * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
- (WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
- * platform/graphics/texmap/GraphicsLayerTextureMapper.h:
- * platform/graphics/texmap/TextureMapperNode.cpp:
- (WebCore::TextureMapperNode::renderContent):
- (WebCore::TextureMapperNode::paintSelf):
-
-2011-12-06 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r102043.
- http://trac.webkit.org/changeset/102043
- https://bugs.webkit.org/show_bug.cgi?id=73898
-
- Breaks chromium mac-cg compilation. (Requested by vsevik on
- #webkit).
-
- * platform/graphics/chromium/GraphicsLayerChromium.cpp:
- (WebCore::GraphicsLayerChromium::setContentsToImage):
- * platform/graphics/chromium/GraphicsLayerChromium.h:
- (WebCore::GraphicsLayerChromium::contentsLayer):
- * platform/graphics/chromium/ImageLayerChromium.cpp:
- (WebCore::ImageLayerChromium::setContents):
-
-2011-12-06 Shinya Kawanaka <shinyak@google.com>
-
- Refactoring: Editor::markAllMisspellingsAndBadGrammarInRanges should be refactored.
- https://bugs.webkit.org/show_bug.cgi?id=73628
-
- Reviewed by Hajime Morita.
-
- Extracted a code for adding markers and replacing misspelled words from WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges.
-
- No new tests. covered by existing tests.
-
- * editing/Editor.cpp:
- (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
- Extracted a code for adding markers and replacing missplled words, and moved to markAndReplaceFor.
- (WebCore::Editor::markAndReplaceFor):
- * editing/Editor.h:
-
-2011-12-05 Alexander Pavlov <apavlov@chromium.org>
-
- Web Inspector: [Audits] Implement "Stop" button and progress bar instead of spinner.
- https://bugs.webkit.org/show_bug.cgi?id=73626
-
- Reviewed by Yury Semikhatsky.
-
- * English.lproj/localizedStrings.js:
- * inspector/front-end/AuditLauncherView.js:
- (WebInspector.AuditLauncherView):
- (WebInspector.AuditLauncherView.prototype._setAuditRunning):
- (WebInspector.AuditLauncherView.prototype._launchButtonClicked):
- (WebInspector.AuditLauncherView.prototype._createLauncherUI):
- (WebInspector.AuditLauncherView.prototype._updateResourceProgress):
- (WebInspector.AuditLauncherView.prototype._updateButton):
- * inspector/front-end/AuditRules.js:
- (WebInspector.AuditRules.GzipRule.prototype.doRun):
- (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
- (WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
- (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
- (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.documentLoaded):
- (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
- (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
- (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
- (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
- (WebInspector.AuditRules.CacheControlRule.prototype.doRun):
- (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
- (WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
- (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
- (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
- (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.onDocumentAvailable):
- (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
- (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
- (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
- (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.onDocumentAvailable):
- (WebInspector.AuditRules.CookieRuleBase.prototype.doRun.resultCallback):
- (WebInspector.AuditRules.CookieRuleBase.prototype.doRun):
- * inspector/front-end/AuditsPanel.js:
- (WebInspector.AuditsPanel):
- (WebInspector.AuditsPanel.prototype._executeAudit.ruleResultReadyCallback):
- (WebInspector.AuditsPanel.prototype._executeAudit):
- (WebInspector.AuditsPanel.prototype._auditFinishedCallback):
- (WebInspector.AuditsPanel.prototype.terminateAudit):
- (WebInspector.AuditCategory.prototype.run):
- (WebInspector.AuditRule.prototype.run):
- (WebInspector.AuditRule.prototype.doRun):
- (WebInspector.AuditProgressMonitor):
- (WebInspector.AuditProgressMonitor.prototype.setTotalWork):
- (WebInspector.AuditProgressMonitor.prototype.worked):
- (WebInspector.AuditProgressMonitor.prototype.get indeterminate):
- (WebInspector.AuditProgressMonitor.prototype.done):
- (WebInspector.AuditProgressMonitor.prototype.get canceled):
- (WebInspector.AuditProgressMonitor.prototype.set canceled):
-
-2011-12-06 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
-
- [Qt] [WK2] MiniBrowser assert on startup in debug build after r101713
- https://bugs.webkit.org/show_bug.cgi?id=73874
-
- This change partially reverts r101713 restoring original behaviour for
- KUrl creation from empty string and fixes asserts in debug build.
-
- Reviewed by Alexey Proskuryakov.
-
- No new tests. Tests from r101713 pass.
-
- * platform/KURL.cpp:
- (WebCore::KURL::init):
- (WebCore::KURL::parse):
- * platform/KURL.h:
-
-2011-12-06 Andreas Kling <kling@webkit.org>
-
- Use HashMap<OwnPtr> for EventListenerMap's internal map.
- <http://webkit.org/b/73761>
-
- Reviewed by Benjamin Poulain.
-
- Changed the value type of EventListenerMap::m_hashMap to OwnPtr<EventListenerVector>.
- This means we no longer need to manually delete the vectors when taking them out of
- the map, which makes the code a little prettier.
-
- A few tweaks were necessary; release() instead of leakPtr() when switching modes
- and adoptPtr()/get() sprinkled as needed.
-
- * dom/EventListenerMap.h:
- * dom/EventListenerMap.cpp:
- (WebCore::EventListenerMap::clear):
- (WebCore::EventListenerMap::add):
- (WebCore::EventListenerMap::remove):
- (WebCore::EventListenerMap::find):
- (WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
- (WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
-
-2011-12-05 Rafael Weinstein <rafaelw@chromium.org>
-
- [MutationObservers] Support 'attributes' mutation records for element.removeAttribute
- https://bugs.webkit.org/show_bug.cgi?id=73880
-
- Reviewed by Ojan Vafai.
-
- * dom/Element.cpp:
- (WebCore::enqueueAttributesMutationRecord):
- (WebCore::Element::removeAttribute):
-
-2011-12-05 Dana Jansens <danakj@chromium.org>
-
- Set opaque flag for WebGLLayerChromium
- https://bugs.webkit.org/show_bug.cgi?id=73876
-
- Reviewed by James Robinson.
-
- New unit test in tests/WebGLLayerChromiumTest.cpp
-
- * platform/graphics/chromium/DrawingBufferChromium.cpp:
- (WebCore::DrawingBuffer::platformLayer):
-
-2011-12-05 Benjamin Poulain <bpoulain@apple.com>
-
- Upstream the Cursor implementation of iOS
- https://bugs.webkit.org/show_bug.cgi?id=73724
-
- Reviewed by David Kilzer.
-
- iOS does not need to support the Cursor of WebKit. For compatibility, Cursor
- is implemented as an empty class on the platform.
-
- * Configurations/WebCore.xcconfig:
- * WebCore.xcodeproj/project.pbxproj:
- * platform/Cursor.h:
- (WebCore::Cursor::Cursor):
- * platform/ios/CursorIOS.cpp: Added.
- (WebCore::cursor):
- (WebCore::pointerCursor):
- (WebCore::crossCursor):
- (WebCore::handCursor):
- (WebCore::moveCursor):
- (WebCore::iBeamCursor):
- (WebCore::waitCursor):
- (WebCore::helpCursor):
- (WebCore::eastResizeCursor):
- (WebCore::northResizeCursor):
- (WebCore::northEastResizeCursor):
- (WebCore::northWestResizeCursor):
- (WebCore::southResizeCursor):
- (WebCore::southEastResizeCursor):
- (WebCore::southWestResizeCursor):
- (WebCore::westResizeCursor):
- (WebCore::northSouthResizeCursor):
- (WebCore::eastWestResizeCursor):
- (WebCore::northEastSouthWestResizeCursor):
- (WebCore::northWestSouthEastResizeCursor):
- (WebCore::columnResizeCursor):
- (WebCore::rowResizeCursor):
- (WebCore::middlePanningCursor):
- (WebCore::eastPanningCursor):
- (WebCore::northPanningCursor):
- (WebCore::northEastPanningCursor):
- (WebCore::northWestPanningCursor):
- (WebCore::southPanningCursor):
- (WebCore::southEastPanningCursor):
- (WebCore::southWestPanningCursor):
- (WebCore::westPanningCursor):
- (WebCore::verticalTextCursor):
- (WebCore::cellCursor):
- (WebCore::contextMenuCursor):
- (WebCore::noDropCursor):
- (WebCore::notAllowedCursor):
- (WebCore::progressCursor):
- (WebCore::aliasCursor):
- (WebCore::zoomInCursor):
- (WebCore::zoomOutCursor):
- (WebCore::copyCursor):
- (WebCore::noneCursor):
- (WebCore::grabCursor):
- (WebCore::grabbingCursor):
- (WebCore::determineHotSpot):
-
-2011-12-05 Noel Gordon <noel.gordon@gmail.com>
-
- [GTK] GIF image test crashes on 32- and 64-bit Release
- https://bugs.webkit.org/show_bug.cgi?id=73812
-
- Reviewed by Adam Barth.
-
- Call resize() on the image pixel backing store after allocation to see if
- that stops the GIF image decoder animation tests crashes on GTK.
-
- No new tests, covered by exiting tests ...
- fast/backgrounds/animated-gif-as-background.html
- fast/images/dont-crash-with-null-gif-frames.html
- fast/images/gif-loop-count.html
-
- * platform/image-decoders/ImageDecoder.cpp:
- (WebCore::ImageFrame::setSize):
-
-2011-12-05 Erik Arvidsson <arv@chromium.org>
-
- Could save a lot of memory in CharacterData by not always storing a String
- https://bugs.webkit.org/show_bug.cgi?id=72404
-
- Reviewed by Ojan Vafai.
-
- When a Text node is created by the parser we check if the string is all whitespace
- and if so we put it in the AtomicString table so that all future identical whitespace
- strings can share the StringImpl.
-
- No new tests. Covered by existing tests.
-
- * html/parser/HTMLConstructionSite.cpp:
- (WebCore::HTMLNames::isAllWhitespace):
- (WebCore::HTMLConstructionSite::insertTextNode):
-
- If we do not know whether the string is all whitespace this now checks the string
- If the string is all whitespace we create an AtomicString for it.
-
- * html/parser/HTMLConstructionSite.h:
- * html/parser/HTMLTreeBuilder.cpp:
- (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeadingNonWhitespace): We never cared about the return value here.
- (WebCore::HTMLTreeBuilder::processCharacterBuffer): Pass WhitespaceMode in the case we know whether the string is all whitespace or not.
- (WebCore::HTMLTreeBuilder::defaultForInTableText): Ditto.
-
-2011-12-05 Benjamin Poulain <benjamin@webkit.org>
-
- Update KURL's copy copyASCII to avoid String::characters()
- https://bugs.webkit.org/show_bug.cgi?id=73794
-
- Reviewed by Andreas Kling.
-
- When the String is already on 8 bits, we can simply copy the
- data. In the 16 bits case, everything remains the same.
-
- * platform/KURL.cpp:
- (WebCore::copyASCII):
- (WebCore::appendASCII):
- (WebCore::KURL::init):
- (WebCore::KURL::parse):
- (WebCore::KURL::copyToBuffer):
-
-2011-12-05 Yong Li <yoli@rim.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=73683
- Implement KeyframeValueList::operator=() and KeyframeValueList::swap().
-
- Reviewed by Darin Adler.
-
- No new tests as no functional change.
-
- * platform/graphics/GraphicsLayer.h:
- (WebCore::KeyframeValueList::operator=): Added
- (WebCore::KeyframeValueList::swap): Added
-
-2011-12-05 Adrienne Walker <enne@google.com>
-
- [chromium] setNeedsCommit on non-composited host layers should trigger commit
- https://bugs.webkit.org/show_bug.cgi?id=73711
-
- Reviewed by James Robinson.
-
- Pipe non-composited content host syncs to setNeedsCommit.
-
- Since now the NonCompositedContentHost generates setNeedsCommit, don't
- call it unnecessarily, e.g. calling setBackgroundColor to the same
- color each frame should not retrigger more commits.
-
- * platform/graphics/chromium/GraphicsLayerChromium.cpp:
- (WebCore::GraphicsLayerChromium::setAnchorPoint):
- (WebCore::GraphicsLayerChromium::setTransform):
- (WebCore::GraphicsLayerChromium::setChildrenTransform):
- (WebCore::GraphicsLayerChromium::setMasksToBounds):
- (WebCore::GraphicsLayerChromium::setBackgroundColor):
- (WebCore::GraphicsLayerChromium::clearBackgroundColor):
- (WebCore::GraphicsLayerChromium::setContentsOpaque):
- (WebCore::GraphicsLayerChromium::setBackfaceVisibility):
- (WebCore::GraphicsLayerChromium::setOpacity):
- * platform/graphics/chromium/LayerChromium.cpp:
- (WebCore::LayerChromium::setNeedsCommit):
- (WebCore::LayerChromium::setAnchorPoint):
- (WebCore::LayerChromium::setAnchorPointZ):
- (WebCore::LayerChromium::setBackgroundColor):
- (WebCore::LayerChromium::setMasksToBounds):
- (WebCore::LayerChromium::setMaskLayer):
- (WebCore::LayerChromium::setOpacity):
- (WebCore::LayerChromium::setOpaque):
- (WebCore::LayerChromium::setPosition):
- (WebCore::LayerChromium::setSublayerTransform):
- (WebCore::LayerChromium::setTransform):
- (WebCore::LayerChromium::setScrollPosition):
- (WebCore::LayerChromium::setScrollable):
- (WebCore::LayerChromium::setDoubleSided):
- * platform/graphics/chromium/LayerChromium.h:
- (WebCore::LayerChromium::setReplicaLayer):
- * platform/graphics/chromium/NonCompositedContentHost.cpp:
- (WebCore::NonCompositedContentHost::notifySyncRequired):
- * platform/graphics/chromium/NonCompositedContentHost.h:
-
-2011-12-05 Tony Chang <tony@chromium.org>
-
- small refactor of RenderFlexibleBox
- https://bugs.webkit.org/show_bug.cgi?id=73854
-
- Reviewed by Darin Adler.
-
- No new tests, just a refactor.
-
- * rendering/RenderFlexibleBox.cpp:
- (WebCore::RenderFlexibleBox::isLeftToRightFlow): Inline isReverseFlow since it's only used in one place.
- (WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Rename startEdge
- to mainAxisOffset. Rename logicalTop to crossAxisOffset. Get rid of
- logicalLeft local variable since it's confusing. Move shouldFlipMainAxis
- out of the for loop to avoid computing it each iteration.
- * rendering/RenderFlexibleBox.h:
-
-2011-12-05 Florin Malita <fmalita@google.com>
-
- Heap-buffer-overflow in WebCore::HTMLTreeBuilder::processEndTag
- https://bugs.webkit.org/show_bug.cgi?id=73765
-
- Reviewed by Adam Barth.
-
- Test: fast/parser/foreign-content-crash.html
-
- Use m_tree.currentNode() instead of m_tree.currentElement() as the top node is not always an Element.
-
- * html/parser/HTMLTreeBuilder.cpp:
- (WebCore::HTMLTreeBuilder::processEndTag):
-
-2011-12-05 Stephen White <senorblanco@chromium.org>
-
- Allow the ImageBuffers used by SVG filters to be accelerated
- https://bugs.webkit.org/show_bug.cgi?id=73842
-
- Reviewed by Kenneth Russell.
-
- Regressions covered by existing SVG tests; new functionality to be
- tested by the API exposed on Internals.
-
- * page/Settings.cpp:
- (WebCore::Settings::Settings):
- * page/Settings.h:
- (WebCore::Settings::setAcceleratedFiltersEnabled):
- (WebCore::Settings::acceleratedFiltersEnabled):
- * platform/graphics/filters/FETile.cpp:
- (WebCore::FETile::platformApplySoftware):
- * platform/graphics/filters/Filter.h:
- (WebCore::Filter::Filter):
- (WebCore::Filter::renderingMode):
- (WebCore::Filter::setRenderingMode):
- * platform/graphics/filters/FilterEffect.cpp:
- (WebCore::FilterEffect::asImageBuffer):
- (WebCore::FilterEffect::createImageBufferResult):
- * platform/graphics/skia/ImageBufferSkia.cpp:
- (WebCore::ImageBuffer::platformTransformColorSpace):
- * rendering/svg/RenderSVGResourceClipper.cpp:
- (WebCore::RenderSVGResourceClipper::applyClippingToContext):
- * rendering/svg/RenderSVGResourceFilter.cpp:
- (WebCore::RenderSVGResourceFilter::applyResource):
- * rendering/svg/RenderSVGResourceMasker.cpp:
- (WebCore::RenderSVGResourceMasker::applyResource):
- * rendering/svg/RenderSVGResourcePattern.cpp:
- (WebCore::RenderSVGResourcePattern::createTileImage):
- * rendering/svg/SVGImageBufferTools.cpp:
- (WebCore::SVGImageBufferTools::createImageBuffer):
- * rendering/svg/SVGImageBufferTools.h:
- * testing/Internals.cpp:
- (WebCore::Internals::setAcceleratedFiltersEnabled):
- * testing/Internals.h:
- * testing/Internals.idl:
-
-2011-12-05 Benjamin Poulain <bpoulain@apple.com>
-
- Upstream htmlSelectMultipleItems needed for <select multiple> by iOS
- https://bugs.webkit.org/show_bug.cgi?id=73734
-
- Reviewed by David Kilzer.
-
- * platform/DefaultLocalizationStrategy.cpp:
- (WebCore::DefaultLocalizationStrategy::htmlSelectMultipleItems):
- * platform/DefaultLocalizationStrategy.h:
-
-2011-12-05 Darin Adler <darin@apple.com>
-
- Use HashMap<OwnPtr> in CrossOriginPreflightResultCache
- https://bugs.webkit.org/show_bug.cgi?id=73785
-
- Reviewed by Andreas Kling.
-
- * loader/CrossOriginPreflightResultCache.cpp:
- (WebCore::CrossOriginPreflightResultCache::appendEntry): Changed code to use set
- instead of add, since it wants to replace existing entries. Also removed leakPtr
- and removed the FIXME that documented the memory leak now fixed here.
- (WebCore::CrossOriginPreflightResultCache::canSkipPreflight): Removed unneeded
- std:: prefix here and also unneeded explicit delete call.
- (WebCore::CrossOriginPreflightResultCache::empty): Removed unneeded deleteAllValues
- call here.
-
- * loader/CrossOriginPreflightResultCache.h: Make mapped value of the
- CrossOriginPreflightResultHashMap be OwnPtr instead of raw pointer.
-
-2011-12-05 Darin Adler <darin@apple.com>
-
- Some small improvements to ContainerNode.h
- https://bugs.webkit.org/show_bug.cgi?id=73786
-
- Reviewed by Alexey Proskuryakov.
-
- * dom/ContainerNode.cpp:
- (WebCore::ContainerNode::suspendPostAttachCallbacks): Added a FIXME comment about the
- peculiar behavior of this function. Somehow the post-attach suspend state is both
- global and specific to a certain Page object. That can't be right. If it was truly
- global then this would be a static member function. If it was truly per-page, then
- the related functions could not be static.
-
- * dom/ContainerNode.h: Removed some unneeded argument names. Moved the hasChildNodes
- function up with the other basic getters. Put the other getters, childNodeCount and
- childNode, right after the basic getters. Used ASSERT_NO_EXCEPTION in all the basic
- mutation functions so they can be used in a cleaner fashion in C++ code where we have
- some reason to know an exception won't occur. Grouped all the overrides of functions
- from Node into a single paragraph and used the OVERRIDE macro on all of them. Made the
- queuePostAttachCallback and postAttachCallbacksAreSuspended functions protected.
-
- * dom/Element.h: Moved the include of ExceptionCodePlaceholder.h into ContainerNode.h.
-
- * dom/Node.cpp:
- (WebCore::Node::lazyAttach): Use hasChildNodes instead of firstChild for clarity.
- (WebCore::Node::isDescendantOf): Ditto.
-
-2011-12-05 Benjamin Poulain <benjamin@webkit.org>
-
- Get rid of KURL::KURL(ParsedURLStringTag, const char*);
- https://bugs.webkit.org/show_bug.cgi?id=73792
-
- Reviewed by Andreas Kling.
-
- In all cases where the constructor is used, the constructor
- taking a String is as effective because the string is valid and converted
- to String for m_string.
-
- This patch remove the constructor KURL::KURL(ParsedURLStringTag, const char*)
- and change the call sites that were using that constructor to build
- empty URLs.
-
- * dom/Document.cpp:
- (WebCore::Document::initSecurityContext):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::init):
- * loader/archive/cf/LegacyWebArchive.cpp:
- (WebCore::LegacyWebArchive::create):
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::createWindow):
- * platform/KURL.cpp:
- * platform/KURL.h:
- * platform/KURLGoogle.cpp:
-
-2011-12-05 Benjamin Poulain <benjamin@webkit.org>
-
- Remove methods declared but never implemented with GOOGLEURL
- https://bugs.webkit.org/show_bug.cgi?id=73795
-
- Reviewed by Adam Barth.
-
- * platform/KURL.h:
-
-2011-12-05 Darin Adler <darin@apple.com>
-
- Change CSSFontSelector to use HashMap<OwnPtr>
- https://bugs.webkit.org/show_bug.cgi?id=73781
-
- Reviewed by Dan Bernstein.
-
- * css/CSSFontSelector.cpp:
- (WebCore::CSSFontSelector::~CSSFontSelector): Removed calls to deleteAllValues.
- (WebCore::CSSFontSelector::addFontFaceRule): Updated to use OwnPtr instead of raw
- pointer for the entry in m_fontFaces and m_locallyInstalledFontFaces.
- (WebCore::CSSFontSelector::getFontData): Updated to use OwnPtr instead of raw
- pointer for the entry in m_fonts. Also removed an unneeded std:: prefix.
-
- * css/CSSFontSelector.h: Made m_fontFaces, m_locallyInstalledFontFaces, and m_fonts
- be HashMap<OwnPtr>.
-
-2011-12-05 Adam Klein <adamk@chromium.org>
-
- V8RecursionScope should call didLeaveScriptContext when recursionLevel reaches zero
- https://bugs.webkit.org/show_bug.cgi?id=73867
-
- Reviewed by Adam Barth.
-
- Moved V8RecursionScope into its own file, and moved
- V8Proxy::didLeaveScriptContext into that file, along with a static
- recursionLevel accessor, hiding the V8BindingPerIsolateData methods
- from V8Proxy.
-
- This will make it easy and less error-prone to use V8RecursionScope
- properly. I plan to make use of it in V8LazyEventListener to fix
- https://bugs.webkit.org/show_bug.cgi?id=73492.
-
- No new tests, refactoring only.
-
- * Target.pri:
- * UseV8.cmake:
- * WebCore.gypi:
- * bindings/v8/V8Binding.h:
- (WebCore::V8BindingPerIsolateData::incrementRecursionLevel): return the new recursion level.
- (WebCore::V8BindingPerIsolateData::decrementRecursionLevel): return the new recursion level.
- * bindings/v8/V8Proxy.cpp: remove didLeaveScriptContext.
- (WebCore::V8Proxy::runScript): remove explicit call to didLeaveScriptContext.
- (WebCore::V8Proxy::instrumentedCallFunction): remove explicit call to didLeaveScriptContext.
- * bindings/v8/V8Proxy.h: remove didLeaveScriptContext.
- * bindings/v8/V8RecursionScope.cpp: Added.
- (WebCore::V8RecursionScope::didLeaveScriptContext): copied from V8Proxy.cpp.
- * bindings/v8/V8RecursionScope.h: Added.
- (WebCore::V8RecursionScope::V8RecursionScope):
- (WebCore::V8RecursionScope::~V8RecursionScope):
- (WebCore::V8RecursionScope::recursionLevel):
-
-2011-12-05 Benjamin Poulain <bpoulain@apple.com>
-
- Build fix for SecurityOrigin.cpp when neither BLOB nor FILE_SYSTEM are defined
-
- Reviewed by David Kilzer.
-
- When neither BLOB nor FILE_SYSTEM are defined, the parameter is unused.
-
- * page/SecurityOrigin.cpp:
- (WebCore::shouldUseInnerURL):
-
-2011-12-05 Darin Adler <darin@apple.com>
-
- Change RuleSet to use HashMap<OwnPtr>
- https://bugs.webkit.org/show_bug.cgi?id=73783
-
- Reviewed by Andreas Kling.
-
- * css/CSSStyleSelector.cpp: Make RuleSet::AtomRuleMap use OwnPtr for the mapped values.
- (WebCore::RuleSet::addToRuleSet): Use add instead of get/set to set up a new entry in the
- map or find the old entry in the map.
-
-2011-12-05 Mario Sanchez Prada <msanchez@igalia.com>
-
- [GTK] Move emissions of AtkDocument signals down to WebCore
- https://bugs.webkit.org/show_bug.cgi?id=73750
-
- Reviewed by Chris Fleizach.
-
- Implement the needed infrastructure to allow notifying
- accessibility, in a cross-platform way, when a event related to
- the load of a document happens. Added a generic method, which will
- be called from the FrameLoader, and platform specific versions of
- it so every port has a chance to decide what to do with those
- notifications.
-
- This patch doesn't include a new test because the one testing this
- functionality is the GTK-specific unit test added along with patch
- for bug 73746: testWebkitAtkDocumentLoadingEvents.
-
- * accessibility/AXObjectCache.h:
- (WebCore::AXObjectCache::frameLoadingEventNotification): New, called
- from the FrameLoader to notify accessibility when an event happens.
- (WebCore::AXObjectCache::frameLoadingEventPlatformNotification): New,
- platform specific function to let ports decide what to do.
- * accessibility/AXObjectCache.cpp:
- (WebCore::AXObjectCache::frameLoadingEventNotification): New.
- * accessibility/chromium/AXObjectCacheChromium.cpp:
- (WebCore::AXObjectCache::frameLoadingEventPlatformNotification): Dummy
- implementation of the platform specific function for chromium.
- * accessibility/gtk/AXObjectCacheAtk.cpp:
- (WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
- * accessibility/mac/AXObjectCacheMac.mm:
- (WebCore::AXObjectCache::frameLoadingEventPlatformNotification): Dummy
- implementation of the platform specific function for the Mac.
- * accessibility/win/AXObjectCacheWin.cpp:
- (WebCore::AXObjectCache::frameLoadingEventPlatformNotification): Dummy
- implementation of the platform specific function for Windows.
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::prepareForLoadStart): Notify accessibility
- by calling the new frameLoadingEventNotification() function.
- (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto.
-
-2011-12-05 Benjamin Poulain <benjamin@webkit.org>
-
- Update String::containsOnlyASCII() to handle 8 bits strings
- https://bugs.webkit.org/show_bug.cgi?id=73799
-
- Reviewed by Darin Adler.
-
- When possible, change the call sites from charactersAreAllASCII()
- to the optimized version String::containsOnlyASCII().
-
- * platform/KURL.cpp:
- (WebCore::KURL::init):
- * platform/cf/BinaryPropertyList.cpp:
- (WebCore::BinaryPropertyListPlan::writeStringObject):
- * platform/graphics/chromium/FontCacheChromiumWin.cpp:
- (WebCore::FontCodepage::if):
-
-2011-12-01 Vangelis Kokkevis <vangelis@chromium.org>
-
- [chromium] Use ANGLE's texture_usage and texture_storage extensions when allocating compositor textures
- https://bugs.webkit.org/show_bug.cgi?id=73621
-
- When the extensions are available, compositor textures are allocated via
- glTexStorage2DEXT instead of glTexImage2D to eliminate creation of unnecessary
- mip levels on the service side. In addition, the GL_FRAMEBUFFER_ATTACHMENT_ANGLE
- is specified for all textures used by RenderSurfaces to eliminate the need for
- a system memory bitmap allocation.
-
- Reviewed by Kenneth Russell.
-
- * platform/graphics/chromium/Extensions3DChromium.h:
- * platform/graphics/chromium/LayerRendererChromium.cpp:
- (WebCore::LayerRendererChromium::initialize):
- (WebCore::LayerRendererChromium::initializeSharedObjects):
- * platform/graphics/chromium/TrackingTextureAllocator.cpp:
- (WebCore::TrackingTextureAllocator::TrackingTextureAllocator):
- (WebCore::textureToStorageFormat):
- (WebCore::isTextureFormatSupportedForStorage):
- (WebCore::TrackingTextureAllocator::createTexture):
- * platform/graphics/chromium/TrackingTextureAllocator.h:
- (WebCore::TrackingTextureAllocator::setTextureUsageHint):
- (WebCore::TrackingTextureAllocator::setUseTextureStorageExt):
- * platform/graphics/chromium/cc/CCLayerTreeHost.h:
- (WebCore::LayerRendererCapabilities::LayerRendererCapabilities):
-
-2011-12-05 Chris Fleizach <cfleizach@apple.com>
-
- AX: aria-hidden doesn't work on iframe elements
- https://bugs.webkit.org/show_bug.cgi?id=73857
-
- Reviewed by Darin Adler.
-
- Test: platform/mac/accessibility/iframe-aria-hidden.html
-
- * accessibility/AccessibilityRenderObject.cpp:
- (WebCore::AccessibilityRenderObject::addAttachmentChildren):
- (WebCore::AccessibilityRenderObject::addChildren):
- * accessibility/AccessibilityRenderObject.h:
- * accessibility/AccessibilityScrollView.cpp:
- (WebCore::AccessibilityScrollView::accessibilityIsIgnored):
- (WebCore::AccessibilityScrollView::addChildren):
- * accessibility/AccessibilityScrollView.h:
-
-2011-12-05 Chris Fleizach <cfleizach@apple.com>
-
- AX: web search mechanism does not work with frames
- https://bugs.webkit.org/show_bug.cgi?id=73836
-
- Reviewed by Beth Dakin.
-
- This allows searching for, and within, frames for elements using the accessibility
- search mechanism.
-
- Test: platform/mac/accessibility/search-with-frames.html
-
- * accessibility/AccessibilityObject.cpp:
- (WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
- (WebCore::appendAccessibilityObject):
- (WebCore::appendChildrenToArray):
-
-2011-12-05 Anders Carlsson <andersca@apple.com>
-
- Make LayerFlushSchedulerClient::flushLayers indicate whether the flush was successful or not
- https://bugs.webkit.org/show_bug.cgi?id=73862
-
- Reviewed by Andy Estes.
-
- Change LayerFlushSchedulerClient::flushLayers to return a boolean. If it returns true, the flush was
- successful and the run loop observer will be invalidated.
-
- * platform/graphics/ca/LayerFlushScheduler.h:
- * platform/graphics/ca/LayerFlushSchedulerClient.h:
- * platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:
- (WebCore::LayerFlushScheduler::runLoopObserverCallback):
-
-2011-12-05 Dana Jansens <danakj@chromium.org>
-
- [chromium] Set opaque flag for ImageLayerChromium
- https://bugs.webkit.org/show_bug.cgi?id=72964
-
- Reviewed by James Robinson.
-
- New unit test in tests/ImageLayerChromiumTest.cpp.
-
- * platform/graphics/chromium/GraphicsLayerChromium.cpp:
- (WebCore::GraphicsLayerChromium::setContentsToImage):
- * platform/graphics/chromium/GraphicsLayerChromium.h:
- (WebCore::GraphicsLayerChromium::contentsLayer):
- * platform/graphics/chromium/ImageLayerChromium.cpp:
- (WebCore::ImageLayerChromium::setContents):
-
-2011-12-05 Julien Chaffraix <jchaffraix@webkit.org>
-
- TD width in precentage doesn't work.
- https://bugs.webkit.org/show_bug.cgi?id=34758
-
- Reviewed by David Hyatt.
-
- Test: fast/table/colspan-with-all-percent-cells.html
-
- * rendering/AutoTableLayout.cpp:
- (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
- In the case where all our columns have percent lengths, split the colspan
- logical width using the percentages from the lengths. This should be properly
- handled by the massive 'else' case but it is not and I did not feel like refactor
- that due to massive compatibility issues that would arise.
-
-2011-12-05 Chris Fleizach <cfleizach@apple.com>
-
- platform/mac/accessibility/search-when-element-starts-in-table.html is failing
- https://bugs.webkit.org/show_bug.cgi?id=73751
-
- When encountering a table, the rows() and not the cells() should be queried (otherwise
- we can end up finding the element we started with).
-
- When searching in reverse, we also need to account for searching elements within the
- parent hierarchy. because technically it is "behind" the start element.
-
- Reviewed by Darin Adler.
-
- * accessibility/AccessibilityObject.cpp:
- (WebCore::appendChildrenToArray):
- (WebCore::AccessibilityObject::objectMatchesSearchCriteriaWithResultLimit):
- (WebCore::AccessibilityObject::findMatchingObjects):
- * accessibility/AccessibilityObject.h:
-
-2011-12-02 Jer Noble <jer.noble@apple.com>
-
- <video> elements should disable the system and display sleep when playing on OS X.
- https://bugs.webkit.org/show_bug.cgi?id=73730
- <rdar://problem/9502155>
-
- Reviewed by Alexey Proskuryakov.
-
- No new tests; platform specific system behavior only.
-
- Create a new DisplaySleepDisabler object when the playback rate becomes non-zero, and destroy
- that object when the playback rate drops back to zero.
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::mediaPlayerRateChanged):
- * html/HTMLMediaElement.h:
-
-2011-12-05 Peter Beverloo <peter@chromium.org>
-
- [Chromium] Add Android keycodes and build Linux clipboard/filesystem files.
- https://bugs.webkit.org/show_bug.cgi?id=73672
-
- Add the KeyCodeConversionAndroid.cpp file, which is a partial re-land
- of an older file from the Android port:
- http://trac.webkit.org/browser/trunk/WebCore/platform/android/KeyEventAndroid.cpp?rev=56704
-
- Add IconChromiumAndroid.cpp which nullifies the rendering of icons in
- file upload boxes, which is not something we want to support now. Also
- include ClipboardChromiumLinux.cpp and FileSystemChromiumLinux.cpp
- as their functionality can be re-used for Android.
-
- Reviewed by Adam Barth.
-
- * WebCore.gyp/WebCore.gyp:
- * WebCore.gypi:
- * platform/chromium/KeyCodeConversionAndroid.cpp: Added.
- (WebCore::windowsKeyCodeForKeyEvent):
- * platform/graphics/chromium/IconChromiumAndroid.cpp: Added.
- (WebCore::Icon::Icon):
- (WebCore::Icon::~Icon):
- (WebCore::Icon::paint):
-
-2011-12-05 Steve Falkenburg <sfalken@apple.com>
-
- Reviewed by Sam Weinig.
-
- On Windows, filenames not properly preserved when copied into a file list exposed by Event.dataTransfer
- https://bugs.webkit.org/show_bug.cgi?id=73841
- <rdar://problem/10521879>
-
- No test since repro case involves dropping a file onto the WebView.
-
- Calling characters() explicitly causes a non-terminated string buffer to get passed back
- to the String() constructor that expects a terminated buffer. The characters() call isn't
- necessary at all, since we have a String and the method we're calling expects a String.
-
- * platform/win/ClipboardWin.cpp:
- (WebCore::ClipboardWin::files): Remove characters() since it doesn't null terminate.
-
-2011-12-05 Timothy Hatcher <timothy@apple.com>
-
- Keep both InspectorBackend.js and InspectorBackendStub.js in Release builds after
- they have been combined into inspector.js.
-
- The InspectorBackend.js file split out of the generated InspectorBackendStub.js
- in r101670, and both files are needed to be useful.
-
- https://webkit.org/b/73839
-
- Reviewed by Joseph Pecoraro and Brian Weinstein.
-
- * WebCore.xcodeproj/project.pbxproj: Pass -not -name "InspectorBackend*.js" to find
- instead of -not -name InspectorBackendStub.js.
-
-2011-12-05 Mikhail Naganov <mnaganov@chromium.org>
-
- Web Inspector: [Chromium] Heap profiler should designate weak references.
- https://bugs.webkit.org/show_bug.cgi?id=69948
-
- Weak references are now ignored when tracing paths to GC roots.
-
- Reviewed by Yury Semikhatsky.
-
- * inspector/front-end/HeapSnapshot.js:
- (WebInspector.HeapSnapshotEdge.prototype.get isWeak):
- (WebInspector.HeapSnapshotEdge.prototype.toString):
- (WebInspector.HeapSnapshotEdge.prototype.get _hasStringName):
- (WebInspector.HeapSnapshotRetainerEdge.prototype.get isWeak):
- (WebInspector.HeapSnapshot.prototype._init):
- (WebInspector.HeapSnapshotPathFinder.prototype._fillRootChildren):
- (WebInspector.HeapSnapshotPathFinder.prototype._skipEdge):
-
-2011-12-05 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r102004.
- http://trac.webkit.org/changeset/102004
- https://bugs.webkit.org/show_bug.cgi?id=73835
-
- Breaks qt minimal release compilation (Requested by vsevik on
- #webkit).
-
- * inspector/CodeGeneratorInspector.py:
- (Capitalizer.upper_camel_case_to_lower):
- (RawTypes.get):
- (RawTypes.String.get_c_param_type):
- (RawTypes.Object.get_c_param_type):
- (RawTypes.Object):
- (ParamType):
- (TypeData.__init__):
- (TypeData.get_raw_type):
- (TypeMap.__init__):
- (InspectorFrontend_h):
- (InspectorArray):
- (InspectorObject):
- (String):
- (InspectorBackendDispatcher_h):
- (Generator.process_command):
- * inspector/InspectorValues.h:
-
-2011-12-05 Peter Rybin <peter.rybin@gmail.com>
-
- Web Inspector: [protocol] generate C++ classes for protocol JSON named types
- https://bugs.webkit.org/show_bug.cgi?id=72835
-
- Reviewed by Yury Semikhatsky.
-
- Extends python generator functionality.
- Makes constructor in InspectorObject public.
-
- * inspector/CodeGeneratorInspector.py:
- * inspector/InspectorValues.h:
-
-2011-12-05 Pavel Podivilov <podivilov@chromium.org>
-
- Web Inspector: fix fronted compilation.
- https://bugs.webkit.org/show_bug.cgi?id=73831
-
- Reviewed by Yury Semikhatsky.
-
- * inspector/front-end/CompilerSourceMapping.js:
- (WebInspector.ClosureCompilerSourceMappingPayload):
-
-2011-12-05 Eric Carlson <eric.carlson@apple.com>
-
- Out-of-band text tracks may only load from same origin as the media element's Document's origin
- https://bugs.webkit.org/show_bug.cgi?id=73184
-
- Reviewed by Sam Weinig.
-
- Test: http/tests/security/text-track-crossorigin.html
-
- * html/HTMLTrackElement.cpp:
- (WebCore::urlForLogging): Debug-only function for logging urls.
- (WebCore::HTMLTrackElement::scheduleLoad): Call canLoadUrl() before passing control off to
- the Track.
- (WebCore::HTMLTrackElement::canLoadUrl): Don't ask HTMLMediaElement to validate the url, the
- requirements for <track> are different from <video>.
- (WebCore::HTMLTrackElement::didCompleteLoad): Change bool param to enum.
- (WebCore::HTMLTrackElement::mediaElementCrossOriginAttribute): New, return parent 'crossorigin'
- attribute value.
- * html/HTMLTrackElement.h:
-
- * html/LoadableTextTrack.cpp:
- (WebCore::LoadableTextTrack::scheduleLoad): Add comments from the spec.
- (WebCore::LoadableTextTrack::loadTimerFired): Always cancel pending loads. Let the caller know
- if the loader refuses the url immediately.
- (WebCore::LoadableTextTrack::cueLoadingStarted): The <track> deals with readyState.
- (WebCore::LoadableTextTrack::cueLoadingCompleted): HTMLTrackElement::didCompleteLoad takes
- an enum, not a bool.
-
- * loader/TextTrackLoader.cpp:
- (WebCore::TextTrackLoader::corsPolicyPreventedLoad): New, log the error and set m_state.
- (WebCore::TextTrackLoader::notifyFinished): Check for CORS failure.
- (WebCore::TextTrackLoader::load): Take media element cross-origin attribute as a param so we
- can make the correct checks.
- * loader/TextTrackLoader.h:
-
-2011-12-05 Roland Steiner <rolandsteiner@chromium.org>
-
- "Raw" pseudo selectors don't match if immediately after a child or descendant combinator
- https://bugs.webkit.org/show_bug.cgi?id=72933
-
- Remove shortcut that prevents universal selectors from being created before shadow pseudo-elements.
-
- Reviewed by Antti Koivisto.
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::updateSpecifiersWithElementName):
-
-2011-12-05 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r101983.
- http://trac.webkit.org/changeset/101983
- https://bugs.webkit.org/show_bug.cgi?id=73827
-
- It broke all tests on GTK and on Qt in debug mode (Requested
- by Ossy on #webkit).
-
- * dom/Document.h:
- (WebCore::Node::Node):
- * dom/Node.cpp:
- (WebCore::Node::~Node):
- * dom/Node.h:
- (WebCore::Node::inDocument):
-
-2011-12-05 Roland Steiner <rolandsteiner@chromium.org>
-
- <style scoped>: Add 'scoped' attribute
- https://bugs.webkit.org/show_bug.cgi?id=67718
-
- Add 'scoped' attribute to IDL and attribute list,
- implement and test setting/resetting of the attribute.
-
- Reviewed by Antti Koivisto.
-
- Test: fast/css/style-scoped/basic-attribute.html
-
- * html/HTMLAttributeNames.in:
- * html/HTMLStyleElement.cpp:
- (WebCore::HTMLStyleElement::scoped):
- (WebCore::HTMLStyleElement::setScoped):
- (WebCore::HTMLStyleElement::scopingElement):
- * html/HTMLStyleElement.h:
- * html/HTMLStyleElement.idl:
-
-2011-12-05 Hajime Morrita <morrita@chromium.org>
-
- [Refactoring] Accessing Node::m_document should be minimized.
- https://bugs.webkit.org/show_bug.cgi?id=73800
-
- Reviewed by Kent Tamura.
-
- No new tests. No behavioral change.
-
- Replaced m_document reference with the document() accessor
- or temporaril variables. This is a preparation for using
- m_document space to point a shadow root pointer.
-
- * dom/Document.h:
- (WebCore::Node::Node):
- * dom/Node.cpp:
- (WebCore::Node::~Node):
- * dom/Node.h:
- (WebCore::Node::inDocument):
-
-2011-12-05 Shinya Kawanaka <shinyak@google.com>
-
- Asynchronous SpellChecker should consider multiple requests.
- https://bugs.webkit.org/show_bug.cgi?id=72939
-
- Reviewed by Hajime Morita.
-
- Now SpellChecker saves a request when it is processing the previous spellcheck request.
- If there is a request having the same root editable element, the older request is replaced by newer request
-
- Test: editing/spelling/spellcheck-queue.html
-
- * editing/SpellChecker.cpp:
- (WebCore::SpellChecker::SpellCheckRequest::SpellCheckRequest):
- A structure to have spell check request.
- (WebCore::SpellChecker::SpellCheckRequest::sequence):
- (WebCore::SpellChecker::SpellCheckRequest::range):
- (WebCore::SpellChecker::SpellCheckRequest::text):
- (WebCore::SpellChecker::SpellCheckRequest::mask):
- (WebCore::SpellChecker::SpellCheckRequest::rootEditableElement):
- (WebCore::SpellChecker::SpellChecker):
- (WebCore::SpellChecker::createRequest):
- (WebCore::SpellChecker::timerFiredToProcessQueuedRequest):
- When timer is fired, queued request is processed if any.
- (WebCore::SpellChecker::canCheckAsynchronously):
- (WebCore::SpellChecker::requestCheckingFor):
- When the spellchecker is processing another request, the latest request is queued.
- (WebCore::SpellChecker::invokeRequest):
- (WebCore::SpellChecker::enqueueRequest):
- Enqueues a request. If there is an older request whose root editable element is the same as the request,
- it will be replaced.
- (WebCore::SpellChecker::didCheck):
- * editing/SpellChecker.h:
-
-2011-12-05 Eric Carlson <eric.carlson@apple.com>
-
- WebCore part of: Add WebKit preferences for text track settings
- https://bugs.webkit.org/show_bug.cgi?id=73721
-
- Reviewed by John Sullivan.
-
- No new tests yet, still nothing to test.
-
- * page/Settings.cpp:
- (WebCore::Settings::setShouldDisplaySubtitles): Move the setters to the .cpp file so they
- aren't inlined.
- (WebCore::Settings::setShouldDisplayCaptions): Ditto.
- (WebCore::Settings::setShouldDisplayTextDescriptions): Ditto.
- * page/Settings.h:
-
-2011-12-05 Noel Gordon <noel.gordon@gmail.com>
-
- ImageDecoder setSize() should check for backing store allocation failure
- https://bugs.webkit.org/show_bug.cgi?id=72864
-
- Reviewed by Adam Barth.
-
- The backing store of a decoded image is a Vector<PixelData> on the affected
- ports. And Vector<> provides a resize capacity member that returns false if
- memory allocation fails.
-
- setSize() should be called once only during an image decode - add an ASSERT
- for that. Resize the backing store capacity to the requested image size and
- return false if memory allocation fails.
-
- ImageDecoder::isOverSize(width, height) is called to check that the decoded
- width and height won't overflow 'width x height x sizeof(PixelData)' before
- calls to setSize(). Refer to http://webkit.org/b/48634
-
- No new tests. Covered by fast/images/size-failure.html
-
- * platform/image-decoders/ImageDecoder.cpp:
- (WebCore::ImageFrame::setSize):
-
-2011-12-04 Andreas Kling <kling@webkit.org>
-
- CSSStyleSheet can't be reparented, enforce this at compile time.
- <http://webkit.org/b/73793>
-
- Reviewed by Benjamin Poulain.
-
- * css/StyleSheet.h:
- (WebCore::StyleSheet::clearOwnerRule):
-
- Changed setParentRule(CSSImportRule*) to clearOwnerRule() to document and
- enforce the fact that style sheets should never be reparented after creation.
-
- (WebCore::StyleSheet::ownerRule):
-
- Renamed parentRule() to ownerRule() to match the CSSOM name.
-
- (WebCore::StyleSheet::ownerNode):
- (WebCore::StyleSheet::clearOwnerNode):
-
- Also renamed StyleSheet::m_parentNode to m_ownerNode to match its accessors.
-
- * css/CSSStyleSheet.h:
-
- Removed ownerRule() as we now inherit it from StyleSheet.
-
- * bindings/js/JSDOMBinding.h:
- (WebCore::root):
- * css/CSSImportRule.cpp:
- (WebCore::CSSImportRule::~CSSImportRule):
- (WebCore::CSSImportRule::setCSSStyleSheet):
- * css/StyleSheet.cpp:
- (WebCore::StyleSheet::StyleSheet):
- (WebCore::StyleSheet::parentStyleSheet):
- (WebCore::StyleSheet::baseURL):
- * inspector/InspectorStyleSheet.cpp:
- (WebCore::fillMediaListChain):
-
- Update call sites to use the new names.
-
-2011-12-04 Andreas Kling <kling@webkit.org>
-
- border-width: initial and border-color: initial cannot be removed via CSSOM.
- <http://webkit.org/b/68551>
-
- Reviewed by Darin Adler.
-
- Test: fast/css/cssom-remove-shorthand-property.html
-
- When asked to remove a shorthand property, we should toss out both the
- sub-properties of that shorthand as well as the shorthand itself, should the
- declaration contain it. The latter part was missing in our implementation.
-
- * css/CSSMutableStyleDeclaration.h:
- * css/CSSMutableStyleDeclaration.cpp:
- (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
- (WebCore::CSSMutableStyleDeclaration::removeShorthandProperty):
-
- Changed to return true only if something was actually removed.
-
-2011-12-04 Ryosuke Niwa <rniwa@webkit.org>
-
- HIERARCHY_REQUEST_ERR check in checkAcceptChild should be optimized for newChild without children
- https://bugs.webkit.org/show_bug.cgi?id=73737
-
- Reviewed by Darin Adler.
-
- It turned out that 50-70% of nodes inserted by DOM APIs such as insertBefore and appendChild
- don't have any descendent nodes. Optimize isDescendantOf which is used by checkAcceptChild for this case.
- On a test case attached on the bug, we see a 40% improvement.
-
- Also optimize for cases where either new child or new parent but not both are in document as suggested
- by Erik Arvidsson. This appears to happen about 40-70% of the time, and the symmetric difference between
- the two cases is about 50% so it's worth implementing both optimizations.
-
- Unfortunately no tests because we still have a O(n) algorithm somewhere.
-
- * dom/Node.cpp:
- (WebCore::Node::isDescendantOf):
- (WebCore::Node::contains):
-
-2011-12-04 Andreas Kling <kling@webkit.org>
-
- CSSValuePool: Inline trivial getters.
- <http://webkit.org/b/73763>
-
- Reviewed by Anders Carlsson.
-
- * css/CSSValuePool.cpp:
- * css/CSSValuePool.h:
- (WebCore::CSSValuePool::createInheritedValue): Inlined.
- (WebCore::CSSValuePool::createImplicitInitialValue): Ditto.
- (WebCore::CSSValuePool::createExplicitInitialValue): Ditto.
-
-2011-12-03 Noel Gordon <noel.gordon@gmail.com>
-
- Fix WebPImageDecoder decoder leak.
- https://bugs.webkit.org/show_bug.cgi?id=73756
-
- Reviewed by Andreas Kling.
-
- Delete the m_decoder member in the destructor if needed with WebPIDelete.
-
- No new tests, it's valgrind territory.
-
- * platform/image-decoders/webp/WEBPImageDecoder.cpp:
- (WebCore::WEBPImageDecoder::~WEBPImageDecoder):
-
-2011-12-03 Andreas Kling <kling@webkit.org>
-
- CSSStyleSheet: Parent rule can only ever be @import, enforce this at compile time.
- <http://webkit.org/b/73725>
-
- Reviewed by Darin Adler.
-
- Made StyleSheet::m_parentRule a CSSImportRule* rather than a CSSRule*
- and updated getters, setters and constructors accordingly.
-
- There is no change in behavior, this simply enforces the status quo.
-
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSDOMBinding.h:
- * bindings/scripts/CodeGeneratorV8.pm:
- (AddIncludesForType):
- * css/CSSStyleSheet.cpp:
- (WebCore::CSSStyleSheet::CSSStyleSheet):
- * css/CSSStyleSheet.h:
- (WebCore::CSSStyleSheet::create):
- (WebCore::CSSStyleSheet::ownerRule):
- * css/StyleSheet.cpp:
- (WebCore::StyleSheet::StyleSheet):
- * css/StyleSheet.h:
- (WebCore::StyleSheet::parentRule):
- (WebCore::StyleSheet::setParentRule):
-
-2011-12-03 Andreas Kling <kling@webkit.org>
-
- Unreviewed, revert accidental change from r101932.
-
- * bindings/scripts/CodeGeneratorV8.pm:
- (AddIncludesForType):
-
-2011-12-03 Mary Wu <mary.wu@torchmobile.com.cn>
-
- Upstream 4 files into WebCore/platform/blackberry
- https://bugs.webkit.org/show_bug.cgi?id=73614
-
- Reviewed by Eric Seidel.
-
- * platform/blackberry/CursorBlackBerry.cpp: Added.
- (WebCore::AllCursors::AllCursors):
- (WebCore::getCursor):
- (WebCore::Cursor::Cursor):
- (WebCore::Cursor::~Cursor):
- (WebCore::Cursor::operator=):
- (WebCore::aliasCursor):
- (WebCore::cellCursor):
- (WebCore::columnResizeCursor):
- (WebCore::contextMenuCursor):
- (WebCore::copyCursor):
- (WebCore::crossCursor):
- (WebCore::eastResizeCursor):
- (WebCore::eastWestResizeCursor):
- (WebCore::grabbingCursor):
- (WebCore::grabCursor):
- (WebCore::handCursor):
- (WebCore::helpCursor):
- (WebCore::iBeamCursor):
- (WebCore::moveCursor):
- (WebCore::noDropCursor):
- (WebCore::noneCursor):
- (WebCore::northEastResizeCursor):
- (WebCore::northEastSouthWestResizeCursor):
- (WebCore::northResizeCursor):
- (WebCore::northSouthResizeCursor):
- (WebCore::northWestResizeCursor):
- (WebCore::northWestSouthEastResizeCursor):
- (WebCore::notAllowedCursor):
- (WebCore::pointerCursor):
- (WebCore::progressCursor):
- (WebCore::rowResizeCursor):
- (WebCore::southEastResizeCursor):
- (WebCore::southResizeCursor):
- (WebCore::southWestResizeCursor):
- (WebCore::verticalTextCursor):
- (WebCore::waitCursor):
- (WebCore::westResizeCursor):
- (WebCore::zoomInCursor):
- (WebCore::zoomOutCursor):
- (WebCore::middlePanningCursor):
- (WebCore::eastPanningCursor):
- (WebCore::northPanningCursor):
- (WebCore::northEastPanningCursor):
- (WebCore::northWestPanningCursor):
- (WebCore::southPanningCursor):
- (WebCore::southEastPanningCursor):
- (WebCore::southWestPanningCursor):
- (WebCore::westPanningCursor):
- * platform/blackberry/DragDataBlackBerry.cpp: Added.
- (WebCore::DragData::canSmartReplace):
- (WebCore::DragData::containsColor):
- (WebCore::DragData::containsCompatibleContent):
- (WebCore::DragData::containsFiles):
- (WebCore::DragData::containsPlainText):
- (WebCore::DragData::containsURL):
- (WebCore::DragData::asFilenames):
- (WebCore::DragData::asColor):
- (WebCore::DragData::asPlainText):
- (WebCore::DragData::asURL):
- (WebCore::DragData::asFragment):
- * platform/blackberry/DragImageBlackBerry.cpp: Added.
- (WebCore::createDragImageFromImage):
- (WebCore::createDragImageIconForCachedImage):
- (WebCore::deleteDragImage):
- (WebCore::dissolveDragImageToFraction):
- (WebCore::scaleDragImage):
- (WebCore::dragImageSize):
- * platform/blackberry/EventLoopBlackBerry.cpp: Added.
- (WebCore::EventLoop::platformInit):
- (WebCore::EventLoop::cycle):
-
-2011-12-03 Andreas Kling <kling@webkit.org>
-
- Cache CSSInitialValue instances per-document.
- <http://webkit.org/b/73745>
-
- Reviewed by Oliver Hunt.
-
- Test: http/tests/security/cross-origin-css-primitive.html
-
- Have CSSValuePool manage the caching of CSSInitialValue objects.
-
- * css/CSSInitialValue.h:
- (WebCore::CSSInitialValue::createExplicit):
- (WebCore::CSSInitialValue::createImplicit):
- (WebCore::CSSInitialValue::CSSInitialValue):
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseValue):
- (WebCore::CSSParser::parseFillShorthand):
- (WebCore::CSSParser::parseAnimationShorthand):
- (WebCore::CSSParser::parseTransitionShorthand):
- (WebCore::CSSParser::parseShorthand):
- * css/CSSValuePool.cpp:
- (WebCore::CSSValuePool::CSSValuePool):
- (WebCore::CSSValuePool::createImplicitInitialValue):
- (WebCore::CSSValuePool::createExplicitInitialValue):
- * css/CSSValuePool.h:
-
-2011-12-03 Andreas Kling <kling@webkit.org>
-
- Keep CSSInheritedValue in the CSS value pool.
- <http://webkit.org/b/73747>
-
- Reviewed by Antti Koivisto.
-
- We only need one CSSInheritedValue instance per document, so cache it
- in CSSValuePool and have the parser create it through there.
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseValue):
- * css/CSSValuePool.cpp:
- (WebCore::CSSValuePool::CSSValuePool):
- (WebCore::CSSValuePool::createInheritedValue):
- * css/CSSValuePool.h:
-
-2011-12-03 Andreas Kling <kling@webkit.org>
-
- Rename CSSPrimitiveValueCache to CSSValuePool.
- <http://webkit.org/b/73742>
-
- Reviewed by Antti Koivisto.
-
- CSSPrimitiveValueCache -> CSSValuePool
- Document::primitiveValueCache() -> Document::cssValuePool()
-
- This is in preparation for sharing more than just primitive values.
-
- * CMakeLists.txt:
- * GNUmakefile.list.am:
- * Target.pri:
- * WebCore.gypi:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/scripts/CodeGeneratorV8.pm:
- (AddIncludesForType):
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::valueForNinePieceImageSlice):
- (WebCore::valueForNinePieceImageQuad):
- (WebCore::valueForNinePieceImageRepeat):
- (WebCore::valueForNinePieceImage):
- (WebCore::zoomAdjustedPixelValue):
- (WebCore::zoomAdjustedNumberValue):
- (WebCore::zoomAdjustedPixelValueForLength):
- (WebCore::valueForReflection):
- (WebCore::getPositionOffsetValue):
- (WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):
- (WebCore::getBorderRadiusCornerValue):
- (WebCore::computedTransform):
- (WebCore::CSSComputedStyleDeclaration::valueForFilter):
- (WebCore::valueForGridTrackList):
- (WebCore::getDelayValue):
- (WebCore::getDurationValue):
- (WebCore::createLineBoxContainValue):
- (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
- (WebCore::CSSComputedStyleDeclaration::valueForShadow):
- (WebCore::valueForFamily):
- (WebCore::renderTextDecorationFlagsToCSSValue):
- (WebCore::fillRepeatToCSSValue):
- (WebCore::fillSizeToCSSValue):
- (WebCore::contentToCSSValue):
- (WebCore::counterToCSSValue):
- (WebCore::fontFamilyFromStyle):
- (WebCore::lineHeightFromStyle):
- (WebCore::fontSizeFromStyle):
- (WebCore::fontStyleFromStyle):
- (WebCore::fontVariantFromStyle):
- (WebCore::fontWeightFromStyle):
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- * css/CSSParser.cpp:
- (WebCore::parseColorValue):
- (WebCore::parseSimpleLengthValue):
- (WebCore::CSSParser::setStyleSheet):
- (WebCore::CSSParser::createPrimitiveNumericValue):
- (WebCore::CSSParser::createPrimitiveStringValue):
- (WebCore::CSSParser::parseValidPrimitive):
- (WebCore::CSSParser::parseValue):
- (WebCore::parseBackgroundClip):
- (WebCore::CSSParser::parseFillShorthand):
- (WebCore::CSSParser::parsePage):
- (WebCore::CSSParser::parseSizeParameter):
- (WebCore::CSSParser::parseContent):
- (WebCore::CSSParser::parseAttr):
- (WebCore::CSSParser::parseBackgroundColor):
- (WebCore::CSSParser::parseFillPositionX):
- (WebCore::CSSParser::parseFillPositionY):
- (WebCore::CSSParser::parseFillPositionComponent):
- (WebCore::CSSParser::parseFillPosition):
- (WebCore::CSSParser::parseFillRepeat):
- (WebCore::CSSParser::parseFillSize):
- (WebCore::CSSParser::parseFillProperty):
- (WebCore::CSSParser::parseAnimationDirection):
- (WebCore::CSSParser::parseAnimationFillMode):
- (WebCore::CSSParser::parseAnimationIterationCount):
- (WebCore::CSSParser::parseAnimationName):
- (WebCore::CSSParser::parseAnimationPlayState):
- (WebCore::CSSParser::parseAnimationProperty):
- (WebCore::CSSParser::parseAnimationTimingFunction):
- (WebCore::CSSParser::parseGridTrackList):
- (WebCore::CSSParser::parseDashboardRegions):
- (WebCore::CSSParser::parseCounterContent):
- (WebCore::CSSParser::parseShape):
- (WebCore::CSSParser::parseWrapShape):
- (WebCore::CSSParser::parseFont):
- (WebCore::CSSParser::parseFontFamily):
- (WebCore::CSSParser::parseFontStyle):
- (WebCore::CSSParser::parseFontVariant):
- (WebCore::CSSParser::parseFontWeight):
- (WebCore::CSSParser::parseColor):
- (WebCore::ShadowParseContext::ShadowParseContext):
- (WebCore::ShadowParseContext::commitLength):
- (WebCore::ShadowParseContext::commitStyle):
- (WebCore::CSSParser::parseShadow):
- (WebCore::CSSParser::parseReflect):
- (WebCore::CSSParser::parseFlex):
- (WebCore::BorderImageParseContext::BorderImageParseContext):
- (WebCore::CSSParser::parseBorderImage):
- (WebCore::CSSParser::parseBorderImageRepeat):
- (WebCore::BorderImageSliceParseContext::BorderImageSliceParseContext):
- (WebCore::BorderImageSliceParseContext::commitNumber):
- (WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
- (WebCore::CSSParser::parseBorderImageSlice):
- (WebCore::BorderImageQuadParseContext::BorderImageQuadParseContext):
- (WebCore::BorderImageQuadParseContext::commitNumber):
- (WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
- (WebCore::CSSParser::parseBorderImageQuad):
- (WebCore::CSSParser::parseBorderRadius):
- (WebCore::CSSParser::parseAspectRatio):
- (WebCore::CSSParser::parseCounter):
- (WebCore::parseDeprecatedGradientPoint):
- (WebCore::parseDeprecatedGradientColorStop):
- (WebCore::CSSParser::parseDeprecatedGradient):
- (WebCore::valueFromSideKeyword):
- (WebCore::parseGradientColorOrKeyword):
- (WebCore::CSSParser::parseLinearGradient):
- (WebCore::CSSParser::parseRadialGradient):
- (WebCore::CSSParser::parseCrossfade):
- (WebCore::CSSParser::parseCustomFilter):
- (WebCore::CSSParser::parseFilter):
- (WebCore::CSSParser::parseFlowThread):
- (WebCore::CSSParser::parseRegionThread):
- (WebCore::CSSParser::parseTextEmphasisStyle):
- (WebCore::CSSParser::parseFontFeatureSettings):
- * css/CSSParser.h:
- (WebCore::CSSParser::cssValuePool):
- * css/CSSValuePool.cpp: Renamed from Source/WebCore/css/CSSPrimitiveValueCache.cpp.
- (WebCore::CSSValuePool::CSSValuePool):
- (WebCore::CSSValuePool::~CSSValuePool):
- (WebCore::CSSValuePool::createIdentifierValue):
- (WebCore::CSSValuePool::createColorValue):
- (WebCore::CSSValuePool::createValue):
- * css/CSSValuePool.h: Renamed from Source/WebCore/css/CSSPrimitiveValueCache.h.
- (WebCore::CSSValuePool::create):
- (WebCore::CSSValuePool::createValue):
- * css/mediaControlsGtk.css:
- (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
- * dom/Document.cpp:
- (WebCore::Document::cssValuePool):
- * dom/Document.h:
-
-2011-12-03 Andreas Kling <kling@webkit.org>
-
- Shrink CSSValueList.
- <http://webkit.org/b/73732>
-
- Reviewed by Antti Koivisto.
-
- Packed CSSValueList::m_isSpaceSeparated into the CSSValue bit field
- and renamed it to m_isSpaceSeparatedValue, shrinking CSSValueList
- by one CPU word.
-
- Also renamed CSSValue::m_isImplicit to m_isImplicitInitialValue
- for good measure.
-
- * css/CSSInitialValue.h:
- (WebCore::CSSInitialValue::CSSInitialValue):
- * css/CSSValue.h:
- (WebCore::CSSValue::isImplicitInitialValue):
- (WebCore::CSSValue::CSSValue):
- * css/CSSValueList.cpp:
- (WebCore::CSSValueList::CSSValueList):
- (WebCore::CSSValueList::copy):
- (WebCore::CSSValueList::customCssText):
- * css/CSSValueList.h:
- (WebCore::CSSValueList::isSpaceSeparated):
-
-2011-12-02 Philippe Normand <pnormand@igalia.com>
-
- [GStreamer] Fullscreen controller support for the new WebKit Fullscreen API
- https://bugs.webkit.org/show_bug.cgi?id=66968
-
- Reviewed by Martin Robinson.
-
- * GNUmakefile.am: Don't use the Quicktime fullscreen CSS anymore,
- it wasn't suited for GTK in the first place anyway.
- * platform/gtk/RenderThemeGtk.cpp:
- (WebCore::RenderThemeGtk::extraFullScreenStyleSheet): Simply reuse
- GTK CSS.
-
-2011-12-03 Alejandro G. Castro <alex@igalia.com>
-
- [GTK] TextureMapperNode should not use Qt types and functions
- https://bugs.webkit.org/show_bug.cgi?id=73713
-
- Replace qreal with double and qMin with std::min.
-
- Reviewed by Noam Rosenthal.
-
- * platform/graphics/texmap/TextureMapperNode.cpp:
- (WebCore::solveCubicBezierFunction):
- (WebCore::solveStepsFunction):
-
-2011-12-03 Dan Winship <danw@gnome.org>
-
- [GTK] Remove lots of code that is now unnecessary after
- SoupRequestHTTP API changes.
- https://bugs.webkit.org/show_bug.cgi?id=71611
-
- Reviewed by Martin Robinson.
-
- No new tests; behavior is unchanged
-
- * platform/network/ResourceHandleInternal.h:
- (WebCore::ResourceHandleInternal::ResourceHandleInternal): remove
- no-longer-needed fields.
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::finishedCallback): remove this, and m_finished, which
- we no longer need to explicitly track
- (WebCore::statusWillBeHandledBySoup):
- (WebCore::soupErrorShouldCauseLoadFailure): No longer needed;
- SoupRequestHTTP's logic is now aligned with WebKit's.
- (WebCore::gotChunkCallback): remove gotChunkCallback, which
- is no longer needed
- (WebCore::startHTTPRequest):
- (WebCore::sendRequestCallback):
- (WebCore::gotHeadersCallback):
- (WebCore::contentSniffedCallback): merge the code from
- gotHeadersCallback and contentSniffedCallback into
- sendRequestCallback
- * platform/network/soup/ResourceResponseSoup.cpp:
- (WebCore::ResourceResponse::updateFromSoupMessage): move the
- sniffing override logic here
-
-2011-12-03 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r101904.
- http://trac.webkit.org/changeset/101904
- https://bugs.webkit.org/show_bug.cgi?id=73739
-
- It broke zillions of tests on all bot (Requested by
- Ossy_weekend on #webkit).
-
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::handlePostMessage):
-
-2011-12-02 Kentaro Hara <haraken@chromium.org>
-
- [Refactoring] Use join(", ", @arguments) to build a method argument string in CodeGenerator*.pm
- https://bugs.webkit.org/show_bug.cgi?id=73651
-
- Reviewed by Darin Adler.
-
- The code in CodeGenerator*.pm to build a method argument string is really dirty
- and error-prone. It is building an argument string incrementally judging whether
- ", " is necessary or not, like this:
-
- my $method = ... ? "func(" : "func(a";
- if (...) {
- $method .= $method =~ /\($/ ? "b" : ", b";
- }
- $method .= ")";
-
- Alternatively, we can refactor the code as follows:
-
- my $funcName = "func";
- my @arguments;
- push(@arguments, "a") if (...);
- push(@arguments, "b") if (...);
- my $method = $funcName . "(" . join(", ", @arguments) . ")";
-
- This patch just refactors the code, and generated .h and .cpp files should be
- exactly the same as the current .h and .cpp files.
-
- Tests: bindings/scripts/test/*
-
- * bindings/scripts/CodeGenerator.pm:
- (GetterExpression):
- (SetterExpression):
- * bindings/scripts/CodeGeneratorCPP.pm:
- (GenerateImplementation):
- * bindings/scripts/CodeGeneratorGObject.pm:
- ():
- * bindings/scripts/CodeGeneratorJS.pm:
- (GenerateImplementation):
- * bindings/scripts/CodeGeneratorObjC.pm:
- (GenerateImplementation):
- * bindings/scripts/CodeGeneratorV8.pm:
- (GenerateNormalAttrGetter):
- (GenerateNormalAttrSetter):
-
-2011-12-02 David Levin <levin@chromium.org>
-
- Rename WTF class from TemporarilyChange to TemporaryChange.
- https://bugs.webkit.org/show_bug.cgi?id=73479
-
- Reviewed by Eric Seidel.
-
- * ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
- * ForwardingHeaders/wtf/TemporaryChange.h: Added.
- * page/FrameView.cpp:
- (WebCore::FrameView::forceLayoutParentViewIfNeeded):
- (WebCore::FrameView::layout):
- (WebCore::FrameView::setScrollPosition):
- (WebCore::FrameView::autoSizeIfEnabled):
-
-2011-12-02 Armand Navabi <armand.navabi@gmail.com>
-
- ASSERT fails in updateState ACTION_DRAW case
- https://bugs.webkit.org/show_bug.cgi?id=73351
-
- Reviewed by James Robinson.
-
- Changed ASSERT in CCSchedulerStateMachine to include ( || !m_visible) as discussed in bug
- report. m_commitState is set to COMMIT_STATE_WAITING_FOR_FIRST_DRAW if m_needsCommit or
- !m_visible, so in ACTION_DRAW the assert should have both conditions.
-
- * platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
- (WebCore::CCSchedulerStateMachine::updateState):
-
-2011-12-02 Shawn Singh <shawnsingh@chromium.org>
-
- [chromium] Scissor rect optimization for chromium compositor
- https://bugs.webkit.org/show_bug.cgi?id=67341
-
- Reviewed by James Robinson.
-
- Mostly covered by damage tracker tests. Currently this relies on
- manually running layout tests, because this patch requires partial
- swaps that are not supported by DumpRenderTree. The feature
- automatically disables if partial swap is not supported.
-
- * platform/graphics/chromium/LayerRendererChromium.cpp:
- (WebCore::LayerRendererChromium::initialize):
- (WebCore::LayerRendererChromium::trackDamageForAllSurfaces):
- (WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
- (WebCore::LayerRendererChromium::drawLayersInternal):
- (WebCore::LayerRendererChromium::swapBuffers):
- (WebCore::LayerRendererChromium::drawLayer):
- * platform/graphics/chromium/LayerRendererChromium.h:
- * platform/graphics/chromium/cc/CCLayerTreeHost.h:
- (WebCore::CCSettings::CCSettings):
- (WebCore::LayerRendererCapabilities::LayerRendererCapabilities):
- * platform/graphics/chromium/cc/CCRenderSurface.cpp:
- (WebCore::CCRenderSurface::draw):
- * platform/graphics/chromium/cc/CCRenderSurface.h:
-
-2011-12-02 Dmitry Lomov <dslomov@google.com>
-
- https://bugs.webkit.org/show_bug.cgi?id=73691
- [JSC] Implement correct order of window.postMessage arguments.
-
- Reviewed by Geoffrey Garen.
-
- * bindings/js/JSDOMWindowCustom.cpp:
- (WebCore::handlePostMessage):
-
2011-12-02 Stephen Chenney <schenney@chromium.org>
REGRESSION (r91125): Polyline tool in google docs is broken
« no previous file with comments | « LayoutTests/svg/custom/zero-path-square-cap-rendering2-expected.txt ('k') | Source/WebCore/platform/graphics/cg/PathCG.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698