Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 9111002: Fixes improper boxing in obj.dynamic (Closed)

Created:
8 years, 11 months ago by Jennifer Messerly
Modified:
8 years, 11 months ago
Reviewers:
jimhug
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixes improper boxing in obj.dynamic http://code.google.com/p/dart/issues/detail?id=651 I considered the other fix (omitting the call entirely) but it gets a bit strange if someone overrides Object.dynamic. Committed: https://code.google.com/p/dart/source/detail?r=2977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M frog/lib/corelib.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M frog/minfrog View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Jennifer Messerly
tbr
8 years, 11 months ago (2012-01-05 02:10:42 UTC) #1
jimhug
8 years, 11 months ago (2012-01-11 18:59:15 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698