Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Side by Side Diff: src/builtins-ia32.cc

Issue 9111: Use 1 byte push REG instructions instead of the 2 byte ModRM version. (Closed)
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ic-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 639 matching lines...) Expand 10 before | Expand all | Expand 10 after
650 __ push(Immediate(ArgumentsAdaptorFrame::SENTINEL)); 650 __ push(Immediate(ArgumentsAdaptorFrame::SENTINEL));
651 651
652 // Push the function on the stack. 652 // Push the function on the stack.
653 __ push(edi); 653 __ push(edi);
654 654
655 // Preserve the number of arguments on the stack. Must preserve both 655 // Preserve the number of arguments on the stack. Must preserve both
656 // eax and ebx because these registers are used when copying the 656 // eax and ebx because these registers are used when copying the
657 // arguments and the receiver. 657 // arguments and the receiver.
658 ASSERT(kSmiTagSize == 1); 658 ASSERT(kSmiTagSize == 1);
659 __ lea(ecx, Operand(eax, eax, times_1, kSmiTag)); 659 __ lea(ecx, Operand(eax, eax, times_1, kSmiTag));
660 __ push(Operand(ecx)); 660 __ push(ecx);
661 } 661 }
662 662
663 663
664 static void LeaveArgumentsAdaptorFrame(MacroAssembler* masm) { 664 static void LeaveArgumentsAdaptorFrame(MacroAssembler* masm) {
665 // Retrieve the number of arguments from the stack. 665 // Retrieve the number of arguments from the stack.
666 __ mov(ebx, Operand(ebp, ArgumentsAdaptorFrameConstants::kLengthOffset)); 666 __ mov(ebx, Operand(ebp, ArgumentsAdaptorFrameConstants::kLengthOffset));
667 667
668 // Leave the frame. 668 // Leave the frame.
669 __ leave(); 669 __ leave();
670 670
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
893 // Register state for stub CallFunction (from CallFunctionStub in ic-ia32.cc). 893 // Register state for stub CallFunction (from CallFunctionStub in ic-ia32.cc).
894 // ----------- S t a t e ------------- 894 // ----------- S t a t e -------------
895 // No registers used on entry. 895 // No registers used on entry.
896 // ----------------------------------- 896 // -----------------------------------
897 Generate_DebugBreakCallHelper(masm, 0, false); 897 Generate_DebugBreakCallHelper(masm, 0, false);
898 } 898 }
899 899
900 #undef __ 900 #undef __
901 901
902 } } // namespace v8::internal 902 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/ic-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698