Source/core/page/Page.cpp - Issue 911083002: Carry out a resize even if no layout has been performed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/Page.cpp

Issue 911083002: Carry out a resize even if no layout has been performed. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Made needsLayout() true when forcing zero-height and added unit test Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/Page.cpp

diff --git a/Source/core/page/Page.cpp b/Source/core/page/Page.cpp

index a58f0006b43da66b0e9ffbc32c7e1b1a37a62ca4..4b0d0edd70954d1a30860cf081d9f5e53a7b9d7a 100644

--- a/Source/core/page/Page.cpp

+++ b/Source/core/page/Page.cpp

@@ -460,8 +460,10 @@ void Page::settingsChanged(SettingsDelegate::ChangeType changeType)

setNeedsRecalcStyleInAllFrames();

break;

case SettingsDelegate::ViewportDescriptionChange:

- if (mainFrame() && mainFrame()->isLocalFrame())

+ if (mainFrame() && mainFrame()->isLocalFrame()) {

deprecatedLocalMainFrame()->document()->updateViewportDescription();

+ deprecatedLocalMainFrame()->view()->didChangeForceLayoutHeightMode();

+ }

break;

case SettingsDelegate::MediaTypeChange:

if (m_mainFrame->isLocalFrame()) {

« Source/core/frame/FrameView.h ('K') | « Source/core/frame/FrameView.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | Source/web/tests/WebFrameTest.cpp » ('J')