Source/web/WebViewImpl.cpp - Issue 911083002: Carry out a resize even if no layout has been performed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 911083002: Carry out a resize even if no layout has been performed. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index 82a88ec00e70cee7c3f2b26c11940898042af41f..f08f02e9274ef3f148e922f1016c4265f0b25195 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -1822,7 +1822,7 @@ void WebViewImpl::resize(const WebSize& newSize)

FloatPoint viewportOffsetBeforeResize = pinchViewport.visibleRectInDocument().location();

// Relayout immediately to recalculate the minimum scale limit.

- if (view->needsLayout())

+ if (view->needsLayout() || (page()->settings().forceZeroLayoutHeight() && pinchVirtualViewportEnabled()))

hush (inactive) 2015/02/10 18:21:04 I think the initial purpose for forceZeroLayoutHei

aelias_OOO_until_Jul13 2015/02/10 21:16:57 No, the initial purpose is to avoid weird layout i

view->layout();

if (shouldAnchorAndRescaleViewport) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »