Carry out a resize even if no layout has been performed.

Source/web/tests/WebFrameTest.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1299 matching lines @@
     EXPECT_EQ(0.0, compositor->containerLayer()->size().height());
 
     // Two flags PinchVirtualViewportEnabled and ForceZeroLayoutHeight will cause the following
     // resize of viewport height to be ignored by the outer viewport (the container layer of
     // LayerCompositor). The height of the pinchViewport, however, is not affected.
     webViewHelper.webView()->resize(WebSize(viewportWidth, viewportHeight));
     EXPECT_FALSE(webViewHelper.webViewImpl()->mainFrameImpl()->frameView()->needsLayout());
     EXPECT_EQ(viewportWidth, webViewHelper.webViewImpl()->mainFrameImpl()->frameView()->layoutSize().width());
     EXPECT_EQ(0, webViewHelper.webViewImpl()->mainFrameImpl()->frameView()->layoutSize().height());
     EXPECT_EQ(viewportWidth, compositor->containerLayer()->size().width());
-    EXPECT_EQ(0.0, compositor->containerLayer()->size().height());
 
     LocalFrame* frame = webViewHelper.webViewImpl()->mainFrameImpl()->frame();
     PinchViewport& pinchViewport = frame->page()->frameHost().pinchViewport();
     EXPECT_EQ(viewportHeight, pinchViewport.containerLayer()->size().height());
     EXPECT_TRUE(pinchViewport.containerLayer()->platformLayer()->masksToBounds());
     EXPECT_FALSE(compositor->containerLayer()->platformLayer()->masksToBounds());
 }
 
 TEST_F(WebFrameTest, SetForceZeroLayoutHeight)
 {
@@ skipping 22 matching lines @@
     EXPECT_EQ(0, webViewHelper.webViewImpl()->mainFrameImpl()->frameView()->layoutSize().height());
 
     webViewHelper.webView()->resize(WebSize(viewportWidth * 2, viewportHeight));
     webViewHelper.webView()->layout();
     EXPECT_EQ(0, webViewHelper.webViewImpl()->mainFrameImpl()->frameView()->layoutSize().height());
 
     webViewHelper.webView()->settings()->setForceZeroLayoutHeight(false);
     EXPECT_LE(viewportHeight, webViewHelper.webViewImpl()->mainFrameImpl()->frameView()->layoutSize().height());
 }
 
+TEST_F(WebFrameTest, SetForceZeroLayoutHeightWorksWithRelayoutsWhenHeightChanged)
+{
+    UseMockScrollbarSettings mockScrollbarSettings;
+    registerMockedHttpURLLoad("button.html");
+
+    FixedLayoutTestWebViewClient client;
+    client.m_screenInfo.deviceScaleFactor = 1;
+    int viewportWidth = 640;
+    int viewportHeight = 480;
+
+    FrameTestHelpers::WebViewHelper webViewHelper;
+
+    webViewHelper.initializeAndLoad(m_baseURL + "button.html", true, 0, &client, configurePinchVirtualViewport);
+    webViewHelper.webView()->resize(WebSize(viewportWidth, 0));

[aelias_OOO_until_Jul13, 2015/02/12 19:49:17]

I don't think we should be setting 0 viewport height here, that doesn't match
what happens in reality and the WebFrameTest.SetForceZeroLayoutHeight test above
doesn't do it.

[boliu, 2015/02/12 20:04:43]

It does happen in reality. Some apps with wrap-contents webview will set the
webview size to 0 before anything is loaded. It's probably something like:

* setForceZeroLayoutHeight(true)
* resize(viewportWidth, 0)
* load content
* layout
* resize(viewportWidth, viewportHeight)
* layout

check input is not clipped

If this is initialized sized to viewportWidth x viewportHeight, I don't think
the test would fail without the fix.

[aelias_OOO_until_Jul13, 2015/02/12 20:08:37]

OK then, fine to leave as is, thanks for the clarification.

[boliu, 2015/02/12 20:10:27]

Should add some comments explaining this. No one will remember these details in
a week..

[gsennton, 2015/02/13 19:11:15]

Done.

+    webViewHelper.webView()->layout();
+
+    webViewHelper.webView()->settings()->setForceZeroLayoutHeight(true);
+    EXPECT_TRUE(webViewHelper.webViewImpl()->mainFrameImpl()->frameView()->needsLayout());
+
+    webViewHelper.webView()->resize(WebSize(viewportWidth, viewportHeight));
+
+    IntPoint hitPoint = IntPoint(30, 30); // button size is 100x100
+
+    RefPtrWillBeRawPtr<Node> hitNode = webViewHelper.webViewImpl()->mainFrameImpl()->frame()->eventHandler().hitTestResultAtPoint(hitPoint, HitTestRequest::ReadOnly | HitTestRequest::Active).innerNode();

[aelias_OOO_until_Jul13, 2015/02/12 19:49:17]

Could you send down an input event via handleGestureEvent, make the button do
something and verify that it happened instead?  That will give this test better
coverage.

[gsennton, 2015/02/13 19:11:15]

Done.

+    EXPECT_NE(nullptr, hitNode.get());
+    EXPECT_EQ(String("BUTTON"), hitNode->nodeName());
+}
+
 TEST_F(WebFrameTest, SetForceZeroLayoutHeightWorksAcrossNavigations)
 {
     UseMockScrollbarSettings mockScrollbarSettings;
     registerMockedHttpURLLoad("200-by-300.html");
     registerMockedHttpURLLoad("large-div.html");
 
     FixedLayoutTestWebViewClient client;
     client.m_screenInfo.deviceScaleFactor = 1;
     int viewportWidth = 640;
     int viewportHeight = 480;
@@ skipping 5691 matching lines @@
     EXPECT_EQ(1u, frameClient.navigationalDataReceivedCount());
 
     // Neither should a page reload.
     localFrame->reload();
     EXPECT_EQ(4u, frameClient.provisionalLoadCount());
     EXPECT_FALSE(frameClient.wasLastProvisionalLoadATransition());
     EXPECT_EQ(1u, frameClient.navigationalDataReceivedCount());
 }
 
 } // namespace