mojo/services/view_manager/public/cpp/lib/view_manager_context.cc - Issue 911073005: Drop all uses of //base except ObserverList from view mgr client lib

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/view_manager/public/cpp/lib/view_manager_context.cc

Issue 911073005: Drop all uses of //base except ObserverList from view mgr client lib (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: gn check Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/view_manager/public/cpp/lib/view_manager_context.cc

diff --git a/mojo/services/view_manager/public/cpp/lib/view_manager_context.cc b/mojo/services/view_manager/public/cpp/lib/view_manager_context.cc

index a47f59af79534be039925bda53b88ee89bc2a567..d1c2fd043d4930d38d329831312884e8b9ba7490 100644

--- a/mojo/services/view_manager/public/cpp/lib/view_manager_context.cc

+++ b/mojo/services/view_manager/public/cpp/lib/view_manager_context.cc

@@ -28,7 +28,9 @@ class ViewManagerContext::InternalState {

ViewManagerContext::ViewManagerContext(ApplicationImpl* application_impl)

: state_(new InternalState(application_impl)) {}

-ViewManagerContext::~ViewManagerContext() {}

+ViewManagerContext::~ViewManagerContext() {

+ delete state_;

void ViewManagerContext::Embed(const String& url) {

Embed(url, nullptr, nullptr);