Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 911073004: MIPS: Parsing: Make Scope not know about Isolate. (Closed)

Created:
5 years, 10 months ago by balazs.kilvady
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Parsing: Make Scope not know about Isolate. Port 5d68529be240a1fc9fcc67c8950ead4baf7604e4 Original commit message: Scope, like Parser, must be able to operate independent of Isolate and the V8 heap (for background parsing). After the heap-independent phase, there is a heap dependent phase, during which we do operations such as scope anaylysis. This CL makes the phases explicit by not telling Scope about the Isolate too early (during the heap-independent phase, Scope should know nothing about Isolate). This decreases the probability of accidental code changes which would add heap-dependent operations into the heap-independent phase. BUG= Committed: https://crrev.com/4dbfde37110b7108842829ee3cc17104816b1392 Cr-Commit-Position: refs/heads/master@{#26553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
balazs.kilvady
5 years, 10 months ago (2015-02-10 17:57:54 UTC) #2
dusmil.imgtec
lgtm.
5 years, 10 months ago (2015-02-10 17:59:34 UTC) #3
marja
lgtm
5 years, 10 months ago (2015-02-10 18:00:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911073004/1
5 years, 10 months ago (2015-02-10 18:00:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-10 19:09:34 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 19:09:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4dbfde37110b7108842829ee3cc17104816b1392
Cr-Commit-Position: refs/heads/master@{#26553}

Powered by Google App Engine
This is Rietveld 408576698