Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 911053005: optional res-scale parameter to getFillPath (Closed)

Created:
5 years, 10 months ago by reed1
Modified:
5 years, 10 months ago
Reviewers:
_cary, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

optional res-scale parameter to getFillPath BUG=skia: NOTREECHECKS=True TBR= Committed: https://skia.googlesource.com/skia/+/05d9044de4f1c6e791df66a425638752daac4c6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -26 lines) Patch
M include/core/SkPaint.h View 1 chunk +8 lines, -2 lines 0 comments Download
M include/core/SkStrokeRec.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkDraw.cpp View 2 chunks +13 lines, -1 line 0 comments Download
M src/core/SkPaint.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkStroke.h View 2 chunks +15 lines, -0 lines 0 comments Download
M src/core/SkStroke.cpp View 4 chunks +13 lines, -11 lines 0 comments Download
M src/core/SkStrokeRec.cpp View 3 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
reed1
expect only the new strokecircle gm to need rebaselining.
5 years, 10 months ago (2015-02-12 20:05:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911053005/1
5 years, 10 months ago (2015-02-12 20:06:14 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-12 20:06:15 UTC) #5
_cary
lgtm
5 years, 10 months ago (2015-02-12 20:46:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911053005/1
5 years, 10 months ago (2015-02-12 21:32:34 UTC) #10
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-12 21:32:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911053005/1
5 years, 10 months ago (2015-02-12 21:35:44 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 21:35:56 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/05d9044de4f1c6e791df66a425638752daac4c6b

Powered by Google App Engine
This is Rietveld 408576698