Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 911043002: Sort GYP files under chrome using tools/sort_sources.py (Closed)

Created:
5 years, 10 months ago by satorux1
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sort GYP files under chrome using tools/sort_sources.py For tools/sort_sources.py to be useful, existing GYP files should be sorted. Also fix a bug in sort_sources.py where .mm and .rc files weren't sorted correctly. BUG=456014 TEST=everything should build as before Committed: https://crrev.com/fb19c782220e3d5ad1174d1175fdb01928296264 Cr-Commit-Position: refs/heads/master@{#315927}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix .mm files #

Patch Set 3 : fix .rc files too #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -302 lines) Patch
M chrome/chrome.gyp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 36 chunks +74 lines, -74 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 32 chunks +68 lines, -68 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_installer.gypi View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_installer_util.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_nibs.gyp View 1 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/chrome_renderer.gypi View 5 chunks +19 lines, -19 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 33 chunks +58 lines, -58 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 30 chunks +38 lines, -38 lines 0 comments Download
M chrome/chrome_utility.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/sort_sources.py View 1 2 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
satorux1
https://codereview.chromium.org/911043002/diff/1/chrome/chrome_dll.gypi File chrome/chrome_dll.gypi (right): https://codereview.chromium.org/911043002/diff/1/chrome/chrome_dll.gypi#newcode86 chrome/chrome_dll.gypi:86: 'app/chrome_main_mac.mm', oops. .mm should be handled too.
5 years, 10 months ago (2015-02-10 08:15:38 UTC) #1
satorux1
PTAL
5 years, 10 months ago (2015-02-10 08:19:40 UTC) #3
Lei Zhang
Sorted file lists make me happy. LGTM!
5 years, 10 months ago (2015-02-10 20:01:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911043002/40001
5 years, 10 months ago (2015-02-10 20:30:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/41792)
5 years, 10 months ago (2015-02-10 20:37:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/911043002/60001
5 years, 10 months ago (2015-02-12 03:19:28 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-12 04:02:12 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 04:02:57 UTC) #13
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/fb19c782220e3d5ad1174d1175fdb01928296264
Cr-Commit-Position: refs/heads/master@{#315927}

Powered by Google App Engine
This is Rietveld 408576698