Issue 9110008: Inline Math.max and Math.min in crankshaft.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9110008: Inline Math.max and Math.min in crankshaft. (Closed)

Created:
8 years, 11 months ago by Yang

Modified:
8 years, 11 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Inline Math.max and Math.min in crankshaft. BUG=v8:1325 TEST=mjsunit/math-min-max.js

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+298 lines, -1 line)			Patch
M	src/hydrogen.cc	View	1 chunk	+19 lines, -0 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	2 chunks	+33 lines, -0 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+123 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	2 chunks	+27 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	test/mjsunit/math-min-max.js	View	1 chunk	+52 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Yang

8 years, 11 months ago (2012-01-05 16:05:06 UTC) #1

This patch is only a first draft, it cannot be committed before it's ported to
all architectures.  Since this is my first attempt at implementing a hydrogen
instruction, there may be things I overlooked or stuff that could be done more
elegantly.  Please take a look.

Expand Messages | Collapse Messages