Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 910973002: Make Blink test targets generally visible. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
CC:
blink-reviews, blink-reviews-wtf_chromium.org, aandrey+blink_chromium.org, Mikhail, brettw
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make Blink test targets generally visible. This makes heap_unittests, platform_unittests and wtf_unittests targets public, so we can refer to them outside of Blink, in Chromium's root BUILD.gn file. Tested with the following command line: $ gn gen ../../out_gn/Debug $ ninja -C ../../out_gn/Debug all_blink With the following diff in Chromium's BUILD.gn to test the new behavior. +group("gn_all") { + # This should not be linked into production and depends on test targets. + testonly = true + + deps = [ + "//third_party/WebKit/public:blink_tests", + ] +} BUG=None TEST=see above R=dpranke@chromium.org TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189894

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : blink_tests target #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M public/BUILD.gn View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
tfarina
Is there a better visibility than [*] that I should apply?
5 years, 10 months ago (2015-02-09 22:34:03 UTC) #1
Dirk Pranke
This is the change I was initially thinking of. However, Brett may have convinced me ...
5 years, 10 months ago (2015-02-09 22:45:27 UTC) #2
tfarina
Changed to blink_tests. Please, take another look.
5 years, 10 months ago (2015-02-10 00:23:43 UTC) #3
Dirk Pranke
lgtm
5 years, 10 months ago (2015-02-10 00:39:55 UTC) #4
tfarina
TBRing Jochen for this...
5 years, 10 months ago (2015-02-10 11:31:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910973002/40001
5 years, 10 months ago (2015-02-10 11:32:50 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 12:46:06 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189894

Powered by Google App Engine
This is Rietveld 408576698