runtime/lib/core_patch.dart - Issue 910923002: Make yield* throw an error if not yielding an Iterable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/core_patch.dart

Issue 910923002: Make yield* throw an error if not yielding an Iterable (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/core_patch.dart

===================================================================

--- runtime/lib/core_patch.dart (revision 43603)

+++ runtime/lib/core_patch.dart (working copy)

@@ -64,8 +64,10 @@

current = null;

return false;

}

- if (isYieldEach && (current is Iterable)) {

- yieldEachIterator = current.iterator;

+ if (isYieldEach) {

+ // Spec mandates: it is a dynamic error if the class of [the object

+ // returned by yield*] does not implement Iterable.

+ yieldEachIterator = (current as Iterable).iterator;

continue;

}

return true;

« no previous file with comments | « no previous file | tests/language/language_dart2js.status » ('j') | no next file with comments »