Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 910793002: Allow empty line when parsing properties files. (Closed)

Created:
5 years, 10 months ago by qsr
Modified:
5 years, 10 months ago
Reviewers:
jbudorick, Sami
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow empty line when parsing properties files. R=skyostil@chromium.org Committed: https://crrev.com/f91e8d7a39a9a5db7e596a6eb8f2ca8c1d58b324 Cr-Commit-Position: refs/heads/master@{#315354}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/android/pylib/device/device_utils.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
qsr
5 years, 10 months ago (2015-02-09 15:49:07 UTC) #1
Sami
lgtm.
5 years, 10 months ago (2015-02-09 16:03:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910793002/1
5 years, 10 months ago (2015-02-09 16:05:02 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/41400)
5 years, 10 months ago (2015-02-09 16:12:45 UTC) #6
jbudorick
lgtm noparent is a relic from when build/OWNERS was *. I think we can remove ...
5 years, 10 months ago (2015-02-09 16:14:18 UTC) #8
qsr
On 2015/02/09 16:14:18, jbudorick wrote: > lgtm > > noparent is a relic from when ...
5 years, 10 months ago (2015-02-09 16:15:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910793002/1
5 years, 10 months ago (2015-02-09 16:16:09 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/24382)
5 years, 10 months ago (2015-02-09 17:41:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910793002/1
5 years, 10 months ago (2015-02-09 17:54:01 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 18:53:44 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 18:54:14 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f91e8d7a39a9a5db7e596a6eb8f2ca8c1d58b324
Cr-Commit-Position: refs/heads/master@{#315354}

Powered by Google App Engine
This is Rietveld 408576698