src/log.cc - Issue 910773002: Propagate Deopt reason to cpu-profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/log.cc

Issue 910773002: Propagate Deopt reason to cpu-profiler (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: comments addressed Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/log.cc

diff --git a/src/log.cc b/src/log.cc

index 3f1c970885183f88721d2510d8aa72c6162b98bb..35cf0aa90bbbdd7eb1fba0dab19049c1eb486693 100644

--- a/src/log.cc

+++ b/src/log.cc

@@ -911,9 +911,10 @@ void Logger::SharedLibraryEvent(const std::string& library_path,

}

-void Logger::CodeDeoptEvent(Code* code) {

- if (!log_->IsEnabled()) return;

- DCHECK(FLAG_log_internal_timer_events);

+void Logger::CodeDeoptEvent(Code* code, int bailout_id, Address from,

+ int fp_to_sp_delta) {

+ PROFILER_LOG(CodeDeoptEvent(code, bailout_id, from, fp_to_sp_delta));

+ if (!log_->IsEnabled() || !FLAG_log_internal_timer_events) return;

Log::MessageBuilder msg(log_);

int since_epoch = static_cast<int>(timer_.Elapsed().InMicroseconds());

msg.Append("code-deopt,%ld,%d", since_epoch, code->CodeSize());