Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: mojo/public/mojo.gni

Issue 910763002: Expose ability to download network service impl in SDK. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Fixes Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/module_args/mojo.gni") 5 import("//build/module_args/mojo.gni")
6 6
7 # If using the prebuilt shell, gate its usage by the platforms for which it is 7 # If using the prebuilt shell, gate its usage by the platforms for which it is
8 # published. 8 # published.
9 if (!defined(use_prebuilt_mojo_shell) || use_prebuilt_mojo_shell) { 9 if (!defined(use_prebuilt_mojo_shell) || use_prebuilt_mojo_shell) {
10 use_prebuilt_mojo_shell = is_linux || is_android 10 use_prebuilt_mojo_shell = is_linux || is_android
11 } 11 }
12 12
13 # If using the prebuilt network service, gate its usage by the platforms for
14 # which it is published.
15 if (!defined(use_prebuilt_network_service) || use_prebuilt_network_service) {
16 # The prebuilt Mojo shell packages the network service on Android.
ppi 2015/02/10 16:49:50 nit: I think s/packages/contains/ would stress tha
blundell 2015/02/11 21:06:17 Done.
17 use_prebuilt_network_service =
18 is_linux || (is_android && !use_prebuilt_mojo_shell)
ppi 2015/02/10 16:49:50 Is this part needed? On Android the choice to pull
blundell 2015/02/11 21:06:17 My thought is that it's weird and a little confusi
ppi 2015/02/12 13:36:49 Right, but isn't building it locally when it's nev
blundell 2015/02/12 13:57:41 Yes, you're right (I think you meant *more* weird)
19 }
20
13 # The absolute path to the directory containing the mojo public SDK (i.e., the 21 # The absolute path to the directory containing the mojo public SDK (i.e., the
14 # directory containing mojo/public). The build files within the Mojo public 22 # directory containing mojo/public). The build files within the Mojo public
15 # SDK use this variable to allow themselves to be parameterized by the location 23 # SDK use this variable to allow themselves to be parameterized by the location
16 # of the public SDK within a client repo. 24 # of the public SDK within a client repo.
17 mojo_root = get_path_info("../..", "abspath") 25 mojo_root = get_path_info("../..", "abspath")
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698