build/module_args/mojo.gni - Issue 910763002: Expose ability to download network service impl in SDK.

Side by Side Diff: build/module_args/mojo.gni

Issue 910763002: Expose ability to download network service impl in SDK. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Fixes Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 # To use the prebuilt shell, simply omit this variable. Note that the prebuilt	5 # To use the prebuilt shell, simply omit this variable. Note that the prebuilt

6 # shell will be used only on platforms for which it is published (currently	6 # shell will be used only on platforms for which it is published (currently

7 # Linux and Android).	7 # Linux and Android).

8 use_prebuilt_mojo_shell = false	8 use_prebuilt_mojo_shell = false

	9

	10 # To use the prebuilt network service, set this variable to true or simply omit
	ppi 2015/02/10 16:49:50 Should both comments go the other way, ie. "By def Should both comments go the other way, ie. "By default a prebuilt network service is used. To use a locally built network service set this variable to false." ? jamesr 2015/02/10 22:45:21 Yeah, I think the default should be prebuilt (here Show quoted text On 2015/02/10 16:49:50, ppi wrote: > Should both comments go the other way, ie. "By default a prebuilt network > service is used. To use a locally built network service set this variable to > false." ? Yeah, I think the default should be prebuilt (here the mojo repo is the odd one out) blundell 2015/02/11 21:06:17 Changed the comments. The code defaults to prebuil Show quoted text On 2015/02/10 22:45:21, jamesr wrote: > On 2015/02/10 16:49:50, ppi wrote: > > Should both comments go the other way, ie. "By default a prebuilt network > > service is used. To use a locally built network service set this variable to > > false." ? > > Yeah, I think the default should be prebuilt (here the mojo repo is the odd one > out) Changed the comments. The code defaults to prebuilt if the variable isn't defined. ppi@ offline commented that it's a little bizarre to have undefined mean "true" instead of "false", and that it would be more logical to have a variable "build_network_service_from_source" that is false if undefined. I'm happy either way; if changing this var, I think it would make sense to make a corresponding change to use_prebuilt_mojo_shell. ppi 2015/02/12 13:36:49 Yeah, flipping both flags around sounds good to me Show quoted text On 2015/02/11 21:06:17, blundell wrote: > On 2015/02/10 22:45:21, jamesr wrote: > > On 2015/02/10 16:49:50, ppi wrote: > > > Should both comments go the other way, ie. "By default a prebuilt network > > > service is used. To use a locally built network service set this variable to > > > false." ? > > > > Yeah, I think the default should be prebuilt (here the mojo repo is the odd > one > > out) > > Changed the comments. The code defaults to prebuilt if the variable isn't > defined. ppi@ offline commented that it's a little bizarre to have undefined > mean "true" instead of "false", and that it would be more logical to have a > variable "build_network_service_from_source" that is false if undefined. I'm > happy either way; if changing this var, I think it would make sense to make a > corresponding change to use_prebuilt_mojo_shell. Yeah, flipping both flags around sounds good to me, so does doing this in a follow-up.
	11 # it.

	12 use_prebuilt_network_service = true

OLD	NEW

« no previous file with comments | « DEPS ('k') | mojo/BUILD.gn » ('j') | mojo/public/mojo.gni » ('J')