Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 910713002: Restrict floats over SVGSVGElement to finite values. (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
CC:
blink-reviews, krit, arv+blink, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Inactive, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Restrict floats over SVGSVGElement to finite values. Add [TypeChecking=Unrestricted] to this interface, constraining the setter for "currentScale" and setCurrentTime() to work over finite floats. This aligns behavior with Gecko. R=fs@opera.com BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189812

Patch Set 1 #

Patch Set 2 : Update svg/animations/animate-setcurrenttime.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -16 lines) Patch
M LayoutTests/svg/animations/animate-setcurrenttime.html View 1 5 chunks +17 lines, -11 lines 0 comments Download
M LayoutTests/svg/animations/animate-setcurrenttime-expected.txt View 1 2 chunks +7 lines, -2 lines 0 comments Download
A LayoutTests/svg/dom/SVGSVGElement-currentScale-NaN-no-crash.html View 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/svg/dom/SVGSVGElement-currentScale-NaN-no-crash-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/svg/dom/SVGSVGElement-currentTime.html View 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/svg/dom/SVGSVGElement-currentTime-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGSVGElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
sof
Please take a look.
5 years, 10 months ago (2015-02-09 12:50:32 UTC) #2
fs
lgtm
5 years, 10 months ago (2015-02-09 12:53:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910713002/20001
5 years, 10 months ago (2015-02-09 12:54:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/42081)
5 years, 10 months ago (2015-02-09 14:15:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910713002/20001
5 years, 10 months ago (2015-02-09 14:49:22 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 16:16:07 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189812

Powered by Google App Engine
This is Rietveld 408576698