Source/web/FrameLoaderClientImpl.cpp - Issue 910693004: Changing input type from the char key to the key down for allowing background tabs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 910693004: Changing input type from the char key to the key down for allowing background tabs. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/FrameLoaderClientImpl.cpp

diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp

index e63ced73b452873d7737768e36fcf2e11c652b92..706b4b622586cadc904d4564a73962bc2aa981a7 100644

--- a/Source/web/FrameLoaderClientImpl.cpp

+++ b/Source/web/FrameLoaderClientImpl.cpp

@@ -472,7 +472,7 @@ void FrameLoaderClientImpl::dispatchDidChangeThemeColor()

static bool allowCreatingBackgroundTabs()

{

const WebInputEvent* inputEvent = WebViewImpl::currentInputEvent();

- if (!inputEvent || (inputEvent->type != WebInputEvent::MouseUp && inputEvent->type != WebInputEvent::Char))

+ if (!inputEvent || (inputEvent->type != WebInputEvent::MouseUp && (inputEvent->type != WebInputEvent::RawKeyDown && inputEvent->type != WebInputEvent::KeyDown)))

return false;

unsigned short buttonNumber;

« no previous file with comments | « no previous file | no next file » | no next file with comments »