Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 910683002: Introduce a compile method that takes context extensions (Closed)

Created:
4 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 7 months ago
Reviewers:
Yang
CC:
PaweĊ‚ Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce a compile method that takes context extensions BUG=chromium:456192 R=yangguo@chromium.org LOG=y Committed: https://crrev.com/30674bdeb45241836bc309e42f008e66908f65e1 Cr-Commit-Position: refs/heads/master@{#26530}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
M include/v8.h View 1 chunk +14 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jochen (gone - plz use gerrit)
4 years, 7 months ago (2015-02-09 09:49:49 UTC) #1
Yang
lgtm with comment. https://codereview.chromium.org/910683002/diff/1/test/cctest/test-compiler.cc File test/cctest/test-compiler.cc (right): https://codereview.chromium.org/910683002/diff/1/test/cctest/test-compiler.cc#newcode419 test/cctest/test-compiler.cc:419: CcTest::isolate(), &script_source, env.local(), 1, &math); Would ...
4 years, 7 months ago (2015-02-09 10:21:19 UTC) #2
Yang
lgtm with comment.
4 years, 7 months ago (2015-02-09 10:21:23 UTC) #3
jochen (gone - plz use gerrit)
done
4 years, 7 months ago (2015-02-09 14:49:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910683002/20001
4 years, 7 months ago (2015-02-09 14:50:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2015-02-09 15:15:34 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2015-02-09 15:16:41 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/30674bdeb45241836bc309e42f008e66908f65e1
Cr-Commit-Position: refs/heads/master@{#26530}

Powered by Google App Engine
This is Rietveld 408576698