Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 910623002: X87: Megamorphic KeyedLoadIC needs special handling for vector ics (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Megamorphic KeyedLoadIC needs special handling for vector ics port 16843e239d95f5e8eaaa06d2a0a6e371298fe11f (r26381) original commit message: Megamorphic KeyedLoadIC needs special handling for vector ics. When --vector-ics is true, we still tail-call to the hand-written megamorphic KeyedLoadIC (formerly "generic"). Now that this code uses the megamorphic cache, it needs to deal properly with the vector and slot registers. Achieve this with a sentinel vectors/slot combo. BUG= R=weiliang.lin@intel.com Committed: https://chromium.googlesource.com/v8/v8/+/b2e15510a845020554ea6b3430f5cf213a08fc54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M src/ic/x87/ic-x87.cc View 1 chunk +19 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL. thanks
5 years, 10 months ago (2015-02-09 06:22:21 UTC) #2
Weiliang
lgtm
5 years, 10 months ago (2015-02-09 06:31:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910623002/1
5 years, 10 months ago (2015-02-09 06:31:47 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b2e15510a845020554ea6b3430f5cf213a08fc54 Cr-Commit-Position: refs/heads/master@{#26508}
5 years, 10 months ago (2015-02-09 06:34:37 UTC) #6
chunyang.dai
5 years, 10 months ago (2015-02-09 06:34:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b2e15510a845020554ea6b3430f5cf213a08fc54 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698