Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 910613002: Do not open a downloaded file with generic file handler. (Closed)

Created:
5 years, 10 months ago by yawano
Modified:
5 years, 10 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not open a downloaded file with generic file handler. BUG=chrome-os-partner:36486 TEST=none Committed: https://crrev.com/78914d359744a5e6cbdaf67c55530142b8645ab4 Cr-Commit-Position: refs/heads/master@{#315267}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use auto and for-range loop. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M chrome/browser/chromeos/file_manager/open_util.cc View 1 1 chunk +14 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yawano
PTAL. Thank you!
5 years, 10 months ago (2015-02-09 04:23:54 UTC) #2
mtomasz
lgtm (with nit), thanks! https://codereview.chromium.org/910613002/diff/1/chrome/browser/chromeos/file_manager/open_util.cc File chrome/browser/chromeos/file_manager/open_util.cc (right): https://codereview.chromium.org/910613002/diff/1/chrome/browser/chromeos/file_manager/open_util.cc#newcode109 chrome/browser/chromeos/file_manager/open_util.cc:109: for (size_t i = 0; ...
5 years, 10 months ago (2015-02-09 04:28:00 UTC) #3
yawano
Thank you! https://codereview.chromium.org/910613002/diff/1/chrome/browser/chromeos/file_manager/open_util.cc File chrome/browser/chromeos/file_manager/open_util.cc (right): https://codereview.chromium.org/910613002/diff/1/chrome/browser/chromeos/file_manager/open_util.cc#newcode109 chrome/browser/chromeos/file_manager/open_util.cc:109: for (size_t i = 0; i < ...
5 years, 10 months ago (2015-02-09 04:44:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910613002/20001
5 years, 10 months ago (2015-02-09 04:44:40 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-09 05:12:43 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 05:13:38 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/78914d359744a5e6cbdaf67c55530142b8645ab4
Cr-Commit-Position: refs/heads/master@{#315267}

Powered by Google App Engine
This is Rietveld 408576698