Issue 910493002: Revert of faster edge re-sort, drop trailing edges

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 910493002: Revert of faster edge re-sort, drop trailing edges (Closed)

Created:
5 years, 10 months ago by reed2

Modified:
5 years, 10 months ago

Reviewers:
caryclark, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of faster edge re-sort, drop trailing edges (patchset #4 id:60001 of https://codereview.chromium.org/891613003/) Reason for revert: may be breaking layouttests... Original issue's description: > faster edge re-sort, drop trailing edges > > 1. drop edges that are wholly on the right (in the non-convex walker) > 2. scan and swap once, instead of swapping as we go during re-sort > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/38f1c00772539dcbeccbfa3c45d94bdc4acf3518 TBR=caryclark@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c319d075eab86cacfd7aba27859b72bbf8fc0a64

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -49 lines)			Patch
M	src/core/SkEdgeBuilder.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/core/SkEdgeBuilder.cpp	View	4 chunks	+7 lines, -7 lines	0 comments	Download
M	src/core/SkLineClipper.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkLineClipper.cpp	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	src/core/SkScan_Path.cpp	View	5 chunks	+26 lines, -33 lines	0 comments	Download

Total messages: 3 (0 generated)

reed2

Created Revert of faster edge re-sort, drop trailing edges

5 years, 10 months ago (2015-02-07 02:07:00 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910493002/1

5 years, 10 months ago (2015-02-07 02:07:33 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-07 02:07:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c319d075eab86cacfd7aba27859b72bbf8fc0a64