Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Issue 910453002: Create PowerMonitor while starting aura_demo and views_examples_exe (Closed)

Created:
5 years, 10 months ago by ckocagil
Modified:
5 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create PowerMonitor while starting aura_demo and views_examples_exe R=sky Committed: https://crrev.com/8a06497840cf522f0cbbce98a2c6b33329231504 Cr-Commit-Position: refs/heads/master@{#315325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M ui/aura/demo/demo_main.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/views/examples/examples_main.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ckocagil
Lack of PowerMonitor causes a DCHECK to be hit. base::debug::StackTrace::StackTrace [0x1008B6F1+33] (c:\chromium\src\base\debug\stack_trace_win.cc:209) logging::LogMessage::~LogMessage [0x100D462F+63] (c:\chromium\src\base\logging.cc:544) ...
5 years, 10 months ago (2015-02-06 23:21:40 UTC) #1
sky
LGTM
5 years, 10 months ago (2015-02-09 15:53:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/910453002/1
5 years, 10 months ago (2015-02-09 16:39:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 17:05:54 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 17:06:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a06497840cf522f0cbbce98a2c6b33329231504
Cr-Commit-Position: refs/heads/master@{#315325}

Powered by Google App Engine
This is Rietveld 408576698