Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 9104: Dispatch tables (Closed)

Created:
12 years, 1 month ago by Christian Plesner Hansen
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

- Implemented dispatch tables that takes a number of arbitrary indexed character ranges and turns them into a set of disjoint ranges with an associated set of the indices of the character ranges from which they originated. - Removed the complicated character range implementation and the associated tests. - Implemented the remaining character class escapes and simplified a few tests that had become complicated with the translation of class escapes to simple ranges.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+750 lines, -537 lines) Patch
M src/ast.h View 2 chunks +1 line, -40 lines 0 comments Download
M src/ast.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/checks.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/jsregexp.h View 1 chunk +147 lines, -82 lines 0 comments Download
M src/jsregexp.cc View 3 chunks +172 lines, -192 lines 1 comment Download
M src/jsregexp-inl.h View 1 chunk +199 lines, -25 lines 0 comments Download
M src/list.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/list-inl.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/parser.cc View 6 chunks +33 lines, -18 lines 0 comments Download
M test/cctest/test-regexp.cc View 8 chunks +183 lines, -177 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Christian Plesner Hansen
12 years, 1 month ago (2008-11-04 09:28:14 UTC) #1
Erik Corry
12 years, 1 month ago (2008-11-04 09:48:57 UTC) #2
LGTM

http://codereview.chromium.org/9104/diff/1/6
File src/jsregexp.cc (right):

http://codereview.chromium.org/9104/diff/1/6#newcode908
Line 908: ZoneList<CharacterRange>* ranges) {
I guess it's implicit here that the class does not contain 0 of ffff?

Powered by Google App Engine
This is Rietveld 408576698