Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: net/spdy/spdy_framer_test.cc

Issue 910393003: Rename WriteString to WriteStringPiece16 in SpdyFrameBuilder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_framer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_framer_test.cc
diff --git a/net/spdy/spdy_framer_test.cc b/net/spdy/spdy_framer_test.cc
index c2979131cf9d1e03845340d26c073061b5682797..f292c5408c028b2da6c2923948611cbe0eb6926c 100644
--- a/net/spdy/spdy_framer_test.cc
+++ b/net/spdy/spdy_framer_test.cc
@@ -871,10 +871,10 @@ TEST_P(SpdyFramerTest, DuplicateHeader) {
if (IsSpdy2()) {
frame.WriteUInt16(2); // Number of headers.
- frame.WriteString("name");
- frame.WriteString("value1");
- frame.WriteString("name");
- frame.WriteString("value2");
+ frame.WriteStringPiece16("name");
+ frame.WriteStringPiece16("value1");
+ frame.WriteStringPiece16("name");
+ frame.WriteStringPiece16("value2");
} else {
frame.WriteUInt32(2); // Number of headers.
frame.WriteStringPiece32("name");
@@ -917,8 +917,8 @@ TEST_P(SpdyFramerTest, MultiValueHeader) {
string value("value1\0value2", 13);
if (IsSpdy2()) {
frame.WriteUInt16(1); // Number of headers.
- frame.WriteString("name");
- frame.WriteString(value);
+ frame.WriteStringPiece16("name");
+ frame.WriteStringPiece16(value);
} else if (spdy_version_ > SPDY3) {
// TODO(jgraettinger): If this pattern appears again, move to test class.
std::map<string, string> header_set;
« no previous file with comments | « net/spdy/spdy_framer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698